From: Govindarajulu Varadarajan <govindarajulu90@gmail.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
Krzysztof Halasa <khc@pm.waw.pl>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
netdev@vger.kernel.orgdevicetree@vger.kernel.org,
jerome.chantelauze.ext@c-s.fr
Subject: Re: [PATCH v2] WAN: Adding support for Infineon PEF2256 E1 chipset (FALC56)
Date: Fri, 1 Nov 2013 21:06:25 +0530 (IST) [thread overview]
Message-ID: <alpine.LNX.2.03.1311012057090.2407@gmail.com> (raw)
In-Reply-To: <201311011501.rA1F1suj007279@localhost.localdomain>
On Fri, 1 Nov 2013, Christophe Leroy wrote:
> diff -urN a/drivers/net/wan/pef2256.c b/drivers/net/wan/pef2256.c
[..]
> +static int pef2256_remove(struct platform_device *pdev)
> +{
> + struct net_device *ndev = dev_get_drvdata(&pdev->dev);
> + struct pef2256_dev_priv *priv = dev_to_hdlc(ndev)->priv;
> +
> +
> + device_remove_file(priv->dev, &dev_attr_regs);
> + device_remove_file(priv->dev, &dev_attr_Tx_TS);
> + device_remove_file(priv->dev, &dev_attr_Rx_TS);
> + device_remove_file(priv->dev, &dev_attr_mode);
> +
> + unregister_hdlc_device(priv->netdev);
> +
> + free_netdev(priv->netdev);
> +
> + iounmap(priv->base_addr);
> +
> + kfree(priv);
> +
> + dev_set_drvdata(&pdev->dev, NULL);
dev_set_drvdata is not necessary. driver core clears the driver data to NULL
after device_release or on probe failure.
//govind
next prev parent reply other threads:[~2013-11-01 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 15:01 [PATCH v2] WAN: Adding support for Infineon PEF2256 E1 chipset (FALC56) Christophe Leroy
2013-11-01 15:36 ` Govindarajulu Varadarajan [this message]
2013-11-02 22:26 ` Francois Romieu
2013-11-15 15:17 ` thomas.langer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.03.1311012057090.2407@gmail.com \
--to=govindarajulu90@gmail.com \
--cc=christophe.leroy@c-s.fr \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=khc@pm.waw.pl \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.orgdevicetree \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).