From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52E823A5445 for ; Thu, 23 Jul 2026 06:29:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784788200; cv=none; b=ioce37VlIfMnKzJJ3j4IKOPuRqM0WzpZNttNs2lbOYyEV/8W3iYSSVcyY3wcztMJpJUXypCFi2OKZyGqdYNyb0xr5s0shrUMWF8n5MtoR/rZa/W0bAA7+xDFLjgK6hy5//GCS8FnntJB8nrrmAI0LLYtUb/bDYJTIFPSohJC62Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784788200; c=relaxed/simple; bh=uozDH4XEIfou8SOxvvK+z4mvTO/pfJIURoO4Y8ZM6LA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O3aOguKD06iV0d/qFqOhQNI7oj31zeXBXe6vd8Cny/65RKyul2S/EYlbCfFtVb2vXFYZ/A7C1cdWOJEzxdahZAHXnnxHULBedVMYG46h4H0rdVmUQKIKhvLHJpLNsS400qNTCNwO2WBgTj7y2+yaMTog/z7Nna3s/7Z+aLE4vp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=NHG+g/P/; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="NHG+g/P/" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-4798bea72f9so145702f8f.1 for ; Wed, 22 Jul 2026 23:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784788197; x=1785392997; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=uozDH4XEIfou8SOxvvK+z4mvTO/pfJIURoO4Y8ZM6LA=; b=NHG+g/P/bUGjqS1muu1hi2MTDTYqc3WJmQ4kmoSpKP8plbhkwHH6BXtZKrQsgH6SJ8 7X6MUzEZUt/mi62jRRc5O3QK9d5GgRLbWvknmKUayVkLgkydV2xXpnIlVBcu739nJoHJ 4mSNHR6eoHBrAf1tRwu01lq3sK5m/6rClQ2HlfLz4vGI0kyFjdasCO0k5Dni4Z14AN0Z proSqh3I4NvD40Q8RonpF/gp3LYayRcHIQ1Rk4VwzOMQD6OlzRdgjbN5QhCrmXz7CaNZ rKA9TILcKa4aMPZErqtgWF8RrCvxRasypLvnUvM2+pD8c5nrQMUpzpIu8BT9tbsLuMay uBuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784788197; x=1785392997; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uozDH4XEIfou8SOxvvK+z4mvTO/pfJIURoO4Y8ZM6LA=; b=HFRjS9xddPKotCliXTtED0v8znOmnDQ9BBqWzwJyJzZBvLFrMTdCUalbHYOchseg3t aAKUSqNQm6fI42aMDqYlmD9TIChrlQe8mfencJ+w1DloxPtjxRuAxjf/+GCyNyqVTdPq 2MO0ZYcpJFMRL4ULHc6qs5vrPIMRoixH/J4ItLCyP0zAOKRvk3IHy7i2g4dMF8Dxz5f3 AlNXxpTM7M91JYUp7NJ9ZDxeC8jMJ1LWTh1EOSYTW22dqjJU6c8QZx1JYQbzZEY+Qt4I +0RehZSwK/2MFdMn8/k45ySUKmrm5w+k4w1yJnYUHky9HwRfGRhMWrCaJPil77tS2ALM YTkQ== X-Forwarded-Encrypted: i=1; AHgh+RpHqrj72G0pBJ9/8q7/5htFy2er/ZQX7Kb7/VvWYD5N2ezE3FwpIO9JdIa0+Ap123f3AWRhso4qGr0+@vger.kernel.org X-Gm-Message-State: AOJu0YwNGbWAH/06+LuHoDuUWvg/jcTAWe2401uuP3vW3w252T1xJdMi mHbcv48aC1AsKnMhbwkAOIACau33DCzeO5lEhWqayq10XqHQ+vFg2Fp43HocdfGKda0= X-Gm-Gg: AR+sD11k7YZY+Ucd3x/gxbsNL0VGLbpGXyKossmuwCICtcYvyD5FKRPhIk405UiQAu5 z0VD2mlpye3J1m/0u+FHiEM01nibSFhjiS2Kv1dQgFZib/j99mqbHX/fhjbREDX0unYywIgozbL qmYn4Su92sJdzHiBQxcrhEx4WY7FJFj8yv2gGp+wdziJH5n/wYpj5leC1tT9nj0KUv+e4E30GtP FzIEA8snVeCsMdQUzmjuNW2+72lWIEaCHrrOp1zKOviy9r6TPmxYC6CEEsbDEpfn1APtMIgA8kb Al0zn3g6ms7bFrCmK5FYN4aJgJQUdWGxkg0t4cf3aqZy30Xu5bd+V3QX7QAONrrDOedtW/kcPEk zMajkrNRutrVu6vgBirJ+LOlfhwDo5oJgf3g4H1c6Eas6WJHhIN//k4U+lRjlPumeRf53Ep0/QD LZlYXR7gE= X-Received: by 2002:a05:6000:4610:b0:47f:45d1:7b74 with SMTP id ffacd0b85a97d-47f8dca6c5fmr1936289f8f.58.1784788197625; Wed, 22 Jul 2026 23:29:57 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47f85c631fdsm12158433f8f.28.2026.07.22.23.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 23:29:56 -0700 (PDT) Date: Thu, 23 Jul 2026 08:29:56 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Manaf Meethalavalappu Pallikunhi Cc: Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Stephen Boyd , Bjorn Andersson , Konrad Dybcio , Daniel Lezcano , linux-hwmon@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mfd@lists.linux.dev, Gaurav Kohli Subject: Re: [PATCH v2 02/10] hwmon: Add Qualcomm PMIC BCL driver Message-ID: References: <20260722-qcom-bcl-hwmon-v2-0-febe2805e17b@oss.qualcomm.com> <20260722-qcom-bcl-hwmon-v2-2-febe2805e17b@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bd4y6yvvhvmkobl7" Content-Disposition: inline In-Reply-To: <20260722-qcom-bcl-hwmon-v2-2-febe2805e17b@oss.qualcomm.com> --bd4y6yvvhvmkobl7 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v2 02/10] hwmon: Add Qualcomm PMIC BCL driver MIME-Version: 1.0 Hello, On Wed, Jul 22, 2026 at 12:00:07AM +0530, Manaf Meethalavalappu Pallikunhi wrote: > +#include > [...] > +#include already provides struct of_device_id and will go away soon. So please drop the #include for . Best regards Uwe --bd4y6yvvhvmkobl7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmphtOEACgkQj4D7WH0S /k49VQgAmlAG8muz6EMH5FjdlhV/oZNvJu7GJoTRj34gMkDOuJxv5eCjOKSjMT9q kpJaIlEzPWBL87vMjKLjzIjbrmzbQCecyRprvXwQD5kRTcHIp6VehlZoXVoEkmVE IHwyi4SD0DiEa8zfppjbcvaSy86X42bsR+zf9bWW2I4myMzanvPMEROEE7LvPJFG /ZN2+kVdAdHJCs7RVEPmaOmb75+Dr+jnkVFQC0VV1f+KSVkZEpvd+fcQXcv3GaHu n2iHyLpWtJeYA1uhY688Q+tPOwMAEwcHbgmIDoyYtC+DYHrlH9/4gqEsHVWD7vQO fmjQGvUa3+No+e0dojq+d8Go1+fZWg== =P/xV -----END PGP SIGNATURE----- --bd4y6yvvhvmkobl7--