From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
Andrew Morton <akpm@linux-foundation.org>,
"Darrick J. Wong" <djwong@us.ibm.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: hwmon: add binding for adi,adt7470
Date: Thu, 23 Jul 2026 08:10:07 +0200 [thread overview]
Message-ID: <amGvR3VwfDN1Gi0Q@monoceros> (raw)
In-Reply-To: <CAJq09z6qQnKXgBnQKCey4u47hsJTjpYXPDvDZj76sXHZuj2emQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
Hi Luiz,
On Mon, Jul 20, 2026 at 11:12:49PM -0300, Luiz Angelo Daros de Luca wrote:
> Initially, I modeled the driver purely as a cooling device. However,
> following Sashiko-dev's suggestion in a previous review, I converted
> it to expose PWM channels so it could be used with the generic pwm-fan
> driver (which indeed makes the code cleaner). My primary experience is
> with DSA switches, so hwmon is a new area for me.
I like the driver exposing a generic PWM. For me it's quite in line with
the "Linux spirit" to do things with devices that are possible even if
that doesn't figure in the vendor's scheme.
> Whatever you and the DT maintainers agree on, I will gladly adjust for v3.
But my opinion doesn't count ... :-)
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-07-23 6:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 20:59 [PATCH v2 0/6] hwmon: (adt7470) Add thermal zone and PWM provider support Luiz Angelo Daros de Luca
2026-07-17 20:59 ` [PATCH v2 1/6] dt-bindings: hwmon: add binding for adi,adt7470 Luiz Angelo Daros de Luca
2026-07-17 21:04 ` sashiko-bot
2026-07-20 3:23 ` Luiz Angelo Daros de Luca
2026-07-20 6:47 ` Krzysztof Kozlowski
2026-07-20 14:24 ` Guenter Roeck
2026-07-21 2:12 ` Luiz Angelo Daros de Luca
2026-07-23 6:10 ` Uwe Kleine-König [this message]
2026-07-20 10:03 ` Uwe Kleine-König
2026-07-23 2:48 ` Luiz Angelo Daros de Luca
2026-07-23 6:05 ` Uwe Kleine-König
2026-07-17 20:59 ` [PATCH v2 2/6] hwmon: (adt7470) Fix fans stuck in manual mode on I2C errors Luiz Angelo Daros de Luca
2026-07-17 21:10 ` sashiko-bot
2026-07-17 20:59 ` [PATCH v2 3/6] hwmon: (adt7470) Fix busy-loop and I2C flooding in update thread Luiz Angelo Daros de Luca
2026-07-17 21:12 ` sashiko-bot
2026-07-17 20:59 ` [PATCH v2 4/6] hwmon: (adt7470) Add ADT7470_PWM_MAX macro Luiz Angelo Daros de Luca
2026-07-17 21:05 ` sashiko-bot
2026-07-17 20:59 ` [PATCH v2 5/6] hwmon: (adt7470) Register as a PWM provider Luiz Angelo Daros de Luca
2026-07-17 21:17 ` sashiko-bot
2026-07-19 14:49 ` Guenter Roeck
2026-07-19 17:04 ` Uwe Kleine-König
2026-07-17 20:59 ` [PATCH v2 6/6] hwmon: (adt7470) Add thermal zone sensor support Luiz Angelo Daros de Luca
2026-07-17 21:09 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amGvR3VwfDN1Gi0Q@monoceros \
--to=ukleinek@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djwong@us.ibm.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luizluca@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox