From: Shawn Guo <shengchao.guo@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: remoteproc: qcom,sm8550-pas: Document Nord ADSP
Date: Fri, 24 Jul 2026 16:12:48 +0800 [thread overview]
Message-ID: <amMegF3qxIUEeXEZ@QCOM-aGQu4IUr3Y> (raw)
In-Reply-To: <20260721-sepia-kraken-of-authority-a5ff1b@quoll>
On Tue, Jul 21, 2026 at 10:54:07AM +0200, Krzysztof Kozlowski wrote:
> On Thu, Jul 09, 2026 at 04:51:48PM +0800, Shawn Guo wrote:
> > Document ADSP (HPASS DSP) for Nord SoC.
> >
> > The Nord ADSP use CX and MX power domains, so add a new conditional
> > block to enforce the correct power-domain-names for it.
>
> Then this does not fit here and you should rather find other binding
> which fits your device. The entire point of splitting the binding was to
> avoid 20-if-then-cases because they are unmaintainable.
Thank you for the comment, Krzysztof!
There doesn't seem to be an existing binding fits Nord perfectly. I
think I would propose to add a new binding qcom,nord-pas.yaml to cover
both adsp and cdsp. Will send a new version for review.
Shawn
next prev parent reply other threads:[~2026-07-24 8:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 8:51 [PATCH 0/3] Add ADSP support for Nord SoC Shawn Guo
2026-07-09 8:51 ` [PATCH 1/3] dt-bindings: soc: qcom,aoss-qmp: Document Nord AOSS side channel Shawn Guo
2026-07-21 8:31 ` Krzysztof Kozlowski
2026-07-09 8:51 ` [PATCH 2/3] dt-bindings: remoteproc: qcom,sm8550-pas: Document Nord ADSP Shawn Guo
2026-07-21 8:54 ` Krzysztof Kozlowski
2026-07-24 8:12 ` Shawn Guo [this message]
2026-07-24 8:24 ` Krzysztof Kozlowski
2026-07-09 8:51 ` [PATCH 3/3] remoteproc: qcom: pas: Add Nord ADSP support Shawn Guo
2026-07-09 9:00 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amMegF3qxIUEeXEZ@QCOM-aGQu4IUr3Y \
--to=shengchao.guo@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox