From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: Philippe Baetens <philippebaetens@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Jai Luthra <jai.luthra@ideasonboard.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v10 1/2] dt-bindings: media: i2c: Add mira220 image sensor
Date: Tue, 28 Jul 2026 17:43:54 +0300 [thread overview]
Message-ID: <amjAKhNIt0_UIZqt@kekkonen.localdomain> (raw)
In-Reply-To: <20260727-mira220-v10-1-8825794e6095@ideasonboard.com>
Hi Jacopo,
On Mon, Jul 27, 2026 at 10:56:30AM +0200, Jacopo Mondi wrote:
> From: Philippe Baetens <philippebaetens@gmail.com>
>
> Add bindings for the AMSOSRAM Mira220 image sensor.
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Philippe Baetens <philippebaetens@gmail.com>
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
>
> ---
> v8->v9:
> - Make link-frequencies required
>
> v7->v8:
> - Add Conor's tag
>
> v5->v6:
> - sashiko: use 'unevaluatedProperties: false' at the top level to allow
> properties from video-interface-devices.yaml
>
> v4->v5:
> - reflow description to 80 cols and drop |-
> - remove 'reg' description
> - remove 'anyOf' from data-lanes
> - remove 'link-frequencies' from required properties
> - remove 'clock-continuous: true' as we already allow all properties
> from 'video-interfaces.yaml'
> - remove tabs from the example
> ---
> .../devicetree/bindings/media/i2c/ams,mira220.yaml | 102 +++++++++++++++++++++
> MAINTAINERS | 7 ++
> 2 files changed, 109 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml b/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
> new file mode 100644
> index 000000000000..fa6fec0072ef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
> @@ -0,0 +1,102 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/ams,mira220.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AMS 2.2 MP NIR enhanced global shutter image sensor
> +
> +maintainers:
> + - Philippe Baetens <philippebaetens@gmail.com>
> +
> +description:
> + 2.2 MP NIR enhanced global shutter image sensor designed for 2D and 3D
> + consumer and industrial machine vision applications. Due to its small size,
> + configurability and high sensitivity both in visual as well as NIR, the
> + Mira220 is well suited for 2D and 3D applications, which include Active Stereo
> + Vision, Structured Light Vision for Robotics and AR/VR.
> +
> +allOf:
> + - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> + compatible:
> + const: ams,mira220
I haven't read the discussion on all versions of the set, but this way
you'll have to power on the device to fully recognise it, further meaning
the possible hardwired privacy LED will be lit at that time. Maybe it's not
an issue. You'd likely have it with a CCS sensor, too...
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2026-07-28 14:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 8:56 [PATCH v10 0/2] media: i2c: Add driver for Mira220 Jacopo Mondi
2026-07-27 8:56 ` [PATCH v10 1/2] dt-bindings: media: i2c: Add mira220 image sensor Jacopo Mondi
2026-07-28 14:43 ` Sakari Ailus [this message]
2026-07-31 14:31 ` Jacopo Mondi
2026-07-27 8:56 ` [PATCH v10 2/2] media: i2c: Add driver for AMS-OSRAM Mira220 Jacopo Mondi
2026-07-27 9:10 ` sashiko-bot
2026-07-28 14:45 ` Sakari Ailus
2026-07-31 14:15 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amjAKhNIt0_UIZqt@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jai.luthra@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=philippebaetens@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox