From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: David Heidelberg <david@ixit.cz>
Cc: Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
David Rhodes <drhodes@opensource.cirrus.com>,
Conor Dooley <conor+dt@kernel.org>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com,
devicetree@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH RFC 5/6] ASoC: cs35l36: Implement set_tdm_slot to program RX slot register
Date: Thu, 30 Jul 2026 09:53:56 +0100 [thread overview]
Message-ID: <amsRJMxoCPMZXQfI@opensource.cirrus.com> (raw)
In-Reply-To: <1348b108-1034-4ab0-a967-972a9456151d@ixit.cz>
On Wed, Jul 29, 2026 at 08:22:42PM +0200, David Heidelberg wrote:
> On 06/07/2026 10:52, Charles Keepax wrote:
> > On Sun, Jul 05, 2026 at 10:06:55PM +0200, David Heidelberg via B4 Relay wrote:
> > > + if (rx_mask)
> > > + regmap_update_bits(cs35l36->regmap, CS35L36_ASP_RX1_SLOT,
> > > + CS35L36_ASP_RX1_SLOT_MASK,
> > > + ffs(rx_mask) - 1);
> >
> > It is more normal for the masks to specify the slot number rather
> > than the bit number, it would probably be nicer to stick with
> > that convention even though it will complicate the code here a
> > little.
>
> Thank you, is there one of the cs*l* series which implements in similar
> fashion as requested?
sound/soc/codecs/arizona.c, sound/soc/codecs/cs42l43.c or
sound/soc/codecs/cs35l56.c all implement set_tdm, those are
probably reasonable inspiration.
Thanks,
Charles
next prev parent reply other threads:[~2026-07-30 8:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-05 20:06 [PATCH RFC 0/6] Speakers for Pixel 3 / 3 XL David Heidelberg via B4 Relay
2026-07-05 20:06 ` [PATCH RFC 1/6] ASoC: qcom: sdm845: Demystify TDM masks a bit David Heidelberg via B4 Relay
2026-07-05 20:19 ` sashiko-bot
2026-07-05 20:06 ` [PATCH RFC 2/6] ASoC: qcom: sdm845: use DSP_A format for TDM codec DAIs David Heidelberg via B4 Relay
2026-07-05 20:18 ` sashiko-bot
2026-07-06 8:33 ` Konrad Dybcio
2026-07-06 9:15 ` David Heidelberg
2026-07-06 9:40 ` Konrad Dybcio
2026-07-05 20:06 ` [PATCH RFC 3/6] ASoC: qcom: sdm845: Use per-speaker RX masks for TDM slot assignment David Heidelberg via B4 Relay
2026-07-05 20:25 ` sashiko-bot
2026-07-05 20:06 ` [PATCH RFC 4/6] ASoC: qcom: sdm845: Set codec dai and component sysclk during startup David Heidelberg via B4 Relay
2026-07-05 20:19 ` sashiko-bot
2026-07-05 20:06 ` [PATCH RFC 5/6] ASoC: cs35l36: Implement set_tdm_slot to program RX slot register David Heidelberg via B4 Relay
2026-07-05 20:20 ` sashiko-bot
2026-07-06 8:52 ` Charles Keepax
2026-07-29 18:22 ` David Heidelberg
2026-07-30 8:53 ` Charles Keepax [this message]
2026-07-30 9:18 ` Richard Fitzgerald
2026-07-06 9:11 ` Konrad Dybcio
2026-07-05 20:06 ` [PATCH RFC 6/6] arm64: dts: qcom: sdm845-google: Add basic audio support David Heidelberg via B4 Relay
2026-07-05 20:18 ` sashiko-bot
2026-07-06 9:14 ` Konrad Dybcio
2026-07-06 9:17 ` David Heidelberg
2026-07-06 11:59 ` Konrad Dybcio
2026-07-06 12:00 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amsRJMxoCPMZXQfI@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=drhodes@opensource.cirrus.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=phone-devel@vger.kernel.org \
--cc=rf@opensource.cirrus.com \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox