From: Wim de With <wf@dewith.io>
To: Daniel Thompson <danielt@kernel.org>
Cc: Lee Jones <lee@kernel.org>, Jingoo Han <jingoohan1@gmail.com>,
Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Helge Deller <deller@gmx.de>,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: backlight: Add Orient Chip OCP8178
Date: Thu, 13 Aug 2026 11:59:44 +0200 [thread overview]
Message-ID: <an2VkN3446Ndxn9c@dewith.io> (raw)
In-Reply-To: <an2RgGwu2YaglM7H@aspen.lan>
On Thu, Aug 13, 2026 at 10:42:24AM +0100, Daniel Thompson wrote:
> On Wed, Aug 12, 2026 at 09:21:46PM +0200, Wim de With wrote:
> > + enable-gpios:
> > + description: GPIO to use to enable/disable and dim the backlight.
> > + maxItems: 1
>
> Is this really an "enable" GPIO? The enable-gpio(s) for most backlights
> is the HWEN pin rather than something used for protocol. Maybe
> onewire-gpios or control-gpios?
I agree, and there is prior art in the kernel for ctrl-gpios, so I'll go
with that.
Regards,
Wim
next prev parent reply other threads:[~2026-08-13 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 19:21 [PATCH v2 0/2] backlight: Add support for Orient Chip OCP8178 Wim de With
2026-08-12 19:21 ` [PATCH v2 1/2] dt-bindings: backlight: Add " Wim de With
2026-08-12 19:28 ` sashiko-bot
2026-08-13 9:42 ` Daniel Thompson
2026-08-13 9:59 ` Wim de With [this message]
2026-08-12 19:21 ` [PATCH v2 2/2] backlight: Add support for " Wim de With
2026-08-12 19:34 ` sashiko-bot
2026-08-13 10:45 ` Wim de With
2026-08-13 9:42 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an2VkN3446Ndxn9c@dewith.io \
--to=wf@dewith.io \
--cc=conor+dt@kernel.org \
--cc=danielt@kernel.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox