From: Bjorn Andersson <andersson@kernel.org>
To: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Raj Aryan <raryan@qti.qualcomm.com>
Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Document RTC client properties
Date: Thu, 6 Aug 2026 19:02:44 -0500 [thread overview]
Message-ID: <anUemwQJgHJP7iOS@baldur> (raw)
In-Reply-To: <20260807-rtc-glink-cleanup-v1-1-7801e4d69c4f@oss.qualcomm.com>
On Fri, Aug 07, 2026 at 02:26:30AM +0530, Kamal Wadhwa wrote:
> The pmic_glink driver can now register an RTC auxiliary device on
> glymur, whose PMIC exposes an RTC over GLINK (see rtc-glink driver).
> Document the allow-set-time flag it consumes from the parent
> pmic-glink node.
The driver functionality has no relevance to the DeviceTree binding.
The binding defines the contract between the DeviceTree (DTB) and the
implementation, such that the implementation knows what to expect from
and how to interpret the DTB.
>
> Assisted-by: Claude:claude-sonnet-5
> Signed-off-by: Raj Aryan <raryan@qti.qualcomm.com>
> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
As with the driver, the author/s-o-b chain is wrong.
> ---
> Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> index 16ad4f5698fc..38db1ff473c0 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> @@ -79,6 +79,11 @@ properties:
> - const: charge_limit_end
> - const: charge_limit_delta
>
> + allow-set-time:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + Indicates that the setting of RTC time is allowed by the host CPU.
What property of the hardware/firmware that this describes would cause
you to set or not set this?
Also, what would the expected outcome be if I declare that my Hamoa
hardware has pmic-glink with allow-set-time?
Regards,
Bjorn
> +
> patternProperties:
> '^connector@\d$':
> $ref: /schemas/connector/usb-connector.yaml#
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-08-07 0:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 20:56 [PATCH 0/2] rtc: Add Qualcomm PMIC RTC-GLINK support for Glymur Kamal Wadhwa
2026-08-06 20:56 ` [PATCH 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Document RTC client properties Kamal Wadhwa
2026-08-06 21:02 ` sashiko-bot
2026-08-07 0:02 ` Bjorn Andersson [this message]
2026-08-06 20:56 ` [PATCH 2/2] rtc: qcom: rtc-glink: Add PMIC GLINK RTC driver and extend pmic_glink Kamal Wadhwa
2026-08-06 21:09 ` sashiko-bot
2026-08-06 23:53 ` Bjorn Andersson
2026-08-07 20:58 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anUemwQJgHJP7iOS@baldur \
--to=andersson@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kamal.wadhwa@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=raryan@qti.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox