From: "Arthur Crépin Leblond" <arthur@marmottus.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH net-next v4 1/3] dt-bindings: net: wiznet,w5100: convert to DT schema
Date: Tue, 11 Aug 2026 16:14:57 +0200 [thread overview]
Message-ID: <ansuYaT2GAMAA0hF@pc-du-fromage> (raw)
In-Reply-To: <5812d452-5dbe-436b-ae6e-af062a873f7a@app.fastmail.com>
On Tue, Aug 11, 2026 at 02:57:40PM +0200, Arnd Bergmann wrote:
>On Tue, Aug 11, 2026, at 14:34, Arthur Crépin Leblond wrote:
>> + ethernet@0 {
>> + compatible = "wiznet,w5500";
>> + reg = <0>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <ð1_pins>;
>> + interrupt-parent = <&gpio>;
>> + interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
>
>I think this needs to be IRQ_TYPE_EDGE_BOTH instead of IRQ_TYPE_EDGE_FALLING
>to make sense.
>
> Arnd
This interrupt is for the main one which is active low, we don't need
to catch the rising one.
Only The link interrupt needs to be both edges.
Arthur
next prev parent reply other threads:[~2026-08-11 14:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 12:34 [PATCH net-next v4 0/3] w5100: restore GPIO-based link detection Arthur Crépin Leblond
2026-08-11 12:34 ` [PATCH net-next v4 1/3] dt-bindings: net: wiznet,w5100: convert to DT schema Arthur Crépin Leblond
2026-08-11 12:57 ` Arnd Bergmann
2026-08-11 14:14 ` Arthur Crépin Leblond [this message]
2026-08-11 14:25 ` Arnd Bergmann
2026-08-11 12:34 ` [PATCH net-next v4 2/3] dt-bindings: net: wiznet,w5100: add link status interrupt Arthur Crépin Leblond
2026-08-11 13:33 ` Rob Herring (Arm)
2026-08-11 13:36 ` Krzysztof Kozlowski
2026-08-11 14:02 ` Arthur Crépin Leblond
2026-08-11 12:34 ` [PATCH net-next v4 3/3] w5100: detect carrier state using link status bit and optional interrupt Arthur Crépin Leblond
2026-08-11 13:01 ` [PATCH net-next v4 0/3] w5100: restore GPIO-based link detection Arnd Bergmann
2026-08-11 13:37 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ansuYaT2GAMAA0hF@pc-du-fromage \
--to=arthur@marmottus.net \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox