Re: [PATCH] arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard configuration EEPROM layout DTOs

[Frank Li <Frank.li@oss.nxp.com>]

On Tue, Aug 25, 2026 at 02:02:50PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The device tree node for the software compatibility field is misspelled as 'software-comatibility' (missing 'p'). As these fields are exposed via the sysfs nvmem interface, this typo will become a permanent userspace ABI.
> --
>
> --- Patch [1]: [PATCH] arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard configuration EEPROM layout DTOs ---
> commit a29716c722da3485b2bb345e32239ee52540c286
> Author: Marek Vasut <marex@nabladev.com>
>
> arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard configuration EEPROM layout DTOs
>
> Add DT overlays which describe configuration EEPROM VHIP section,
> for VHIP section v1.0.0.0, v1.1.0.0, v2.0.0.0, used on ifm VHIP4
> EvalBoard. With the DTO applied, the VHIP section fields become
> accessible via the sysfs nvmem interface.
>
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-1000.dtso b/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-1000.dtso
> > new file mode 100644
> > index 0000000000000..41641c54164f1
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-1000.dtso
>
> [ ... ]
>
> > +		product-type@64 {
> > +			reg = <0x64 0x20>;
> > +		};
> > +
> > +		software-comatibility@84 {
>
> [Severity: Medium]
> Is there a typo in this node name? It appears to be missing a 'p' and should
> perhaps be software-compatibility@84.

Please fix it

Frank

>
> > +			reg = <0x84 0x4>;
> > +		};
> > +
> > +		manufacturing-date@88 {
>
> [ ... ]
>
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-1100.dtso b/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-1100.dtso
> > new file mode 100644
> > index 0000000000000..5f89b1af6874d
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-1100.dtso
>
> [ ... ]
>
> > +		product-type@84 {
> > +			reg = <0x84 0x20>;
> > +		};
> > +
> > +		software-comatibility@a4 {
>
> [Severity: Medium]
> Does this node name also contain the same missing 'p' typo?
>
> > +			reg = <0xa4 0x4>;
> > +		};
> > +
> > +		manufacturing-date@a8 {
>
> [ ... ]
>
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-2000.dtso b/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-2000.dtso
> > new file mode 100644
> > index 0000000000000..01599bf46ac18
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn-vhip4-overlay-eeprom-2000.dtso
>
> [ ... ]
>
> > +		product-type@90 {
> > +			reg = <0x90 0x20>;
> > +		};
> > +
> > +		software-comatibility@b0 {
>
> [Severity: Medium]
> Could this node name be corrected to software-compatibility as well?
>
> > +			reg = <0xb0 0x4>;
> > +		};
> > +
> > +		manufacturing-date@b4 {
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20260825135754.864501-1-marex@nabladev.com?part=1