From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32338353A6F for ; Mon, 7 Sep 2026 08:28:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788769697; cv=none; b=gEPUGX2d2M6uzSb+BGb9sogIJSklLlnzUg8Pdo5+xqHuELDvCH6WVV9RPat2lJISwgaHRbfT5W5GcM+62382OJODgBrHjurpl2QrNGiT3p53UEPEGqp9QJMZ7eU1AVW1qmuQaF3qI1N4vWqW3cL8i9lodepCYhQO5uFdT+b7LBQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788769697; c=relaxed/simple; bh=huFQlCxAjSKXrnS0hP6aD8uVwJipgrrBkGwCQxbjol4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OZFULfuYkkJkKUwxEBdTaOPwaHep6qUMV8B1rASnH7iUkDPAGjSiBcKknqgXPqtoc3rmt2ElhMKK7XO2O4Hk5iPx7+M+UR2Y6pAl7hbp025jliMBKH2cTkVo7K2AI0SzIwzYloZUL+BqjMxj/6p8GzFHZ5493j6Af6KLJwukICU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=CcvQogcS; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="CcvQogcS" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-49b9320423cso36664905e9.0 for ; Mon, 07 Sep 2026 01:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1788769694; x=1789374494; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BVJJYbJWb+cBOU7Yim8Nj+TVsMe2MibjBMdU5cRQacc=; b=CcvQogcSuce4cB8ZNWEOQq8LN0+Eo9KvYFLDuY3fM6GB+zdGMQP7s2oos2ZX+OipLd aLqHzmN4PmyuZzLBemu4DSB/sZrs1DYfZUtI2O7Hi8WyutkhUvSeDKaSv4Yr7lPZ+IjH LpqlD5KmElqnTum7ohW7NvjuBwahiMxJwMh2BNFKsUcZqsoCX4A9B9A6/x2Ko+fnBDBh +hgfUBg2yTQ5uORA7nrB+tuIhCt6cflGnjgzUy34h8PZS8M3o5bEElHjk82ea6n8Q3et nRin8ay2//iZAzZV+0/FfTgx9Z2YPJCI/66KhhBUyx/DVaPGYxenEsQgogQ5MafBEUOT OE5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788769694; x=1789374494; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BVJJYbJWb+cBOU7Yim8Nj+TVsMe2MibjBMdU5cRQacc=; b=VKxdQQ0z63YbyHL9cy78a14tnjvEdxdMfsyW1hnn5g3Crr1d1ts1NnAhyLByQI8MiQ 7r8WsqC7CzGRxtJkUstGmsg91QElSYNdOvJOLR4QWjtfZqtv8d7hC10Wf3Zu9GW1W+4U w03Z0/crttFhFybL2aE6D1gxrSMohaMYwCQLd2aIjr/eG/ywsbkqkBKZQf4zYU9lw3hp jqooU5nfurd4PwR/hocnb8SaRyZYpkOuwJbMh+7/tvQdmVmr5Npy0ANoCQddWIQLZXa1 fyB5lwvoaFnM4BxEX5rL9VUBUt2DyAKNQrCWbE9n+sjN9uLHDCuMwIfAX4i+QFY20+Zd MlaQ== X-Forwarded-Encrypted: i=1; AKwUvBy39GOCsJbbYcozHUqnPu14wUC4jrKqiA1gN2jB7ri6fjQBuZtBzoi4fHKSo+phJZc/NXDzgE3VPYuC@vger.kernel.org X-Gm-Message-State: AFuF++l8IDTRQmJKfhn/Hy8SvvqIRLjGKrHEEEBU1kURztQiNvE1vZ/s COi/pOOkOO+fEfYPxBAE1tF+9KTTN9f92ebyUg+On/FRwBgSxHotLiPtJPZrOHfFA3g= X-Gm-Gg: AYBFou0EprjJ3kcvHgQ0/J3WuqbEF765lVJKCZ4ZdClX4ueHfYrxO3YmTFuk/YO6nCF UhBwO7L4ZOTlBjiOsRnKaGeWizOBealn4BHKrvAntzApD9xTTx3NwC0R4jDMr2kPDUrSG/tGtui BktlxsQynHce7Fvhe/LeWTTfULFMhY96x2m49jQ4bCRRii9G87cXvts2IVuNCKlWASIS2D9IJMJ l2Vb+nj3GM/Tjp04cQZX4UenGeodUMq/sJ+U3MjpnlCGhYTla+z2C3XwakL6wjzn3mysFJbRTWp ithEkQrzJ1uQKFZaYUDJdjl5u4VZKIfzqwWv1DewtlVI0kjR9gUgXKjmdWxWF0QWSdYcJKJGwIb K220TFDLTGmSVWNW2dUJFnirc6pJE6TSSBhQO2HTpCemW6IPF3C2pgZZ+yRAOFlg8n3VR43cm6y WSgzCrb1p145NV1MK67Z/7VBWPTYZSD65I0spaiqoYdXUR1N3EdD2CmyEdEJZq5YMHadN4K4d4u lgvcOTuscsI3+kcUETWLJkWLNMR4ZGHvYV9WCdi2ucOtJr4yBh+ilQA7Hb2wQ== X-Received: by 2002:a05:600c:8b09:b0:499:b65e:49c9 with SMTP id 5b1f17b1804b1-49cf823f57fmr438673975e9.10.1788769694367; Mon, 07 Sep 2026 01:28:14 -0700 (PDT) Received: from localhost (p200300f65f19a9047ae53bb37ada872a.dip0.t-ipconnect.de. [2003:f6:5f19:a904:7ae5:3bb3:7ada:872a]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-49cfd3f8192sm253287995e9.3.2026.09.07.01.28.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 01:28:13 -0700 (PDT) Date: Mon, 7 Sep 2026 10:28:12 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: John Erasmus Mari Geronimo Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org, sre@kernel.org Subject: Re: [PATCH v2 2/2] power: supply: add LT8491 battery charger driver Message-ID: References: <20250110080235.54808-1-johnerasmusmari.geronimo@analog.com> <9c260e1c2056c69be1cb7a05abcd10ba657c1548.1788432152.git.johnerasmusmari.geronimo@analog.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="izx6zmq4uugxibrs" Content-Disposition: inline In-Reply-To: <9c260e1c2056c69be1cb7a05abcd10ba657c1548.1788432152.git.johnerasmusmari.geronimo@analog.com> --izx6zmq4uugxibrs Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v2 2/2] power: supply: add LT8491 battery charger driver MIME-Version: 1.0 Hello, On Thu, Sep 03, 2026 at 06:46:37PM +0800, John Erasmus Mari Geronimo wrote: > +#include > +#include Please don't use . You can rely on to provide i2c_device_id and of_device_id. Alternatively include and . > +static const struct i2c_device_id lt8491_id[] = { > + { "lt8491", 0 }, > + { } > +}; Please make this: static const struct i2c_device_id lt8491_id[] = { { .name = "lt8491" }, { } }; (i.e. use a named initializer and don't explicitly initialize the unused driver_data member.) Best regards Uwe --izx6zmq4uugxibrs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqedZkACgkQj4D7WH0S /k6enQf/cfgn/jeJDnqupXKlB2/USBaFWX79CznAQSEq9RD8PL62FsicUxR2+EYM YxFRNZ6DQgf/g393cau19HSDv00Z0cL636rC6Dv3LlWCLCYNq7Jplo4SI5+whggQ HwgKNmEJh//evjDVWxGJSGTB1PyukASl4x4PmfHQ7P2YU6TKez4yfp8/iQq5sJwM mBX4qJgmb0Rm7VPBFkt2zWyE/CG72+k5IhRVbGlsQX22XXEisJQkz9xahR36JKbG jMzjw1loaw6AqTayi6V6fXvYzSBNisqYPgi72x9tqS51QIMINZ50AbTnWudfcoGx krCzDhwGe3oLzrceCDGLiBcmTu8pJg== =anpd -----END PGP SIGNATURE----- --izx6zmq4uugxibrs--