From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01E9438399A for ; Tue, 1 Sep 2026 00:54:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788224057; cv=none; b=X26aPHTCPWIFprGKNbSkx3ElYnGpqUXd86PPyUqMrPAhxC49qH+73J0D5ZPZJ51t8Fv6fMitoM59Y7HTFPeCfaHbFpXAfiDa3tFsy9j3eFIo+V7Ca211T6zs69D0U9dsx++W04fcjI+iC0U1kJSLsx3OHuZCcE71VeOJydDxcDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788224057; c=relaxed/simple; bh=ojofH+DBwrtlXR+jm3f6lWSyg4U83Fo+JcCGuWLCSkc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VE/i61zSwqFrabaR9X7MNXhU0RzcFoXN/itoyxmhd2zuwSE5bpJne/ZEJiZ6HomtOuC3NwgypQRttr6rqPUKB4O2ssXmUl0VrhaD6CJDDh2Bso6fHdnIPyxm2kCvrUjeioQdBCZS5WXHdoXn+4v+nQCQMWOqBzzbhyhE6UK2uDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EsZNk7so; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EsZNk7so" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-836c4474028so4206177b3.0 for ; Mon, 31 Aug 2026 17:54:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788224054; x=1788828854; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=43wKJtwDjfuuZoIKBALy8jyb5Xwlew7WFV5ccmoVfUQ=; b=EsZNk7soLhdCGZ4CZtaIX3DnOSurTB9fTEE0Sp6Qbh2wpA9+GgUc6JwFs9dKsGugGA cfUdV1CHAq9m/7xCdCuy+x7dzrfZbG3hNXVSTX9S0rygP5ZeP62xI6wB0yBT1bFZmoqs Z6sO7BkfBz2XHLzGoFRYVA48JbggOyS05I45enoEMfpcWNist3TrTJAbbV+qLh2eTD/u AgFPWoFZeRL7pFVwbn1+MsCyXA9m6lg08etWFvDIdreDI6SCXjMkH/fCf+Kst2qfHI5N pmStC2FRdQTx/2ywFbgHfU2w8/xtsW6XSDiq38ZtLZJBSMnW4difyqER78198dflkfAw LWYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788224054; x=1788828854; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=43wKJtwDjfuuZoIKBALy8jyb5Xwlew7WFV5ccmoVfUQ=; b=CTgilu3ogKWE1SfvPO/Op1hjmblWgWGR4DmjiofGAVmfrPr2AjYvyyK2nu8VYTtTcT O2kVzNpCrJhgpYhz/Beg1TGeBv5whjiSCLoUTNbxWrjXytNoiEOoc5FqdYTfXEz+tirf rrj0+mZP6xCy2JaovnWhlpbElrSiljQI70aappnuAymJYZNT5xRf8aGsE8PK1/E2LtZf ThXRzct+WkppBdIpmIvaqe2a5dPwnHAG53t+R6Pn7cAr0dTzQymTvBUuN7vlv1ExAhCU uR1o8NS5Aqg098V4d8wjUDmgh9dg5mMMx1K0QBkjj7mC6EUFLoqeUDXQAc12TlLzJpDn /jLA== X-Forwarded-Encrypted: i=1; AKwUvBwuYXV4dS64j5wQydwvYWh6xSc74ANBhdX8ljMx99eTf/VZ5bqBv6WUC0xfhMWesc6jxXGRABUl1Nl1@vger.kernel.org X-Gm-Message-State: AFuF++nF6jEv3LGaI8ymxrAwhWtuIW0x6/lfJfGSVQNABhlzFz2dOoe/ wlP+TnqvV1Sq7jA891xsY5dbD0Svs+pLUk2B1srS8uXhfjPOpYlPZE9D X-Gm-Gg: AYBFou21urxOOGZOEO9wGslEMjYvKsnHxzCs5zhA3mdGodiaTr4zFsaOWQqMi7Zz8A8 6y+UkbD4NwgPjEm2J6S56ba/BWBJOE5sWrgIi3gSvrsm59zcMpn3cOYiqX8qh4LXV4R85wwDVAH kdh2asMKY7bNEIwBa8AC3Wps0gSHWpRmtO4mFFMemZ+LIk4Cx47NZgrh8P716pbKkd7EQZxeRwX MdDAri29aqsNU6BvX/vMon8zG98WhAsN9ovTtz66MB5aOx5oy996Osqe45zp1QSQSo7pElfDNpJ RlO+fje8JMR5FV27H9HyhXS/uyaSuSpwfXhlABMxFm50Zy9CM0PEjlkeLfLJgYTJHDsNZdGqfpM ++qhlZc3aldT1QSMlHWFtceM1i/xAdIXu06wphw7GQhqW70ImNV8WRlEMIvJniogKidtln95b8y eUaH2Xw5T/Ug73r3YBV2SOhhB2VOeo5x9WBii+IknxeOilJV0n2FGE32amvezCWEYrM3od X-Received: by 2002:a05:690e:4543:10b0:66e:7307:4666 with SMTP id 956f58d0204a3-66e73075b91mr3196325d50.10.1788224048960; Mon, 31 Aug 2026 17:54:08 -0700 (PDT) Received: from localhost ([2804:30c:94d:7300:da0f:c2c1:1aa6:43da]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-66e4ed163bcsm7241718d50.16.2026.08.31.17.54.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2026 17:54:07 -0700 (PDT) Date: Mon, 31 Aug 2026 21:54:58 -0300 From: Marcelo Schmitt To: Luca Weiss Cc: Jorijn van der Graaf , Jonathan Cameron , linux-iio@vger.kernel.org, David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, Kees Cook , "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] iio: light: stk3310: support the Sensortek STK36C61 Message-ID: References: <20260826175409.326131-1-jorijnvdgraaf@catcrafts.net> <20260826175409.326131-6-jorijnvdgraaf@catcrafts.net> <20260828154705.11962-1-jorijnvdgraaf@catcrafts.net> <20260830201950.63838-1-jorijnvdgraaf@catcrafts.net> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 08/31, Luca Weiss wrote: > Hi Jorijn, > > On Sun Aug 30, 2026 at 10:19 PM CEST, Jorijn van der Graaf wrote: > > On Sun, Aug 30, 2026 at 12:03:29PM -0300, Marcelo Schmitt wrote: > >> Having a closer look at the data sheet I found for STK36C61, I noticed registers > >> 0x13 and 0x14 are not listed. Does the newer part has ambient light sensing > >> besides the clear channel? > > > > That looks to be the "STK36C61-A Preliminary Datasheet v0.9" hosted by > > LCSC [1], which I hadn't found before, so the cover letter's "There is > > no public datasheet" is wrong. It documents the -A variant, however, > > and gives PDT_ID as 0x93, while the part in the Fairphone 6 reports > > 0x95. It does agree with the device on the colour-engine layout: RGBC The data sheets I was comparing were from https://datasheet4u.com/datasheets/Sensortek/STK3310/836592 https://jlcpcb.com/partdetail/SENSORTEK-STK36C61A/C49230205 which were the first links that appeared to me on an online search. > > Just to chime in, the datasheet I have access to (STK36C61-A Preliminary > Datasheet Version - 0.9.2) there are a few changes compared with the one > from LCSC but nothing too interesting: > > * On the overview page LED current 228.75 changed to 218.75 mA > * ALSCTRL1 register (0x02) has different values for BIT[6:4] > (17.92 -> 143.36; 8.96 -> 35.84; 4.48 -> 8.96) > * PDT_ID is indeed 0x95 - maybe the previous version just had wrong > copy-pasted info? > Hmm, I was initially thinking about the added STK3310_PROXIMITY_CHANNEL for stk36c61. If STK36C61 has ambient light sensing (similar to STK3310 light sensing read from registers 0x13 and 0x14) then it makes sense to have that channel for STK36C61 too. Otherwise, that specific ambient light channel shouldn't belong to stk36c61_channels. I didn't find a data sheet for the part with PDT_ID 0x95, though, that sounds like another thing to tidy up. Update the naming from STK36C61 to STK36C61A. So, if STK36C61 (without the A) is ever added, there will be no naming conflict. Unless STK36C61 is never going to be released (which doesn't seem to be the case cause I can find a data sheet for that). With best regards, Marcelo