Devicetree
 help / color / mirror / Atom feed
From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: Luca Weiss <luca.weiss@fairphone.com>
Cc: "Jorijn van der Graaf" <jorijnvdgraaf@catcrafts.net>,
	"Jonathan Cameron" <jic23@kernel.org>,
	linux-iio@vger.kernel.org,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, "Kees Cook" <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] iio: light: stk3310: support the Sensortek STK36C61
Date: Mon, 31 Aug 2026 22:28:50 -0300	[thread overview]
Message-ID: <apYqUv_uuqZlhtOh@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <apYiYnlM-agfG9he@debian-BULLSEYE-live-builder-AMD64>

On 08/31, Marcelo Schmitt wrote:
> On 08/31, Luca Weiss wrote:
> > Hi Jorijn,
> > 
> > On Sun Aug 30, 2026 at 10:19 PM CEST, Jorijn van der Graaf wrote:
> > > On Sun, Aug 30, 2026 at 12:03:29PM -0300, Marcelo Schmitt wrote:
> > >> Having a closer look at the data sheet I found for STK36C61, I noticed registers
> > >> 0x13 and 0x14 are not listed. Does the newer part has ambient light sensing
> > >> besides the clear channel?
> > >
> > > That looks to be the "STK36C61-A Preliminary Datasheet v0.9" hosted by
> > > LCSC [1], which I hadn't found before, so the cover letter's "There is
> > > no public datasheet" is wrong. It documents the -A variant, however,
> > > and gives PDT_ID as 0x93, while the part in the Fairphone 6 reports
> > > 0x95. It does agree with the device on the colour-engine layout: RGBC
> 
> The data sheets I was comparing were from
> https://datasheet4u.com/datasheets/Sensortek/STK3310/836592
> https://jlcpcb.com/partdetail/SENSORTEK-STK36C61A/C49230205
> which were the first links that appeared to me on an online search.
> 
> > 
> > Just to chime in, the datasheet I have access to (STK36C61-A Preliminary
> > Datasheet Version - 0.9.2) there are a few changes compared with the one
> > from LCSC but nothing too interesting:
> > 
> > * On the overview page LED current 228.75 changed to 218.75 mA
> > * ALSCTRL1 register (0x02) has different values for BIT[6:4]
> >   (17.92 -> 143.36; 8.96 -> 35.84; 4.48 -> 8.96)
> > * PDT_ID is indeed 0x95 - maybe the previous version just had wrong
> >   copy-pasted info?
> > 
> 
> Hmm, I was initially thinking about the added STK3310_PROXIMITY_CHANNEL for
> stk36c61. If STK36C61 has ambient light sensing (similar to STK3310 light
> sensing read from registers 0x13 and 0x14) then it makes sense to have that
> channel for STK36C61 too. Otherwise, that specific ambient light channel
> shouldn't belong to stk36c61_channels.
> 
> I didn't find a data sheet for the part with PDT_ID 0x95, though, that sounds
> like another thing to tidy up. Update the naming from STK36C61 to STK36C61A.
> So, if STK36C61 (without the A) is ever added, there will be no naming conflict.
> Unless STK36C61 is never going to be released (which doesn't seem to be the case
> cause I can find a data sheet for that).

Never mind, I completely missed the point of it having a preliminary datasheet.
It might be sensible to try to estimate if the final version will keep the same
name and PDT_ID.

  reply	other threads:[~2026-09-01  1:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 17:54 [PATCH v2 0/5] iio: light: stk3310: per-chip match data and STK36C61 support Jorijn van der Graaf
2026-08-26 17:54 ` [PATCH v2 1/5] iio: light: stk3310: lower-case the i2c device ID names Jorijn van der Graaf
2026-08-26 18:03   ` sashiko-bot
2026-08-27  6:45   ` Andy Shevchenko
2026-08-26 17:54 ` [PATCH v2 2/5] dt-bindings: iio: light: stk33xx: document the Sensortek STK36C61 Jorijn van der Graaf
2026-08-26 17:54 ` [PATCH v2 3/5] iio: light: stk3310: move the data registers into the channel address Jorijn van der Graaf
2026-08-26 18:07   ` sashiko-bot
2026-08-27  6:47   ` Andy Shevchenko
2026-08-26 17:54 ` [PATCH v2 4/5] iio: light: stk3310: add per-chip match data Jorijn van der Graaf
2026-08-26 18:03   ` sashiko-bot
2026-08-27  7:47   ` Andy Shevchenko
2026-08-26 17:54 ` [PATCH v2 5/5] iio: light: stk3310: support the Sensortek STK36C61 Jorijn van der Graaf
2026-08-27  7:53   ` Andy Shevchenko
2026-08-28  4:18   ` Marcelo Schmitt
2026-08-28 15:47     ` Jorijn van der Graaf
2026-08-30 15:03       ` Marcelo Schmitt
2026-08-30 20:19         ` Jorijn van der Graaf
2026-08-31  7:53           ` Luca Weiss
2026-09-01  0:54             ` Marcelo Schmitt
2026-09-01  1:28               ` Marcelo Schmitt [this message]
2026-09-01  2:55                 ` Jorijn van der Graaf
2026-09-01  6:57                   ` Luca Weiss
2026-08-30 23:48 ` [PATCH v2 0/5] iio: light: stk3310: per-chip match data and STK36C61 support Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apYqUv_uuqZlhtOh@debian-BULLSEYE-live-builder-AMD64 \
    --to=marcelo.schmitt1@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gustavoars@kernel.org \
    --cc=jic23@kernel.org \
    --cc=jorijnvdgraaf@catcrafts.net \
    --cc=kees@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox