Re: [PATCH v4 03/10] iio: adc: add the ti-ads1262 driver

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Sun, Sep 06, 2026 at 05:15:50PM -0300, Kurt Borja wrote:
> On Fri Aug 28, 2026 at 5:09 AM -03, Andy Shevchenko wrote:
> > On Fri, Aug 28, 2026 at 01:38:18AM -0500, Kurt Borja wrote:

...

> >> +	reset_gpiod = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
> >> +	if (IS_ERR(reset_gpiod))
> >> +		return dev_err_probe(dev, PTR_ERR(reset_gpiod),
> >> +				     "failed to get reset GPIO\n");
> >
> > But can you use reset-gpio driver instead?
> 
> I'll look into reset-gpio. But I think it may not be worth to use it
> because it may not change much here. We'd still need to manage these
> timing constraints and we also only use this GPIO in the probe anyway.

It changes a lot. The reset framework takes care of shared signals
(which might be the case in the future, if not already) on some platforms.
You won't need to do much in such a case. With manual handling it will
require a lot of code duplication.

...

> >> +	st->clk_rate = rate ? rate : ADS1262_NOMINAL_CLK_RATE;
> >
> > Can use Elvis.
> 
> I'm not really sure what you meant here.

https://en.wikipedia.org/wiki/Elvis_operator

-- 
With Best Regards,
Andy Shevchenko