devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vincent Jardin <vjardin@free.fr>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: hwmon: ti,tmp401: add #thermal-sensor-cells
Date: Wed, 2 Sep 2026 16:11:25 +0200	[thread overview]
Message-ID: <apgujdI08Pp2BC4b@L30177.local> (raw)
In-Reply-To: <20260828-weightless-ferret-of-pluck-ef2baa@quoll>

Hi Krzysztof,

Le 28/08/26 12:02, Krzysztof Kozlowski a écrit :
> On Tue, Aug 25, 2026 at 12:13:18AM +0200, Vincent Jardin wrote:
> > The property is missing, so a board that uses it with a thermal zone fails
> > with dtbs_check:
> > 
> >   tmp411@4c (ti,tmp411): '#thermal-sensor-cells' does not match any of the
> 
> Cannot find such node.
> 
> How can I reproduce this warning? If it is non-reproducible, then it is
> not a valid reason for a change and instead driver implementing thermal
> sensor would be the proper reason.

Hmm, you are right, it is not reproducible from the main tree, I was confused
with my ongoing developments: no in-tree DTS uses a tmp401-family
chip as a thermal sensor, so dtbs_check has nothing to complain about.

The warning came from a DTS that does, which is exactly the usage the
driver now supports and you are right that the driver, not the
warning, is the proper reason.

Since commit
  a3b61ba2558e ("hwmon: (tmp401) register with thermal subsystem"),
in v7.3-rc1, tmp401 sets HWMON_C_REGISTER_TZ

-> the hwmon core calls devm_thermal_of_zone_register() for every
temperature channel.

My goal is to unify/follow the other ones such as national,lm90.yaml,
ti,tmp102.yaml or adi,adt7470.yaml already pair "const: 1" with drivers
that set HWMON_C_REGISTER_TZ.

v3 justifies the change from the driver and drops the dtbs_check excerpt.
The diff is unchanged.

Thanks for catching it and sorry for the confusions,
  Vincent

      parent reply	other threads:[~2026-09-02 14:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 22:13 [PATCH v2] dt-bindings: hwmon: ti,tmp401: add #thermal-sensor-cells Vincent Jardin via B4 Relay
2026-08-24 22:17 ` sashiko-bot
2026-08-28 10:02 ` Krzysztof Kozlowski
2026-09-02 13:28   ` Guenter Roeck
2026-09-02 14:26     ` Vincent Jardin
2026-09-02 18:04       ` Guenter Roeck
2026-09-02 14:11   ` Vincent Jardin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apgujdI08Pp2BC4b@L30177.local \
    --to=vjardin@free.fr \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).