From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB0FB412BF3 for ; Thu, 3 Sep 2026 07:40:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788421249; cv=none; b=QE2ujAJOrSAqj5C9OHJ8K50EudYGX7iDudHXgR/1Nx+xr78jx6bEhKu2zjt1ISB2AUINcYcrODOyGBVckTXyYY+SEvQ9f1+mWFYhoTumt/EU3kNjnSgJrfucAhhcTAFJ4owcM92e+MUkpRKsA/oltx3xL9D5NuPUD8YIcQboh6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788421249; c=relaxed/simple; bh=x7pyjtGGh7b/U1VS+WdJUyI+xIeBGiIvfSijCbKsJ4o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uZCMzv0ta8D/Z+HodxVbUCjhn9Wuz3G0E9JNBYlcHppop34ECLmVt/zO5Tym0WQ6/BZL1Ywmx2MkhLECbdHnM5kE1DY34FphkxgCWDSGzJvPuYW4g+R+lWL3YDQUbPLhFGhCkOSjOrwNOQrPn6limd9H/VCByYOmd5b833e9iJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cnQu6kb0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gSYRt9xu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cnQu6kb0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gSYRt9xu" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6835lhaR3176926 for ; Thu, 3 Sep 2026 07:40:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=kWXB0DBFbeY92quzkukTnKj6 Wdb6ho2r4wmQ7PLthC8=; b=cnQu6kb0RChSmq4lxnIYpcqvuhBYGdBZeNIsbKJD 8oJMC0Q4vj+QYxMxf0y79c6+hhIRHd4EESq76nAr92E8wYIrQUFr9li3/HKoQ7ff /NfYJ/goqcQJHondnYMduSg2H9ogh6xDU6h2M1SZ81vDu/+g6Rj+fofMV4GQl818 e2Pv0naBPSh3DNWjjUrGJ3MeCUdmAG2L4dF0f0q9ohhokzrJs8byw352rbdtYuDY OztvUBo8rDG66Jo1gzhgILKDvBguoMB/KX7nIuhuYqyKcMFq0Duaepn+n1ygALnI VpxqywGxLlQxN4v9x0bdW8SxF0bokbivs+bfzsdV3ScO3Q== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gemj4v3s6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 07:40:46 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38e7ff7b375so2911546a91.1 for ; Thu, 03 Sep 2026 00:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788421246; x=1789026046; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=kWXB0DBFbeY92quzkukTnKj6Wdb6ho2r4wmQ7PLthC8=; b=gSYRt9xugPYhvAXLjHpAqTxKlJjj8K3Qn1scphZmWAQ59eMVQ7AjYm/ckgJljf1Y9B 52LrekK+BbUvgofhSIwSnELkshqyDbLeznSUFakCaoJt1NhtZHjEEG2Wsf6lDI2nP4q+ 2mV6djsgbWrvnN+ipgqklleLfIZhpUl9z7APHPryJbGbrugLEGAMBTNhWnUw/DSEZSl4 WWg/AN2pT8JtL7cjv6Fc/EK6XLoN1Wv8o4Df14jG8PC2bYzeNdto/CdbBWb0beh91lgU yk8TWWoHnOeCWiTb4Bb99LQvqWikrz5XwkDMn/Td/7DPMyqDA+XG6TO+MSH9fZeHduBk 9hjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788421246; x=1789026046; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kWXB0DBFbeY92quzkukTnKj6Wdb6ho2r4wmQ7PLthC8=; b=BJtxzO3C9OziDtksNzN238zpauD1LJUlcKZk4WcSlJVN+xGuPSSKcEs+NgErfpUVLa ZmCdsh90kEJY/AWgomxQl4QxEbrnlU56vyw52c/94r3jltnZ5TGdKQYicpHN2iA3kyjm EXLlnqem+hQpIcvinixiwupRflR3B1DwmULJdt5jOoGw0bYfNKCd1hjdjq01OpyXjVmO 6CLdobPutup/6yZo+0xtui2adWjJv5CVLx5S+e31bOX6NejfV/xk378KtzvtiEr132We fUFyFtsfu22W3HCD9o7a95BPLpZytMFxlKVL5yh6pPm0NbAB9eLOVgt/j2zorOriPIuY w97Q== X-Forwarded-Encrypted: i=1; AKwUvBwrPS7FyDtM+IFJaWEpXa7/ms++WfK86vW4PJjWQ/2sUChvfKO5/9/39wO5X1FCuj266Vo7Hda98z6g@vger.kernel.org X-Gm-Message-State: AFuF++kJsKFZt0mrJUk7YVA0jmzOPnjW72dqcznAMJQTFKfxaFbjhlGh d8/RyZvrvQ8DmyWDG7H6j2O+ZQ1m84xLV1/xoBAjcVxSmw2LpHkus78ULMiS4wzNReV18XrfEjI P/y4KiiRcMC4Lwts/ivMFC9Z2B61Fcl3UpEsxP7/Ik3WHfaJKgaFgJ+JUI9KEMa2i X-Gm-Gg: AYBFou1/MUw32WOi47tKCy/Inv5cRuosKWveL6Y/ioEdWc64Gd4SbJg85y8XGpTrSrQ qAmPPJJ3DcbQmwxiDwJwv6RojVstLhaJM/58cSbYrDpwVksOIcqqCQ4n+7CTGFvUfh8OZUbqZHY dimJDHqrFqedJUlJK7HYcdwCzmwtiqX/CW1DA/qP/xo9cIb+4Yo5HZIBWlF3HMQU2LN/+IgUsq7 TiBnETWvZn+vKTRSObbslCwmJ/XqVOCS48oaV6+NmjZAfuX3nVGa+fdlbBZwoy1M4uTB88RcmfM 43aVTgxC9+JpibHuzvQitp/uWAXR3Lw9MSCFRuLrNBAuiKDQdj8hnTUBABAC67UcZ0mvhPbao9h JXbGv03Pw81V3JIJAaUetccCpjmtzDN2ekaEhv1mZ7Qk= X-Received: by 2002:a17:90b:3c04:b0:398:d6e8:f84e with SMTP id 98e67ed59e1d1-39aedf5571fmr17400854a91.9.1788421245536; Thu, 03 Sep 2026 00:40:45 -0700 (PDT) X-Received: by 2002:a17:90b:3c04:b0:398:d6e8:f84e with SMTP id 98e67ed59e1d1-39aedf5571fmr17400808a91.9.1788421245045; Thu, 03 Sep 2026 00:40:45 -0700 (PDT) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-143199692a6sm6767023c88.12.2026.09.03.00.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 00:40:44 -0700 (PDT) Date: Thu, 3 Sep 2026 15:40:37 +0800 From: Shawn Guo To: Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Dhruvin Rajpura , Anandu Krishnan E , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 6/6] arm64: dts: qcom: Add initial support for Nord Ride Embedded board Message-ID: References: <20260831032103.341633-1-shengchao.guo@oss.qualcomm.com> <20260831032103.341633-7-shengchao.guo@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDA2NyBTYWx0ZWRfX+EwqRpOCvIbp B+69LJEOJGdKhukWYK1WvNOHVYUc3jvfAgUG4EYgJlw0Ibnso7Vz20cfgj0SyyL0PLLb4BUFq0q 4xqQDE13pQpZ/fR1ZmeQrSuO0e+oj7862Sj4cVbAIqQMDz5s8VCGdthX19BfjTI8t8QJkGneu0t viGl182UwKeS5dJm+/kK/YfxuCvwy/dhzYeGkyLj/2wrO0rggjXYFwXWKHqhN/HbHN0KdPvoOjC bElGcZZYUkVZQ8d0KJxrqSzT28N3iOLQMC5+OXfkOsHGOJe1H6jhvNf+saLRBiJ6XjEHhayO5Zj PXg85nrjbnLXFWZOywaE37XGvi6oVcLLGvcrcIF7qXfnjGxqYBUNAFLOsnu0Bx5F88Z2N7IsiC8 /YSzmnReI7YXd8IIOU/mLv/il6fVrXr2ZFZ77rKjhfQAF9KVVW9fSiompJ8HltKYM0ZjiYg8M8c qtBDfB/pmvXZkzL9b9Q== X-Proofpoint-ORIG-GUID: 8p-tgiOVaTpO4cLc8x4qiocqtxfSXsXx X-Authority-Analysis: v=2.4 cv=MdhcfZ/f c=1 sm=1 tr=0 ts=6a99247e cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ibTjlFuhWse9lpBZ6vsA:9 a=CjuIK1q_8ugA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: 8p-tgiOVaTpO4cLc8x4qiocqtxfSXsXx X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDA2NyBTYWx0ZWRfXytycFraGXiVy 1CrKigqAYxIBMoD3eJzSAp5+LhxoA3F6dLfNnJsMqP8nM//gvqrp4GWivYPYVwiBaVIqhvkdq9H HyQ8Bs4nHheFIm1GIAm3OhD11/9CKHw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_02,2026-09-02_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030067 On Wed, Sep 02, 2026 at 04:00:52PM +0200, Konrad Dybcio wrote: > On 8/31/26 5:21 AM, Shawn Guo wrote: > > From: Bartosz Golaszewski > > > > Add the initial device tree for the Nord Ride Embedded board, the > > non-SCMI variant of the SA8797P automotive Ride board. > > [...] > > > + vreg_l7a_1p2: ldo7 { > > + regulator-name = "vreg_l7a_1p2"; > > + regulator-min-microvolt = <1200000>; > > + regulator-max-microvolt = <1200000>; > > + regulator-initial-mode = ; > > + regulator-always-on; > > + regulator-boot-on; > > You mark _a lot_ of regulators as always- and boot-on - is that > necessary for all of them? Ah, sorry! You already had the comment on nord-rrd.dts. I forgot to apply it on nord-ride-embedded.dts. Will fix. > > [...] > > > + /* PMIC H - "UPMH" satellite (CD90-73961-1) - SID 0x7, Bus E0 */ > > leftover? Since we agreed that a bit comment is useful [1], I guess you are saying the "satellite (CD90-73961-1)" part shouldn't be there. I will get the comment aligned with nord-rrd.dts. > > [...] > > > + /* PMIC I - "UPMI" satellite (CD90-73961-1) - SID 0x8, Bus E0 */ > > likewise, a couple times > > [...] > > > + vreg_s2i_gfx0: smps2 { > > + regulator-name = "vreg_s2i_gfx0"; > > + regulator-min-microvolt = <300000>; > > + regulator-max-microvolt = <1200000>; > > + regulator-initial-mode = ; > > + regulator-allow-set-load; > > + regulator-allowed-modes = > + RPMH_REGULATOR_MODE_HPM>; > > + }; > > + > > + vreg_s7i_mm: smps7 { > > + regulator-name = "vreg_s7i_mm"; > > + regulator-min-microvolt = <300000>; > > + regulator-max-microvolt = <1200000>; > > + regulator-initial-mode = ; > > + regulator-allow-set-load; > > + regulator-allowed-modes = > + RPMH_REGULATOR_MODE_HPM>; > > Are these actually exposed as regulators and not RPMHPDs? Great catch, Konrad! These are rpmhpd-managed resources and shouldn't be here. I will drop them. Shawn [1] https://lore.kernel.org/all/b522c9b4-4944-4fb2-94f9-bd2553690901@oss.qualcomm.com/