From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8215C4BD0E3; Thu, 3 Sep 2026 14:54:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788447283; cv=none; b=SBxfguEiPK4lpySzxAUlEjHGQTnh3LEq+27F930UHaWGaMvvetFXfh2Aents+QZw6h5LydB5sgbVLD6SRD0lmyeR0sRmwWHiD2xEMNWa+coo04/fbV9a9XLwEkmKrMIWb6/hZa0I3pzxtD3uapBuEEfQvRq5VoMhJa6as2y3WwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788447283; c=relaxed/simple; bh=lnPcEb6R2k2cn9mdx4M1XD7sEW7ehiJJvyYxQXElP/8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ry/p0ZPifUgWe7/w6i9IdVvQh6Xi4VvurAYSOsc6YNa2SBDWRnA/IP3QOKK2FbS+Q0l4GnKFGvmhJsvCPgag3d7f+1DX5zKF7tnwzfc+t8AtqJ5ECZXPLCL7PI4inZm0BKKvj2eClHocrWkUnOH3JTWMhWHX4KQTfaCYjw+WgV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P/fieQkU; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P/fieQkU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 810DE1F000E9; Thu, 3 Sep 2026 14:54:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788447280; bh=VuHMey/Yf4fc8xGmHLFRa2OsL+j/sTY/3VihKlmU5Ek=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=P/fieQkUzgyIvKF6UvtSps60A3DUv5ti/1dtRytlQbMTsClG7xJNSNLPItw/8qflZ nrRtONrafv3VVJNuhnuEe0WIv8FI16RsA7bhR266AJsbsgHjutdW1Y610+JuIcA9qt f1Ep5rzDQCbQ1wPoX0QAiCx3SPjEsl6NdpmujejI2pKqPF0LjrMpCDmpxDGHCcRgfU nX6496sDCbueA/fDpIrGeC9PK+59nGbCL4teUMWtEiUzUfAd3nsyLbEoLs7u9d7DqV JXgn5Y2YwRc/x+XCosbYev4Sl7iufOGJGR7EvGlORsYS8A3K5dfphO+xmRdi0AgpCM A/C0Ge/d/Bbag== Date: Thu, 3 Sep 2026 09:54:36 -0500 From: Bjorn Andersson To: Avaneesh Kumar Dwivedi Cc: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Monish Chunara , Rakesh Kota , Sayali Lokhande , Nirmesh Kumar Singh Subject: Re: [PATCH 2/3] arm64: dts: qcom: Add Talos Lyra EVK SoM platform Message-ID: References: <20260901-lyra_upstreaming-v1-0-e3a76dc9e21c@oss.qualcomm.com> <20260901-lyra_upstreaming-v1-2-e3a76dc9e21c@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260901-lyra_upstreaming-v1-2-e3a76dc9e21c@oss.qualcomm.com> On Tue, Sep 01, 2026 at 07:14:02PM +0530, Avaneesh Kumar Dwivedi wrote: Please make subject prefix arm64: dts: qcom: talos: ... so that it groups nicely in a git log --oneline. > Introduce the device tree for the QCS615-based Talos Lyra EVK SoM. > Lyra EVK SoM a compact compute module integrating the QCS615 SoC, > PMIC, and essential connectivity, designed to mount on carrier boards. > > The initial SoM device tree includes basic support for: > > - CPU and memory > - PMIC and board-level regulators > - UFS and SD card storage > - QUPv3 (I2C/SPI/UART) instances > - ADSP/CDSP remoteprocs > - GPU > > Co-developed-by: Monish Chunara > Signed-off-by: Monish Chunara > Co-developed-by: Rakesh Kota > Signed-off-by: Rakesh Kota > Co-developed-by: Sayali Lokhande > Signed-off-by: Sayali Lokhande > Signed-off-by: Nirmesh Kumar Singh > Signed-off-by: Avaneesh Kumar Dwivedi This s-o-b chain says Monish, Rakesh, Sayali, and Nirmesh first wrote the patch, but the way you sent it claims you authored it. Retain Nirmesh as author or fix the chain. > --- > arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi | 282 +++++++++++++++++++++++ > 1 file changed, 282 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi > new file mode 100644 > index 000000000000..8c19f050d5b3 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/talos-lyra-evk-som.dtsi > @@ -0,0 +1,282 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +#include > +#include > +#include "talos.dtsi" > +#include "pm8150.dtsi" > +/ { > + aliases { > + mmc0 = &sdhc_1; > + mmc1 = &sdhc_2; > + serial0 = &uart0; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + clocks { > + sleep_clk: sleep-clk { > + compatible = "fixed-clock"; > + clock-frequency = <32764>; > + #clock-cells = <0>; > + }; > + > + xo_board_clk: xo-board-clk { > + compatible = "fixed-clock"; > + clock-frequency = <38400000>; > + #clock-cells = <0>; > + }; > + }; > +}; > + > +&apps_rsc { > + regulators-0 { > + compatible = "qcom,pm8150-rpmh-regulators"; > + qcom,pmic-id = "a"; > + > + vreg_s3a: smps3 { I don't see anything referencing s3a, s5a, and s6a, are you sure that rpmh doesn't handle the SMPSs for us automatically? Do we actually want to vote for s4a from Linux? > + regulator-name = "vreg_s3a"; > + regulator-min-microvolt = <600000>; > + regulator-max-microvolt = <650000>; > + regulator-initial-mode = ; > + }; > + > + vreg_s4a: smps4 { > + regulator-name = "vreg_s4a"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1829000>; > + regulator-initial-mode = ; > + }; > + > + vreg_s5a: smps5 { > + regulator-name = "vreg_s5a"; > + regulator-min-microvolt = <1896000>; > + regulator-max-microvolt = <2040000>; > + regulator-initial-mode = ; > + }; > + > + vreg_s6a: smps6 { > + regulator-name = "vreg_s6a"; > + regulator-min-microvolt = <1304000>; > + regulator-max-microvolt = <1404000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l1a: ldo1 { > + regulator-name = "vreg_l1a"; > + regulator-min-microvolt = <488000>; > + regulator-max-microvolt = <852000>; That's a wide span, narrow it to what the consumers need. > + regulator-initial-mode = ; Are you sure you want to go LPM here? > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l2a: ldo2 { > + regulator-name = "vreg_l2a"; > + regulator-min-microvolt = <1650000>; > + regulator-max-microvolt = <3100000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l3a: ldo3 { > + regulator-name = "vreg_l3a"; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1248000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l5a: ldo5 { > + regulator-name = "vreg_l5a"; > + regulator-min-microvolt = <875000>; > + regulator-max-microvolt = <975000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l7a: ldo7 { > + regulator-name = "vreg_l7a"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1900000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l8a: ldo8 { > + regulator-name = "vreg_l8a"; > + regulator-min-microvolt = <1150000>; > + regulator-max-microvolt = <1350000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l10a: ldo10 { > + regulator-name = "vreg_l10a"; > + regulator-min-microvolt = <2950000>; > + regulator-max-microvolt = <3312000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l11a: ldo11 { > + regulator-name = "vreg_l11a"; > + regulator-min-microvolt = <1232000>; > + regulator-max-microvolt = <1260000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l12a: ldo12 { > + regulator-name = "vreg_l12a"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1890000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l13a: ldo13 { > + regulator-name = "vreg_l13a"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3230000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l15a: ldo15 { > + regulator-name = "vreg_l15a"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1904000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l16a: ldo16 { > + regulator-name = "vreg_l16a"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3312000>; > + regulator-initial-mode = ; > + regulator-allow-set-load; > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; > + }; > + > + vreg_l17a: ldo17 { > + regulator-name = "vreg_l17a"; > + regulator-min-microvolt = <2950000>; > + regulator-max-microvolt = <3312000>; > + regulator-initial-mode = ; > + }; > + }; > +}; > + > +&gcc { > + clocks = <&rpmhcc RPMH_CXO_CLK>, > + <&rpmhcc RPMH_CXO_CLK_A>, > + <&sleep_clk>; I'm failing to see how that differs from that talos.dtsi already says. That said, this list is incomplete and needs to be corrected - can be done separately. > +}; > + > +&gpu { > + status = "okay"; > +}; > + > +&gpu_zap_shader { > + firmware-name = "qcom/qcs615/a612_zap.mbn"; > +}; > + > +&qupv3_id_0 { > + status = "okay"; > +}; > + > +&qupv3_id_1 { > + status = "okay"; > +}; > + > +&remoteproc_adsp { > + firmware-name = "qcom/qcs615/adsp.mbn"; > + > + status = "okay"; > +}; > + > +&remoteproc_cdsp { > + firmware-name = "qcom/qcs615/cdsp.mbn"; > + > + status = "okay"; > +}; > + > +&rpmhcc { > + clocks = <&xo_board_clk>; That's what it says in talos.dtsi already. I must be misunderstanding something? > +}; > + > +&sdhc_1 { > + pinctrl-0 = <&sdc1_state_on>; > + pinctrl-1 = <&sdc1_state_off>; > + pinctrl-names = "default", "sleep"; > + bus-width = <8>; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; > + mmc-hs400-1_8v; > + mmc-hs400-enhanced-strobe; > + vmmc-supply = <&vreg_l17a>; > + vqmmc-supply = <&vreg_s4a>; > + non-removable; > + no-sd; > + no-sdio; > + > + status = "okay"; > +}; > + > +&sdhc_2 { > + pinctrl-0 = <&sdc2_state_on>; > + pinctrl-1 = <&sdc2_state_off>; > + pinctrl-names = "default", "sleep"; > + bus-width = <4>; > + cd-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>; > + vmmc-supply = <&vreg_l10a>; > + vqmmc-supply = <&vreg_s4a>; > + > + status = "okay"; > +}; > + > +&uart0 { > + status = "okay"; > +}; > + > +&ufs_mem_hc { > + reset-gpios = <&tlmm 123 GPIO_ACTIVE_LOW>; > + vcc-supply = <&vreg_l17a>; > + vcc-max-microamp = <600000>; > + vccq2-supply = <&vreg_s4a>; > + vccq2-max-microamp = <600000>; > + > + status = "okay"; > +}; > + > +&ufs_mem_phy { > + vdda-phy-supply = <&vreg_l5a>; > + vdda-pll-supply = <&vreg_l12a>; > + > + status = "okay"; > +}; > > -- > 2.34.1 >