Devicetree
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Sudeep Holla <sudeep.holla@kernel.org>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Salman Nabi <salman.nabi@arm.com>,
	Vedashree Vidwans <vvidwans@nvidia.com>,
	Trilok Soni <trilokkumar.soni@oss.qualcomm.com>,
	Nirmoy Das <nirmoyd@nvidia.com>,
	vsethi@nvidia.com, Varun Wadekar <vwadekar@nvidia.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/8] firmware: smccc: Add support for Live Firmware Activation (LFA)
Date: Fri, 18 Sep 2026 15:28:31 +0100	[thread overview]
Message-ID: <aq1KjzpIGuSpsPWx@J2N7QTR9R3> (raw)
In-Reply-To: <84f0862c-5333-4d53-b882-79b8e4c362ed@arm.com>

On Fri, Sep 18, 2026 at 11:13:19AM +0200, Andre Przywara wrote:
> On 7/17/26 11:03, Sudeep Holla wrote:
> > On Mon, Jul 06, 2026 at 03:44:42PM +0200, Andre Przywara wrote:

> > > +/* A list of known GUIDs, to be shown in the "name" sysfs file. */
> > > +static const struct fw_image_uuid {
> > > +	const char *name;
> > > +	const char *uuid;
> > > +} fw_images_uuids[] = {
> > > +	{
> > > +		.name = "TF-A BL31 runtime",
> > 
> > This doesn't make any sense to me. Why do you want kernel to assign
> > some random name base on UUID. Userspace is well place to deal with
> > UUID and give it any fancy name it wants.
> 
> Well, the whole interface is quite usable without any accompanying user
> space tools, so just from the shell, but then identifying  firmware
> components by their GUID becomes a major pain and leaves users completely
> clueless.
> And while we indeed will never be able to fully catch up with all the
> firmwares out there, especially not with vendor specific ones, there are
> some standard firmware components that I think warrant some name.
> TF-A BL31 above (and TF-RMM) are good examples: these GUID is already in the
> mainline repository, and since BL31 is also an LFA agent, it's quite likely
> we encounter this component. Even when vendors typically use downstream TF-A
> ports, those GUIDs would stay the same.
> So yes, it's more opportunistic than complete, but I think it would help to
> identify at least those well-known firmwares. Anything not named then would
> use the GUID, and can indeed be resolved by (a yet-to-be-written) userspace
> component.

Sudeep is right; this is not a good idea.

Remove the table and just expose the UUID of the image. Users can map
that to a string in userspace if they need/want, and that'll work
regardless of the vintage of kernel they're using.

I appreciate it might seem helpful to expose a name where we know it,
but overall it creates more problems, including (but not limited to)
compatibility issues, needless busywork to add entries (and arguments
about what is approriate to add), political issues when some project
naming changes, etc.

I am not going to Ack this with the name present, and I suspect neither
will Sudeep.

Mark.

  reply	other threads:[~2026-09-18 14:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 13:44 [PATCH v3 0/8] Arm Live Firmware Activation (LFA) support Andre Przywara
2026-07-06 13:44 ` [PATCH v3 1/8] dt-bindings: arm: Add Live Firmware Activation Andre Przywara
2026-07-16 20:51   ` Rob Herring (Arm)
2026-07-17  8:38   ` Sudeep Holla
2026-09-18  8:34     ` Andre Przywara
2026-07-06 13:44 ` [PATCH v3 2/8] firmware: smccc: Add support for Live Firmware Activation (LFA) Andre Przywara
2026-07-17  9:03   ` Sudeep Holla
2026-09-18  9:13     ` Andre Przywara
2026-09-18 14:28       ` Mark Rutland [this message]
2026-09-18 16:21         ` Andre Przywara
2026-07-06 13:44 ` [PATCH v3 3/8] firmware: smccc: lfa: Add timeout and trigger watchdog Andre Przywara
2026-07-06 13:44 ` [PATCH v3 4/8] firmware: smccc: lfa: Register ACPI notification Andre Przywara
2026-07-06 13:44 ` [PATCH v3 5/8] firmware: smccc: lfa: Add auto_activate sysfs file Andre Przywara
2026-07-06 13:44 ` [PATCH v3 6/8] firmware: smccc: lfa: Register DT interrupt Andre Przywara
2026-07-06 13:44 ` [PATCH v3 7/8] firmware: smccc: lfa: introduce SMC access lock Andre Przywara
2026-07-06 13:44 ` [PATCH v3 8/8] firmware: smccc: lfa: add sysfs ABI documentation Andre Przywara
2026-07-13 16:02 ` [PATCH v3 0/8] Arm Live Firmware Activation (LFA) support Michal Suchánek
2026-07-14 11:52   ` Michal Suchánek
2026-07-20 12:08     ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aq1KjzpIGuSpsPWx@J2N7QTR9R3 \
    --to=mark.rutland@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=nirmoyd@nvidia.com \
    --cc=robh@kernel.org \
    --cc=salman.nabi@arm.com \
    --cc=sudeep.holla@kernel.org \
    --cc=trilokkumar.soni@oss.qualcomm.com \
    --cc=vsethi@nvidia.com \
    --cc=vvidwans@nvidia.com \
    --cc=vwadekar@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox