From: Frank Li <Frank.li@oss.nxp.com>
To: Shubham Patil <shubhamsanjay.patil@amd.com>
Cc: alexandre.belloni@bootlin.com, Frank.Li@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, git@amd.com,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v4 1/3] dt-bindings: i3c: xlnx: Add IBI and hot-join capability properties
Date: Wed, 9 Sep 2026 10:34:34 -0500 [thread overview]
Message-ID: <aqF8igX1uynpo0xE@SMW015318> (raw)
In-Reply-To: <20260909071340.3649271-2-shubhamsanjay.patil@amd.com>
On Wed, Sep 09, 2026 at 12:43:38PM +0530, Shubham Patil wrote:
> In-Band Interrupt and Hot-Join are synthesis-time options of the AXI I3C
> IP. Describe them with two boolean properties.
>
> A Hot-Join request is acknowledged by the IBI machinery, so a hot-join
> capable design is always IBI capable as well. Both events are reported
> through the controller interrupt, which is therefore required whenever
> the capability is present.
>
> Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> Changes in V4:
> - Restore v2: keep xlnx,in-band-interrupt-capable and
> xlnx,hot-join-capable in the AMD binding. Do not move them into
> i3c.yaml.
Any reason roll back? I supposed not only xlnk need overwrite IBI and
HJ.
Frank
> - Added Acked-by: Conor Dooley tag.
>
> Changes in V3:
> - Move in-band-interrupt-capable and hot-join-capable into the common
> i3c.yaml schema and drop the xlnx, prefix.
> - Keep dependencies in the AMD binding.
> - Update the commit description accordingly.
> - Conor Dooley acked v2 with the xlnx,-prefixed properties in the AMD
> binding [1].
> That Acked-by is not carried here: the names lost the vendor prefix
> and the definitions moved to i3c.yaml after Frank Li's comment.
> [1]:https://lore.kernel.org/all/20260824-tightwad-impose-495476599087@spud/
>
> Changes in V2:
> - Rename the properties to "xlnx,in-band-interrupt-capable" and
> "xlnx,hot-join-capable", and expand their descriptions.
> - Express the interrupt requirement with dependencies: instead of an
> allOf/if-then clause.
> ---
> .../bindings/i3c/xlnx,axi-i3c-1.0.yaml | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml
> index 2caa245a8656..a04becc07374 100644
> --- a/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml
> +++ b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml
> @@ -32,11 +32,33 @@ properties:
> interrupts:
> maxItems: 1
>
> + xlnx,in-band-interrupt-capable:
> + type: boolean
> + description:
> + The IP is synthesized with In-Band Interrupt support. An In-Band
> + Interrupt lets a target signal the controller over the SDA and SCL
> + pair instead of a dedicated side-band interrupt line, by driving its
> + own dynamic address during bus arbitration. Such requests are
> + reported through the controller interrupt.
> +
> + xlnx,hot-join-capable:
> + type: boolean
> + description:
> + The IP is synthesized with Hot-Join support. Hot-Join lets a target
> + attached or powered up after the bus is already running announce
> + itself using the reserved Hot-Join address, so that the controller
> + can assign it a dynamic address. The request is acknowledged by the
> + same machinery as an In-Band Interrupt.
> +
> required:
> - compatible
> - reg
> - clocks
>
> +dependencies:
> + xlnx,hot-join-capable: ["xlnx,in-band-interrupt-capable"]
> + xlnx,in-band-interrupt-capable: [interrupts]
> +
> allOf:
> - $ref: i3c.yaml#
>
> @@ -54,5 +76,7 @@ examples:
> interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> #address-cells = <3>;
> #size-cells = <0>;
> + xlnx,in-band-interrupt-capable;
> + xlnx,hot-join-capable;
> };
> ...
> --
> 2.34.1
>
next prev parent reply other threads:[~2026-09-09 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 7:13 [PATCH v4 0/3] i3c: master: amd: Add IBI and hot-join support Shubham Patil
2026-09-09 7:13 ` [PATCH v4 1/3] dt-bindings: i3c: xlnx: Add IBI and hot-join capability properties Shubham Patil
2026-09-09 15:34 ` Frank Li [this message]
2026-09-09 7:13 ` [PATCH v4 2/3] i3c: master: amd: Add support for in-band interrupts Shubham Patil
2026-09-09 7:30 ` sashiko-bot
2026-09-09 7:13 ` [PATCH v4 3/3] i3c: master: amd: Add hot-join support Shubham Patil
2026-09-09 7:29 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqF8igX1uynpo0xE@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shubhamsanjay.patil@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox