Devicetree
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Andrei Stancovici <andrei.stancovici@analog.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Liam Beguin" <liambeguin@gmail.com>,
	linux@analog.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] iio: adc: ltc2497: add 2x conversion speed mode
Date: Wed, 9 Sep 2026 17:04:57 +0300	[thread overview]
Message-ID: <aqFniZF6CrYXnPjz@ashevche-desk.local> (raw)
In-Reply-To: <20260909082755.366269-4-andrei.stancovici@analog.com>

On Wed, Sep 09, 2026 at 11:27:52AM +0300, Andrei Stancovici wrote:
> The LTC2499 can convert at twice the output rate by disabling the offset
> auto-calibration.  Expose it through sampling_frequency and
> sampling_frequency_available on the voltage channels.  The part ignores
> the setting while measuring temperature, so the temperature channel does
> not carry the attribute.
> 
> The wait before a result is read is keyed on the conversion currently in
> flight, whose duration is fixed by the mode that was active when it
> started rather than by the mode just selected.  Otherwise the first read
> after a 1x -> 2x switch can reprogram the part while a 1x conversion is
> still running, which the part NACKs.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

...

> +LTC2497_DEFINE_CHANNELS(ltc2497core_channel_samp_freq,
> +			BIT(IIO_CHAN_INFO_SAMP_FREQ));

I believe having this on a single line is fine.

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-09-09 14:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09  8:27 [PATCH v4 0/3] iio: adc: add LTC2499 features support Andrei Stancovici
2026-09-09  8:27 ` [PATCH v4 1/3] dt-bindings: iio: adc: lltc,ltc2497: add LTC2499 to title Andrei Stancovici
2026-09-09  8:32   ` sashiko-bot
2026-09-09  8:27 ` [PATCH v4 2/3] iio: adc: ltc2497: add LTC2499 internal temperature channel Andrei Stancovici
2026-09-09  8:39   ` sashiko-bot
2026-09-09  8:27 ` [PATCH v4 3/3] iio: adc: ltc2497: add 2x conversion speed mode Andrei Stancovici
2026-09-09 14:04   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqFniZF6CrYXnPjz@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andrei.stancovici@analog.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=liambeguin@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox