From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1441A369D53 for ; Wed, 9 Sep 2026 17:16:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788974180; cv=none; b=o673NytQtEflyMcqhR0pb+44htAZfjdURhl7oI//CVLyBp2GDdAuiaNkBA88dP9K1gTnlr+U4PSlj0lrqDGoiSVnuT/COUBGfO/8imKXP1S1nct6O2Pkm8PH+yFjQOpQ7NWpMNQjArk+RAcTjEdZY5criUV7MMth0WOgcxGa/HU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788974180; c=relaxed/simple; bh=Edmagecg2PaIU44/PLytw5C3Adgmsos2KNBXGxIxnCw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b4Kg/rXOo8vSaSU2a8lsLyRbBexWdOszbE+QYN/FB1XULA5kE2y2G1Ewv0Mcr8lqx5Uwf4XmlDwIyIAgTM8gExOwLD98HV3+eZhIxvcJuirbDatuuI13ZsSWCLLhdyaTARj3LJVXFpjv+wmM9G1biV0lChRjWWCkw3ElLVZDuE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S72Welgf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P/AdubD5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S72Welgf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P/AdubD5" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 689H7JbJ3412821 for ; Wed, 9 Sep 2026 17:16:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=NrIsFfwedfuLeKvzU70rKNtT +rVIhJ0VJ39qxRIr5Qw=; b=S72WelgfsaZtrz5JllU+R+NP9CCOf2QzT2nd3iR6 wVf8+viNAnTjKlWgnXqmTJa+2+dOvFTecJ/+pvjjoef8HDQrzr3XkftTUg//NuT5 QE2XVeIArXON82vf2exGclBNbCWt9I8jtGwOKQAOesYkbRJCpqFlVqVHwI7H4oCF j8otjdTeVixQT3MxPzRBRHAmjqQWv5JN1oO39r2VPoj9ccSctHWm5xJVArVMH3Fr khQaXcy0sO/7WGuWyZPw68FrU0mR/J3a+mR8p31Wx0leOSVanwZrRR86HEdyCSXx MZhI/FigkoPuuT56ufkksltirKf6M6JnMHyWflixtksxOQ== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gk6xh1gx5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 09 Sep 2026 17:16:17 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-9829a8b46a7so117694241.0 for ; Wed, 09 Sep 2026 10:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788974176; x=1789578976; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=NrIsFfwedfuLeKvzU70rKNtT+rVIhJ0VJ39qxRIr5Qw=; b=P/AdubD5CbjshzP1yZdjveCGdDZ9/HPX72/8sINHn+fiYgnL4C3gaZItFWtxacGgkB nTZeoE/5r7Sfyzn/oSjoq/wPffaNI1LIcHPeEof8w5MJBlEnqYD7IuhWDCcjsDdBbBvh VlHAnKMFzMOm6kEAA9PMHuidnfyea3dlShc89akxCkILVCic1aOJU1B0yFUfhfiP9NSi GvkAZUkAXb/vGRpGseAEqZGSASF5R6gUqLvtMQP14K8Gj9BuFB29/DEYotP20X2EKvoC 2iPg49lJWLC7nkGEPl5N+PD8/eVZ6tQF2+0Ve1lKOd7hIegru6HUg3AQ2Ty8NIeiRLEa NN4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788974176; x=1789578976; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NrIsFfwedfuLeKvzU70rKNtT+rVIhJ0VJ39qxRIr5Qw=; b=ERHgA/b50GghOQp69xBDGfGJkWwuFCNJ0SD1JtM3s3PRzxzOzjhXcjfWToWUForb89 ZUjXgYle4HypfAb7Vv+GFUL5dzHGTLqXv02yPyMjbGGWw/CFT2hfLxccl1yfm3H2Vxlo 4JsMDHj/PBsTdxQK10ITU5Sg+v/5+EWO4xgvtDKiNua73QZWiDAgzkF2zY+3FaLyYVH4 LgZZmUTwLenFsQaFFg2dITZULnQzoMedsFvSOfN57KwXY44pBOL6xjp7KyWY0lxFntsY 0EFWccvSToQmK64ZhdlBOW95hsaqQoVkvpejDQWKzl3pUY2kRZg3NBh/dkcD/udCXpQN cFEQ== X-Forwarded-Encrypted: i=1; AKwUvBwaW2qkWjxwBJk4reXcN9RXrRibJ4OIK0K8UC3XRRKBHw9hfh2Sm9wZH+AncibYG0ngqAXd3IC2nCHm@vger.kernel.org X-Gm-Message-State: AFuF++kIm+9zN72BPP0vCaeQRb0exrfiqhicxXayIuxqTwOLmDrohO+Y HWc/QoK/SZXSke4N6lErENKg4KtE8lAHLeNNg01B1hOw42H38BzXNvgpeZbJc1mqtiJKUEAWy0D Q6BilZ4vnGT20DfJsrqNpwvWVjI/sRJ83kj+fN5M2teRPgSN6uFvqjXewr17vN7vM X-Gm-Gg: AYBFou2oV9rmU5/MewYwFNWGpet/dnUcaGy6+2Gp1IHCBU/J8aKRbHrdjWfoHl/vaf3 t7o/tie+nacE/kezLgRCHJsORxwOPFxK+Hd0hhvT79sGVgzRvsPnjR5Sl7Yb7OyQMkV4LowSZlC oda6cNyAmCqkviJjdgqX4yE0BI3gA2m+luq0EnUoa1ZpOUO0sR9ZYv9IhySyCaYmrMOFtgizvK9 epOY3u/lZkrLbo2C0VbC8mTDbe0V5cBN5QuPC03JmRnP2cy2RJSZ4KVdGKYkOImn/M4GsX2wcBg Dmnk49TpB9rPCnR6lAfRscRYblfRboTCQrZWMueL+jBsCYdbl22jVl+duuvMD6hnnV3DIZB3yDN OaEOeRxj4z1gGEQ== X-Received: by 2002:a05:6102:5698:b0:78f:f234:75b9 with SMTP id ada2fe7eead31-790726d342emr1955918137.0.1788974176150; Wed, 09 Sep 2026 10:16:16 -0700 (PDT) X-Received: by 2002:a05:6102:5698:b0:78f:f234:75b9 with SMTP id ada2fe7eead31-790726d342emr1955829137.0.1788974175459; Wed, 09 Sep 2026 10:16:15 -0700 (PDT) Received: from localhost ([188.216.77.92]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d1fb04f1esm60278055e9.0.2026.09.09.10.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2026 10:16:13 -0700 (PDT) Date: Wed, 9 Sep 2026 19:16:13 +0200 From: Lorenzo Bianconi To: Mohd Ayaan Anwar Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v2 4/9] net: stmmac: qcom-ethqos: convert ethqos_rgmii_macro_init() to void Message-ID: References: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> <20260908-shikra_ethernet-v2-4-bbe3389d0652@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Jz3BLvdJrcEnCQaB" Content-Disposition: inline In-Reply-To: <20260908-shikra_ethernet-v2-4-bbe3389d0652@oss.qualcomm.com> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA5MDE5MiBTYWx0ZWRfXzn8+dYrqWtnO qFb8Lv/CfEeUv6RtL/OTvmvILCFKQQYBRC0hn8ca8eRZ3X4qvVg1wZG5Ehzh9ePoosoZ0grQP/o hUpa8c1bhvDbUCv2ELNMRSUMYrOjtMg9ZlL0LQrqjH4sg8PIQKAraQsxDG27/jRCdL0gQOdpYRd z64cPN0gKkXHJFbgV+5dbzH8OT/eLFUXG9esK1yTDxpFd/0Wh+++qJYJaXvc2Tjk6hYVZd0U3Vx zN83meQB68yzaTfY3uH8vZaHRG1N4vSAKDIKW0WkRiXfpgmxRJtacZvtesEL+7w0G4lu//TG0Wh 84YG1aHZ2nxYmK/l/6U2eybGMf20XrAGhpGl+d6pfP8o3bFUPly1qbqtuf4NGIv/E6UCXTJ+scH mAcQ53fInGyhQyoxMBAL5wkt6Kh3BRDEp9xo2tApAXFQL1AMhRQpF5TgQueRbueLNKZfhor7PGy D+OmHNpFeDJXvhqJHPA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA5MDE5MiBTYWx0ZWRfX+yuJGImJ04Bi FhaRYY7XeAswCxsIKeUyC5hN/7v067GLpsh8pMp0XLrM1Y2k+n1Vvp9tyuHhBdhG+vDZCqeEuZH nt9z0ztS2u0WssRnAXL+dFh3GLPWV54= X-Proofpoint-GUID: gG8lxYelszun_tR_VDuZKMS_MoFwCCIO X-Authority-Analysis: v=2.4 cv=KOlqylFo c=1 sm=1 tr=0 ts=6aa19461 cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=WpTaRW6qxYHRGzLzQsVYzg==:17 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=VkhmObMS16-UOsR-uKgA:9 a=CjuIK1q_8ugA:10 a=Ytgtto6viW8UiwRGLNEA:9 a=TD8TdBvy0hsOASGTdmB-:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: gG8lxYelszun_tR_VDuZKMS_MoFwCCIO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 spamscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609090192 --Jz3BLvdJrcEnCQaB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > The return value is never checked by its sole caller and the speed > validation duplicates a check higher up the call stack. Convert to > void and remove the dead code. >=20 > Reviewed-by: Maxime Chevallier > Signed-off-by: Mohd Ayaan Anwar Acked-by: Lorenzo Bianconi > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) >=20 > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/dr= ivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index ac7d6d3e205a1ab5b391def879d6f1033a0961b6..44270c25d874f72e7f971757f= ec659d36468c315 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -371,9 +371,8 @@ static int ethqos_dll_configure(struct qcom_ethqos *e= thqos) > return 0; > } > =20 > -static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed) > +static void ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int spee= d) > { > - struct device *dev =3D ðqos->pdev->dev; > unsigned int prg_rclk_dly, loopback; > unsigned int phase_shift; > =20 > @@ -384,11 +383,6 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqo= s *ethqos, int speed) > /* Select RGMII, write 0 to interface select */ > rgmii_clrmask(ethqos, RGMII_CONFIG_INTF_SEL, RGMII_IO_MACRO_CONFIG); > =20 > - if (speed !=3D SPEED_1000 && speed !=3D SPEED_100 && speed !=3D SPEED_1= 0) { > - dev_err(dev, "Invalid speed %d\n", speed); > - return -EINVAL; > - } > - > rgmii_setmask(ethqos, RGMII_CONFIG_DDR_MODE, RGMII_IO_MACRO_CONFIG); > =20 > if (speed =3D=3D SPEED_1000) { > @@ -479,8 +473,6 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos= *ethqos, int speed) > =20 > rgmii_updatel(ethqos, RGMII_CONFIG_LOOPBACK_EN, loopback, > RGMII_IO_MACRO_CONFIG); > - > - return 0; > } > =20 > static void ethqos_fix_mac_speed_rgmii(void *bsp_priv, >=20 > --=20 > 2.34.1 >=20 >=20 --Jz3BLvdJrcEnCQaB Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCaqGUXQAKCRA6cBh0uS2t rIibAP0S/gGVaDgOtJQrrnNWdWnIJWz20hm/VIyYD9SKCquKdwD/YToyiF5E74NX CzVfv/b293W/qNrfSESKxGxMQFlq6A8= =s/dw -----END PGP SIGNATURE----- --Jz3BLvdJrcEnCQaB--