From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F5CA367F21 for ; Thu, 10 Sep 2026 06:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789022898; cv=none; b=Y3D0D9d/5jdPqlLfbBEyPfQvaCS8XIOvDqA8vKG6hpTiuHKn18Bt6r26s5efcToepw3x3sh+FVx5d6NuXZ7NxoqvqShD/K2RSHWE00OQsjDGJs3EbafQHlsG/l6SGdOcemhEwv+Ze4szspc5XJ9vT4EdNz3qn6wj2vBduI/67/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789022898; c=relaxed/simple; bh=3L2b69RJJnuw4lcVLlXhAoSaQwGiXuIlqO+HnG/X7Eg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=okm1u0PwowQ3Ci6lzC0vdSdCQ8WlqDE6xDWT4/z+JQ1oVQNSF/bDcg8xBt7L8JclJAp5+wFZdkCKoVX785r6xwmE/daOPCmIPER5YAI1OfZ2xrgaNKSZBJz2usMxRtHBKXXAw2eys4IKbMrpNI1XH2vqDPPVx129EXHLAFkRfi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R2abuqHU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Hmgy4cct; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R2abuqHU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Hmgy4cct" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68A5Gj694058713 for ; Thu, 10 Sep 2026 06:48:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=mvvRWLQy9D9Ms1FXD+eDgTSA ed6FXm3bAYuAa8sMroM=; b=R2abuqHUbLMV3Wno4oDzY4fc54qu8N2STmCSvSG5 nFInWaQ9NXOAUCB/53zkPYwe/su6S2FrpvRki969Qei5sFOnGAH6u8rnQ/NS9nF7 8tPrMD/5WKwRK0iXZebxquaEiXeKIFawu8Lgu1m62PiV1DxuuN5mWkc1WusrcG3N sMhJSxwHPwQA1NE8ebA5+iefmYGAvnrTdVCcAonY115HL5VxxVKbMyfqqa0d8n7e kQVly/qbV4xrEyAJSlIjlJ6DGkUemT6OOHD8/Vrmlf+yozrJ8TS3pbdTL8WNReEq 4RQ7US2Ib7RllZ1+9kcW90wvFasTl0pNKECp2rLVQYFuJA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gkcyfth5e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 10 Sep 2026 06:48:15 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38e54b6556aso4880460a91.2 for ; Wed, 09 Sep 2026 23:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789022895; x=1789627695; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=mvvRWLQy9D9Ms1FXD+eDgTSAed6FXm3bAYuAa8sMroM=; b=Hmgy4cctXnBrxY8Nvcva6lk8NZ5GfqVVkrwo4fQsLz3fzHS2z+Cvf8XKCkWxIwmosp wGq8KmCbPBQxha61NG//ZMt3Pze4B+U6wGlmEXaaZk+n+8cDqFJUp5K+bs0XahUblZWO GI06J3bm8ArJe8j9lOC3k+7HTKXSlbH6ZtAj49uGkSH0CY6g2NOGUK7v+UyLX9aLyNiC NsoYix70UYNrsgo7OncOqceodMaVt+wOJsEZpanPA2YSMGycwGKac6arzFQ1RPVpdpJW Yi4Vvab+V7qodArrTPKwnWFKfixYJ5Z/ISjweQruoTUu7KdlAIeVfVTp7SqN98WRvWS+ lkTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789022895; x=1789627695; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mvvRWLQy9D9Ms1FXD+eDgTSAed6FXm3bAYuAa8sMroM=; b=pvKUstIYIZDsbU8JuORiZrPixr/+gkCa6e45LP3P5jh3oBgDLzveC/ZyoZ68DV9pkL YIcmJz965K05gKWmpg6NCHo2TkWT2+CI5PCk4JhG3A+DoFYjfPJgmZE2N8I3JxGoGxtU nw/OaB+SDE1zPdHWwIFHyP5rlhWZk83+xiv0UhgSLX0I3QBBHxQZuy1HpnQTREr3RgzH HFndjX3jxBv1jG7Bun24wJV4C6vuO6mnn5CUFU6PVBkptrYAXQGgP3B0r/d95yDNWHWp VubzjHOqtGzJb9rObhO3bY8rj/Mndqn6/uQiAF6Ljy0I2AcrVt4BDy6rLXSwwdvYgDRX hE2w== X-Forwarded-Encrypted: i=1; AKwUvByxDiUetPny0wZOdMfi3c2lZYkxJaUv4wrb2jMfB7aqqo/DwGvWCAyKMyY1RKc328ngAPw+YsqIgT+Q@vger.kernel.org X-Gm-Message-State: AFuF++mbQ+AWyNe4HxV4ONz3MxizqEzKDvqd1XDqIJSUWX9iEhQAICkq /fLoyGVPw4JaCVmexgLYb8tdeB/5hphhA35Rs8zODHGAxsWfIaLeWCI+A+ZrVLdaePtuijKjVc1 oHKdaOJxd1Pe62GutjMu8HpTKjO5ksFoWOom9GKnxrkDihow3VESXlJVqxDJHXQdg X-Gm-Gg: AYBFou1unU8VliWvKX1cwO1eH5JwGpkdg9VdsGLIUpaYMC6CpuojQcKMbG4yZAIOKx+ UEDOd8yxKm6C+KutjYCi3oScQ5oz+s0Ol1xbLGjRgxoKfHesHubRyZ43OL9nuqrjgUs5UKBNbwH KaBLgOJU/h1/WMKzW/60WJjV6/v/W6Ivdqj29VDxgzNX3bX2tMYgKyFbvQXj2e0rVe2RYnfydce Wdpxj4jffbesDy/GXPT6nlvHIf45pgZNbB7rCh9fKzjhmH56NvwTAjYQk1Lhz6PTP+dhCHZ65W4 VMIo7ZYVd0tjeEi3garYXQHFb5jV3UKkrNDnuksZzXorixIF3Mn1byuxf/6oqnCa7QuGRzTyiZL yBOTFUmuT2fdVB0/xeAVM+p4eeSA/bprfgYn856g8+6M= X-Received: by 2002:a17:90b:580e:b0:385:393e:7124 with SMTP id 98e67ed59e1d1-39b261cfd97mr56212295a91.14.1789022894616; Wed, 09 Sep 2026 23:48:14 -0700 (PDT) X-Received: by 2002:a17:90b:580e:b0:385:393e:7124 with SMTP id 98e67ed59e1d1-39b261cfd97mr56212222a91.14.1789022894101; Wed, 09 Sep 2026 23:48:14 -0700 (PDT) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339ac24d7esm77812195eec.15.2026.09.09.23.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2026 23:48:13 -0700 (PDT) Date: Thu, 10 Sep 2026 14:48:06 +0800 From: Shawn Guo To: Krishna Chaitanya Chundru Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , Bjorn Andersson , Maxime Chevallier , Philipp Zabel , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Qiang Yu Subject: Re: [PATCH v3 4/5] phy: qcom: qmp: Move qphy_setbits/clrbits/checkbits to common header Message-ID: References: <20260909-nord-v3-0-b0a82721c547@oss.qualcomm.com> <20260909-nord-v3-4-b0a82721c547@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260909-nord-v3-4-b0a82721c547@oss.qualcomm.com> X-Proofpoint-GUID: JZG6UC5YZWhyOthpj5HcJvo5i5OU2iIE X-Authority-Analysis: v=2.4 cv=GNqdgeNK c=1 sm=1 tr=0 ts=6aa252af cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=Y4sVft1UDeOkrP7wHAgA:9 a=CjuIK1q_8ugA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: JZG6UC5YZWhyOthpj5HcJvo5i5OU2iIE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDA3MSBTYWx0ZWRfX02TIBp/J5DdT ao+jcZTu5keTo9KQFm2nTtKWwvXi8o90yKv6+z1X+xBW8pylebnbMNi7DrKnRjzC8yqYiPz4uEt etuQ7U6nxAZldhnc+MknU9bJACtoQHOI8BiTq+bhgu/sweBgU4gEfcdsq/MV0yfEwfzVoJyp8XC 2q7R+zUUD9fIaerw/PT59tbyQco74pNV0qQkHzCE3otW0X3iyOuJHVOQKJYVxfSBYokv6uMYptr Si3nOReat0ToWijseWxFgV3BCYFaymq+OROz0lnZujyDidkg69dJOaFn/3NVc1pDgZHcbORkt42 stgLyvLFpSeJZX/F7VFIp7pju9itRQyKDfxb7BZ6/+MCecGjhnxYUN5jYXQ5vlqvy/IG5nN0bDK jDicV/cz6mSFp7F+5qRdyto/AgQNObATlh8UaLfyBz3T2upNlvX3407NpFEr6Kgpc8Bt3MALGWf J5h3alhCmuMqT/xUElg== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDA3MSBTYWx0ZWRfX5YWO0NYjWI7P yHfrZ01O3VYcJPpHfSOm30mGtQzaQiTwe5BRjDIlRaBM8/jiGpPuUu4gY52fDVefGxvGJBNDTD5 RGWbdLuhfIdnXsLu26R10wKnTlmmjwI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_02,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 priorityscore=1501 adultscore=0 phishscore=0 malwarescore=0 bulkscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100071 On Wed, Sep 09, 2026 at 05:18:19PM +0530, Krishna Chaitanya Chundru wrote: > qphy_setbits(), qphy_clrbits() and qphy_checkbits() were duplicated > verbatim across phy-qcom-qmp-pcie.c, phy-qcom-qmp-pcie-msm8996.c, > phy-qcom-qmp-ufs.c, phy-qcom-qmp-usb.c, phy-qcom-qmp-usbc.c and > phy-qcom-qmp-combo.c. Move them to the shared phy-qcom-qmp-common.h, > which all of these drivers already include, and drop the local copies. > > This also makes the helpers available to phy-qcom-qmp-pcie-multiphy.c > without introducing yet another copy. > > Suggested-by: Qiang Yu > Signed-off-by: Krishna Chaitanya Chundru Reviewed-by: Shawn Guo