From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9846B377A84 for ; Thu, 10 Sep 2026 19:22:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789068128; cv=none; b=KVt9d9lXsGpe+gh982ly2Celh47bl0wv6pO/jDUbEfGOnL45eClPoCrdUG/oDb8W/x0LeD3LrN4b9Mbpg9kmMcXv1GHUrC2w69uEWxXJtBcVPbg9SIK5eT43o0UEQ6/f6lbveHS8iFEUsfgm94aSisuILabUVqNNBdqGNLYinl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789068128; c=relaxed/simple; bh=fz5lgnF+eMteCzfC7DTWcXSVct3k6f5dGJkct9t+RTM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OafOBZ/pgQOyE1YMdXluecKl4JmpfqQFc8gbMhV82VTLu1j/ggSmAfkjFqtEGOCems4vvl74XhbTNdSQdY49xkDvVHp/PlEsnk4gRqAXpBCz45Zp8U4wWp+jAR7vt+/Uu3IJEx5pdjz0INFl3MGDUrAEWtFj7EZTKuF9rK5NYqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b3BI5/Hs; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b3BI5/Hs" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-8828138cc95so382787b3.1 for ; Thu, 10 Sep 2026 12:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789068125; x=1789672925; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=rv/ofRiUuewkw6zCaw4zHN2Yd5sOfGP7dsRjht7dkwI=; b=b3BI5/Hsa/47pte57MPERaih8E7CTVki6DmkRYJXCCJcglOUwWCjwKPAeMEYpaEIJa xg6zqQ8ZZ3ubYKadEJ3oYhnV/fAnTO9NuOM0GaAGloGmGVZfxrJPotsh+XUTCei+AuHl dtMU7hP/kcO/PUTHBsRsgHIuFWEJcM7WswmPqR8cSsszKtxmmWMroZwLbErRRsV82vCJ esLuVUafaS+qVz1rPASR9yqWXqd0mJQBKvDtq8CBiil2f/1uh2pAeQlGSTbd0m5cq5++ 1fjvY6ox2Tqbwa9REzaFFrhXYOhps0iVUg4kTJLP3DLNCkXdlk0WhCO1w79IOmPspnrP JL4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789068125; x=1789672925; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rv/ofRiUuewkw6zCaw4zHN2Yd5sOfGP7dsRjht7dkwI=; b=XCCTsO7z5f783a+Hme5alZ5cVITWJFMP9LnftgERsDevmPlvQGRC2HWSUSVzrJRlxt 3dbx9UtznuLZb0IgvUNsFALxyr+qYXnQxnTFkk3eqw8U0Pqk0fsmXzqZFzwH7JaY6XAD IBj+J9eM8dY7W62GOE94ELElxKf55639mJVcas3U9XOZdas3f6jXJV614gktgeCP2EOG V/8hjU6CARZLcxGPEMG0xTs1K7kld/8K5q6gkXpu/oP4EA8FYCxCa8FlblMVzmi6nUnG K0Ssg7TL32woo1FdS6XN38pt24G+6eRiyyI8uf0lcF3tYXum+g29/XPLHyyVunyLzuI5 03Dg== X-Forwarded-Encrypted: i=1; AKwUvBxsrHG+Lc2cT311HL3kcZJpdVFtG2HbZBi/Y58A24mUCJrntCMZIxegvlfzgVDSKep9KBPRDkN+JUKn@vger.kernel.org X-Gm-Message-State: AFuF++nePboT0J1QQINl8qsfog60qGCHJLcSlG5fUR//mZbeyQ592RJR h9ohxXPTwt19/LH+XyFJe1xMEO90Quoo3TTCiIJ8W/fKUXaJK22nNEGe X-Gm-Gg: AYBFou3U8OpeSInn+dSL6hbA16LSusyrKGSkN76Rd6PwdRvKfDiGt5ShpPUVLuJ1PzQ QxdRDBpcO2DHkjhaodE1Pj0WSZ09ovrbMNEayk4ktAfduETYIg03V76m52jzChwNXTgPNi+nBrd DJjpGnwCMXhciABGG4KTRmeMRID18/dlMccpZq0rdqLNy4pWstrzimv6xJfzeS1lnB03/aDYLac Uv73CU8v9f6ldM61+E8OQ8aR8fSXxmeQhM5xYmlxIjb6/rCGI3N99hZw+Ua+BjsxUndl7JamYZ9 6YHdeh5Cb7faCZyX8LvhKAQP7Wzne3KDGC73g6vyxyMsO7Ff8UoeLHIVxXwcqBsLJkqS2ylbnH9 bmirZto6vffMobGtjtSYOmkJvx7UUCG096P25z2QA+621QMdjnpAMgaCJWFARzRG3Upq4Re22z5 E+8ZgyRhdRdyFtnS6uIAMmy9/fdt9ucPPNLL3peUUX2T32vLQdSmdP3g== X-Received: by 2002:a05:690c:c70b:b0:883:14e0:ab4f with SMTP id 00721157ae682-884b387abbcmr3618977b3.69.1789068125333; Thu, 10 Sep 2026 12:22:05 -0700 (PDT) Received: from gmail.com ([2600:1700:5431:250::46]) by smtp.gmail.com with ESMTPSA id 00721157ae682-88486e2ecb6sm3612327b3.21.2026.09.10.12.22.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 12:22:04 -0700 (PDT) Date: Thu, 10 Sep 2026 12:22:01 -0700 From: Chang Yu To: Andy Shevchenko Cc: Chang Yu , Jonathan Cameron , Joshua Crofts , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Shi Hao , "Jose A. Perez de Azpillaga" Subject: Re: [PATCH v3 2/2] iio: light: add AS7343 multi-spectral sensor driver Message-ID: References: <20260910063813.56419-1-marcus.yu.56@gmail.com> <20260910063813.56419-3-marcus.yu.56@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Andy Thanks for the thorough review. Just one quick clarification inline. On Thu, Sep 10, 2026 at 12:07:42PM +0300, Andy Shevchenko wrote: > On Wed, Sep 09, 2026 at 11:38:13PM -0700, Chang Yu wrote: > > ... > > > +} > > + > > +static int as7343_read_label(struct iio_dev *indio_dev, > > + struct iio_chan_spec const *chan, char *label) > > +{ > > + const char *name; > > + > > + name = as7343_channel_label(chan); > > + if (!name) > > + return -EINVAL; > > Why? Can't it be taken from DT? > These channel labels correspond to the physical optical channel names defined by the datasheet. Each name corresponds to a pre-defined range of wavelengths. They are fixed internal properties of the chip, so IMO hardcoding them in the driver is more approriate. > > + return sysfs_emit(label, "%s\n", name); > > +} > > ... > Best, Chang