From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: sashiko-reviews@lists.linux.dev
Cc: Chi-Wen Weng <cwweng.linux@gmail.com>,
devicetree@vger.kernel.org, conor+dt@kernel.org,
robh@kernel.org
Subject: Re: [PATCH v5 2/2] pwm: Add Nuvoton MA35D1 PWM controller support
Date: Mon, 14 Sep 2026 10:32:03 +0200 [thread overview]
Message-ID: <aqew8W2wgNvlqrfc@monoceros> (raw)
In-Reply-To: <20260721063343.9C6561F00A3A@smtp.kernel.org>
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
On Tue, Jul 21, 2026 at 06:33:43AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The apply callback returns early when !state->enabled, dropping updates to polarity, period, and duty_cycle.
FTR: This is fine.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-09-14 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 6:23 [PATCH v5 0/2] pwm: Add Nuvoton MA35D1 PWM controller support Chi-Wen Weng
2026-07-21 6:23 ` [PATCH v5 1/2] dt-bindings: pwm: Add Nuvoton MA35D1 PWM controller Chi-Wen Weng
2026-07-21 6:23 ` [PATCH v5 2/2] pwm: Add Nuvoton MA35D1 PWM controller support Chi-Wen Weng
2026-07-21 6:33 ` sashiko-bot
2026-09-14 8:32 ` Uwe Kleine-König [this message]
2026-09-14 8:44 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqew8W2wgNvlqrfc@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=cwweng.linux@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox