From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx2-f43.google.com (mail-yx2-f43.google.com [74.125.224.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A88A35DA69 for ; Wed, 16 Sep 2026 04:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789531475; cv=none; b=LEsg5UV1LH24Pin6iXP4rwgf9T0PYiU85JPFxOWU3Q8L9uVk3rsmGc0iGZRvCrY62ve/uMCCNq/bWTjagmaoDcX0mq9NfkRU6sudIDIelgctKkQQo9Kc6U76B77FG2r2vvfbztrYBPdbcW39y7bVu4NRZC0/xWJseI69o+6Cm2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789531475; c=relaxed/simple; bh=pFUGxOy07w0o07fjVXXzMtNN+/VmE3D4fzrpoP43jnM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JNmLkH4ie99yHX3gyJh4RE6SWKO0uyqrOpSfYGLkxubzku86QuDbW7Z+77HtBDP9uFHsJ+iVYJsbZqyT7JrdUyZweU7DXU4M8NAw9l0moqbs2HZScGh63kekD7U/mD9LjSbSTnnXU2BMyitx9P4GWW2E1sKBVugrIvL+p05EZsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lfeMDP2Z; arc=none smtp.client-ip=74.125.224.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lfeMDP2Z" Received: by mail-yx2-f43.google.com with SMTP id 956f58d0204a3-66e4ab22370so376187d50.3 for ; Tue, 15 Sep 2026 21:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789531473; x=1790136273; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=X7b6jjSFuw36SK7ohBBpAIm4B8ggMmh+imIFRF1b+cs=; b=lfeMDP2ZAzCfR0ysSNTzQrs7tQFS61YSzbeQkxI25xGpU33XyJ8JI6+HMhHAo+laZD M8xN1welHtzZGJsu910khF/QUsp1UsnJ12nujIRyB+MtXYI+V9csMJQxkyym9Zf9rIpg mOeeiPZA6BY2zwU296Nhm94F5p6sttFEn8opIhulxwMlt/OWeIpReiWdy9B6EihOEtrU jWFQiCP/rxTv7vloi1X4Ai2CFZjvNYIXVV4S/ZGQSu72Ydrj+KRqloJ7JAizYdze988d jhTZH9KVAKOIh+l9JosUoqOk4V5OGtoLPXYWDHmHmwIjan96unpqFAL8fll2t/ruNq5C +ZOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789531473; x=1790136273; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=X7b6jjSFuw36SK7ohBBpAIm4B8ggMmh+imIFRF1b+cs=; b=RwyWJJppY8IqojS4dvMVC4uc7jDW46PmeItHYAnmfXjbAz090a/0MtmWI81v7Jkj7Q EH4PPrrCS5GV/+/8+P5RZtYko4bNtwZT66HYw0FJ1qetimeSEcdUCOj7ZOk+vlPmkErN MkG5s8xpFceMGjWVAnkhbdVCvQY7BYXK1MSAP9hwTJ/s0s45FAgUzBXI8GHdZn7ED0md QMDvRAQsejGdCdBn/6T9S8oXocie3JoOuoau5o2AoWwecS4vsMWldIwo6NW2LEiepp6y dWpi84+w6rBM7tVGqHkyHnytRyqUdfyPzkOrHqQgHzNt+hYqrxw2aOiVB5ZKX6LsIBB7 rflA== X-Forwarded-Encrypted: i=1; AKwUvBwrFliOQKCdV0Nj/aLiIXxs+E8RqIhJLqJu9GGfXWeOAANx0389Svv7T27I4YhCU7Dr0IxLA98ckam+@vger.kernel.org X-Gm-Message-State: AFuF++kX7zGeUjUdaCU2oDAtnQ5m7Lb5XDox43RCgBHiEV4ObWC1Hj7n Cnh7bSXqkg2hrERJq8xBTo+tyG21H8TSaN0cWmx4Ss/v6uNYGvbOBqPc X-Gm-Gg: AYBFou0MCiodGKZd19/EAcPI/ySuIRDtwmoNTiLgJ6kLraSE8I/s8tCNsvtkFyS4rr0 bcf8Ovp5ab8Wyimo2qtF2sQrFWIQwbbA3DITAfRLqN84H7BfoycEP8H6vfSgsObFpW/PYKuht+q CM/KkdaELV2IxgH6GDRtnnplSG4OuWf4rdnNdbP1+A+wgMRS833O1sTeBhQ31ShiPnwS32vAv+g c7wJhZ4vzML0H+1VEVV2tPmP90bQx3t1r4tqhTtdauMBisUXkKekkkzRq6+E71iSpIvdArMFRw4 N4gG0+WnnW1TSiO0s4rLD5BwzmnqOPdWu1AnhvR5kMw0z4ECMODfWaR8kaKG4t2j9IVMtxt4acP 72AEnI/DVuLMzYEhIE/G7726RKGHAL7k4VIcajy1qLC7ZGOEtTK4inPIbZCvx39OBHik/jaRLVL uwTtDdOUIJ8iVbUa0OKy5VHnYpDZyoKys5vAlOxCde6P3S340CjpnZvPCYdVZWMW1x X-Received: by 2002:a05:690e:13cc:b0:670:f5bd:812f with SMTP id 956f58d0204a3-671632ceda8mr325747d50.82.1789531472721; Tue, 15 Sep 2026 21:04:32 -0700 (PDT) Received: from gmail.com ([2600:1700:5431:250::3e]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6715f45f803sm831404d50.0.2026.09.15.21.04.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2026 21:04:31 -0700 (PDT) Date: Tue, 15 Sep 2026 21:04:28 -0700 From: Chang Yu To: Andy Shevchenko Cc: Chang Yu , Andy Shevchenko , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shi Hao , "Jose A. Perez de Azpillaga" , Joshua Crofts , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] iio: light: add AS7343 multi-spectral sensor driver Message-ID: References: <20260912013912.51887-1-marcus.yu.56@gmail.com> <20260912013912.51887-3-marcus.yu.56@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Sep 15, 2026 at 10:34:06AM +0300, Andy Shevchenko wrote: > On Mon, Sep 14, 2026 at 07:49:36PM -0700, Chang Yu wrote: > > On Mon, Sep 14, 2026 at 11:00:18AM +0300, Andy Shevchenko wrote: > > > On Fri, Sep 11, 2026 at 06:39:12PM -0700, Chang Yu wrote: > > ... > > > > > +static int as7343_suspend(struct device *dev) > > > > +{ > > > > + struct iio_dev *indio_dev = dev_get_drvdata(dev); > > > > + struct as7343_data *data = iio_priv(indio_dev); > > > > + struct regmap *map = data->regmap; > > > > > > > + return regmap_clear_bits(map, AS7343_ENABLE, AS7343_ENABLE_SP_EN); > > > > > > Can this mess up the raw read? If so, also needs a mutex to be held. > > > > People familiar with runtime PM correct me if I'm wrong, but I believe > > PM_RUNTIME_ACQUIRE waits for any ongoing suspend callback to finish > > before returning? If so I think there is no risk of a race here. In > > the case of system suspend, worst case scenario SP_EN gets cleared > > before we read ASTATUS or the data register, which for my use case > > at least is OK since the entire system is suspending anyway. > > Yes, if the raw read is guarded. What about _setup()? Is it guaranteed > to be free from races? If so, we are okay. > Currently in setup_device() I'm enabling runtime PM before flipping SP_EN which is a bit problematic. The fix is simply enable SP_EN first before enaling runtime PM like Jonathan has suggested. Then I think we will be OK.