From: Frank Li <Frank.li@oss.nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: sashiko-reviews@lists.linux.dev, frank.li@kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org,
imx@lists.linux.dev
Subject: Re: [PATCH 2/2] arm64: dts: imx8qm-ss-conn: Add HSIC usb@5b0e0000 node
Date: Thu, 17 Sep 2026 13:54:23 -0500 [thread overview]
Message-ID: <aqw3X9aQzm7LWPVi@SMW015318> (raw)
In-Reply-To: <CAL_JsqJkL57yUCF41BJvsoJkhhRb8xnukdtxe61fXB1r_7gK_Q@mail.gmail.com>
On Wed, Sep 16, 2026 at 03:43:28PM -0500, Rob Herring wrote:
> On Mon, Jul 20, 2026 at 4:24 PM <sashiko-bot@kernel.org> wrote:
> >
> > Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
> > - [High] The `usbphynop2` node requests the wrong power domain (`IMX_SC_R_USB_0_PHY` instead of `IMX_SC_R_USB_1_PHY`).
> > - [Medium] The `usbh1` node is enabled by default (missing `status = "disabled";`), violating SoC `.dtsi` practices and causing unconditional probing.
> > - [Low] Missing required `#phy-cells` property in the `usbphynop2` node.
>
> This reported issue is now a warning in linux-next. Maybe the other 2
> issues are valid too?
Post fix patch https://lore.kernel.org/imx/20260917145803.838836-1-Frank.Li@oss.nxp.com/T/#t
Frank
>
> Rob
next prev parent reply other threads:[~2026-09-17 18:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 21:10 [PATCH 0/2] arm64: dts: imx8qm: add smmu information for usb and add hsic usb port Frank.Li
2026-07-20 21:10 ` [PATCH 1/2] arm64: dts: imx8qm-ss-conn: add usbotg3 iommu information Frank.Li
2026-07-21 7:48 ` Alexander Stein
2026-07-21 15:42 ` Frank Li
2026-07-20 21:10 ` [PATCH 2/2] arm64: dts: imx8qm-ss-conn: Add HSIC usb@5b0e0000 node Frank.Li
2026-07-20 21:24 ` sashiko-bot
2026-09-16 20:43 ` Rob Herring
2026-09-17 18:54 ` Frank Li [this message]
2026-08-06 19:41 ` [PATCH 0/2] arm64: dts: imx8qm: add smmu information for usb and add hsic usb port Frank.Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqw3X9aQzm7LWPVi@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank.li@kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox