From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: Andrei Stancovici <andrei.stancovici@analog.com>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Beguin <liambeguin@gmail.com>,
linux@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] iio: adc: ltc2497: add LTC2493 support and line-frequency rejection
Date: Tue, 13 Oct 2026 16:58:47 +0300 [thread overview]
Message-ID: <as45F3tHGzTc6lMk@ashevche-desk.local> (raw)
In-Reply-To: <179189735509.1005940.16593087405634433360.b4-review@b4>
On Tue, Oct 13, 2026 at 02:15:55PM +0100, Nuno Sá wrote:
> On Fri, 09 Oct 2026 11:43:33 +0300, Andrei Stancovici <andrei.stancovici@analog.com> wrote:
[...]
> > - pyadi-iio hardware test suites: 41/41 on the LTC2493, 36/36 on the
> > LTC2499.
> >
> > The series was rebased onto the base commit below after those runs. The
> > rebase left all four touched files byte-identical, so the code posted
> > here is the code that was tested.
>
> Not sure I agree with how you split the series. To me, patch 2, 3, 4 and
> 6 could be very well just one (adding support for the new chip). Patch 5
> becomes preliminary patch which is adding a new feature the new chip
> will also take advantage on.
But they are sound like a good feature-wise split. I would leave that as is
currently.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-13 13:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 8:43 [PATCH 0/6] iio: adc: ltc2497: add LTC2493 support and line-frequency rejection Andrei Stancovici via B4 Relay
2026-10-09 8:43 ` [PATCH 1/6] dt-bindings: iio: adc: lltc,ltc2497: add LTC2493 support Andrei Stancovici via B4 Relay
2026-10-09 12:06 ` Joshua Crofts
2026-10-09 14:45 ` Conor Dooley
2026-10-13 13:15 ` Nuno Sá
2026-10-09 8:43 ` [PATCH 2/6] iio: adc: ltc2497: " Andrei Stancovici via B4 Relay
2026-10-10 7:05 ` Joshua Crofts
2026-10-09 8:43 ` [PATCH 3/6] iio: adc: ltc2497: add LTC2493 internal temperature channel Andrei Stancovici via B4 Relay
2026-10-13 13:15 ` Nuno Sá
2026-10-09 8:43 ` [PATCH 4/6] iio: adc: ltc2497: add 2x speed mode support for the LTC2493 Andrei Stancovici via B4 Relay
2026-10-09 8:43 ` [PATCH 5/6] iio: adc: ltc2497: add FA/FB line-frequency rejection selection Andrei Stancovici via B4 Relay
2026-10-09 8:54 ` sashiko-bot
2026-10-09 8:43 ` [PATCH 6/6] iio: adc: ltc2497: enable line-frequency rejection on LTC2493 Andrei Stancovici via B4 Relay
2026-10-13 13:15 ` [PATCH 0/6] iio: adc: ltc2497: add LTC2493 support and line-frequency rejection Nuno Sá
2026-10-13 13:58 ` Andy Shevchenko [this message]
2026-10-13 15:09 ` Nuno Sá
2026-10-13 15:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as45F3tHGzTc6lMk@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andrei.stancovici@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox