From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 574C61F2B88 for ; Sun, 11 Oct 2026 03:12:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791688359; cv=none; b=anemJ4y2tNUIMdz2/GIY5+VMSBpBQtGO9EoLRhBk360diDklO94Sad+F5CCykPAs6lv3/7qRNJBXeHmOm2Hgim0b7UYDhSFwWFsBiCiAWYI0sV2PA9+7xEQu/k4owfrMZNErepUKXoG/96EIAsYKh+bxcSbYcACpJhSyj8qbSnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791688359; c=relaxed/simple; bh=OChUndas+DWa/5O82BL8ViYuRfhyJvWS0e17KpOp0Q4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oH2xlZa/AKVOMW3Rq2RCKVYrdmxoXEHGSfKaXA4iWk906zcV1RIW51R1LDagb2/OUpf4u3yD/RlpqP1VwI2NQmlqSnyEzbEHEiUIEM/jupzuO3MIrXoQoaSz7HPkZs+2+z94anKsEPdaOfd1HgHrzLEBFRG/2z6u3xFOUXYzeCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Va9YGU+H; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Va9YGU+H" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-33e6279a1d7so1034955eec.1 for ; Sat, 10 Oct 2026 20:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791688357; x=1792293157; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=a1lj3fVjbUIN9JIS29oUB2cIzv6MSxY80cUu2b2ZDGY=; b=Va9YGU+HaKMH4sEyXcJa6745yinu7nD3Btls0OfP5UVl0hBjHc+azxdjSZOfe+GPIf 5zFeKsyg4ZlCHD9qREH0n/36O85UssAUp76fB4NVnRqi0aGS2/OZg8XQuf/FOtYN6Pl0 VhOrecv3XsU/QVmhckxtypDnncFUzc8CXbbQoT61vEj3pXyGDTWNkfbiX8sQ4jjmmOSm WUWo2cjRx1hP3utd3rTBDM59sGWvLeqbt+/mysmrYFerWrXd4EsY3OP9d0q7Co2rTQdz ihaKSiSgfZ28rKhjJMygQJTJj7PfMHUti+hMNjARK/yTI2ay7q4mZnI7XThsjIn6P873 7/sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791688357; x=1792293157; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=a1lj3fVjbUIN9JIS29oUB2cIzv6MSxY80cUu2b2ZDGY=; b=YegV6ZJtnWOHYkQnjjxF0Wh23vL+M9cDiAlt31KOdzsBBkhxnIa7hHPqpGlnj/7ieU WNVcFt9LvHZGLQHrYnbJgP7QTRnpcS78aA9xkTpH9CDv8+nzpEfkLeJGEQzg4whNYHO2 5ugch96zDbSE2B2TuRWzTvq3jO26a0xgUGMVHigq6yOZUFWPPDNJtuE9cCOrNmg08WCJ N431QjylCDljXregADBIkhcJlax/5bKWSt4ZK9GNCcGUzMx0hAeH+7TG7YxwCTu9CIFd /TXsvcroQ/REgCsUtorUi99WPJlcayPC01g6Tpdlxa0EWwOptcZ8zgg6WifEVhWkCoCP BpOg== X-Forwarded-Encrypted: i=1; AKwUvByCj4gQK3CcqS8IHSet0sFYK1FoyJKdTu2pq3PTFEPT4ZolFB2yDQq4Y7AXA7P0JjYKxJ/mVBLzu2l/@vger.kernel.org X-Gm-Message-State: AFq9FYJVQl5bAEJl3b5XUCSPXj1enY7/GR28QhfrQxJdndEvZlWtICPV AC71kFelMBLU4XKqRrTkHQgGfZ7vSQp/nY3/IUns7ncTlzPIE63yWkEO X-Gm-Gg: AYBFou2JD5RV/4Kh/+wyz6ljrVJe/GZ7ApHtImOi4IBdToUcpUWwF1Jni6RZBosc9RE n1rloV7XKYyp3lYbAMDdNBIfmf3ymckrQJguRH97489eihrlNQ90Losn2xnX6l1sq5MtPIAuwQP Zu7mMsa4Jg42xC8saeIv3K4qF1DfRT8XBGC1bEd6c+xN/tnfRW2HFtFX6D8l8GtDKeyhWiHxsmK 32VVY/01/hZGvIrmsVl8pl/onstvYdTyjB7ncJF1N4T2AYZLOLH/GpP+DgMfAWRBb4OW4duzUzV IavXoYhE0nQrBIHf1jDpLSw9t/wX7+R96ZGSqZnDGRLP6YXgfogaboAMrh4UPqqbhETnwktnvre Ap+7tJ0k2p7YsXwzVXFyG6l3n5y7l5/SKeY/j4NOecooQAohcFJAJB7e1gpMBze0Qp/SQux7CPm uyRvoGOgoRPwUqZNPqB10PG7N0QfV0zhtQ26EN6ytVsWl5imsfYTTSObRQlZEIX/DeWumF3lS7 X-Received: by 2002:a05:7301:1529:b0:352:fe8b:8d38 with SMTP id 5a478bee46e88-3537e059bf7mr8378888eec.14.1791688357177; Sat, 10 Oct 2026 20:12:37 -0700 (PDT) Received: from localhost ([104.156.230.40]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3537c841648sm22329042eec.3.2026.10.10.20.12.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Oct 2026 20:12:36 -0700 (PDT) Date: Sun, 11 Oct 2026 11:12:27 +0800 From: Chang Yu To: Andy Shevchenko Cc: Chang Yu , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shi Hao , Joshua Crofts , "Jose A. Perez de Azpillaga" , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] iio: light: add AS7343 multi-spectral sensor driver Message-ID: References: <20260919235145.48273-1-marcus.yu.56@gmail.com> <20260919235145.48273-3-marcus.yu.56@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Sep 24, 2026 at 09:22:05PM +0300, Andy Shevchenko wrote: > On Sat, Sep 19, 2026 at 04:51:45PM -0700, Chang Yu wrote: > > +static int as7343_read_label(struct iio_dev *indio_dev, > > + struct iio_chan_spec const *chan, char *label) > > +{ > > + int channel = chan->channel; > > Why signed? > Also split assignment, it will make code more maintainable. > I believe this was mentioned in a previous thread. Basically because iio_chan_spec.channel is an int, so I had to make the local var signed to keep it consistent. Why iio_chan_spec.channel is an int is a mystery to me unfortunately.