From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81BE14156FD for ; Mon, 12 Oct 2026 10:57:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791802662; cv=none; b=SCK1EvW4eF3exH2oRzgSBDK8sZ39utNXJLC16AyX8hQ9eDiNr96ke8G9itaDPl0EncLbo4IBzj4ci9zdMY5JFiBHblMkNkbOcFM1oWKccKP0gnd6nGHDJeCarFZsHShye6RJAMv5LvP0WAQ5V6e4BJKSfG7kzI7/wXBPLhUieCU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791802662; c=relaxed/simple; bh=BDqmE2ovCASMLGpvn0PIbmd0++tdc88S3TIXBLKQRbU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JP+s96KaSczf8F7IEWPZGMFEJrQg7Ebz7hFL62LbP3lKLezKKPMqGyXfPJzvMW0sniob1llOkMPQqjAWEQUDR3Fo3CjxRwdgBoVAdVJz2L9AmPxrYz7P51nLCmvfGJe8qfFx4ku3JsPROPM/IGUty45Tla7ZrHHzMlQKKczCOgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=c3DUoYg6; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="c3DUoYg6" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4a018dc1f98so13733055e9.3 for ; Mon, 12 Oct 2026 03:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1791802656; x=1792407456; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=RLup6P06ESS7erm0ADUuu6e9Di2cilyz4zC5+dpI2eU=; b=c3DUoYg6LPcnSwfJ9IP9UFG7dMc9d6cAdw6B+Iy9+LjdNdnSS46nitKhEWuwsWAC74 5tbFsTgKDfSp7OXifP9xaoQNnLRJp6kZqmlyNcAAasMOUbuANEfUYtmUbIoteDwiXGSk KJa2Nu5OiofBgnUMPu3FBGnF04P3ee42wYjO8qzLeWeSpzkrAXDIeFXGEPZmegFaMWhf bxIcCj9fJL+VsCwerMoyoyehrWcKVU7VIF3vl2ZbZ1DIAc1z50PoSaPscxFhiR9sOAYW vuzfG06DvAdMGH85P3zSr5aUkgaL6wvNPocXZDpWNoTXi7CLuKNijrLaZmoXcx4Ek4Bq 3LQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791802656; x=1792407456; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RLup6P06ESS7erm0ADUuu6e9Di2cilyz4zC5+dpI2eU=; b=nQ7mcW0uqp6KJ22ck/CZ9uvlRgdIKpB0jyh43woD+fDBlXZK1RCkWXf1XEeRlOH/oZ 66yBRw32X9V4+0Rc+Vvmy7la0wDDaRqIYMbrnu1fy6lkjDa5+vxNnvdO8wmKoSpWCFLZ AQYA4xYQvPJWEZKZELgxW4WLAj/UVWY00A9xmqUobIS1ZpcpZ6chCntzIwPEbxbB1oY3 8pMkoh7vlGMyP55gT1Kwq3Zv6EvQHRSs3AtnfWAJXg5XV+nDHDNdghp9mxJ0Tmefr8GK SKKh2OxlOe1jae6UAX8xZk/kWuEkrKzDcQmO7uftUcsPNHLRDPS5rJ4to4nt+jN5pK56 n4tw== X-Forwarded-Encrypted: i=1; AKwUvBw0xXRTrA+EyxSSQQJ+abCz6pNk1vG2I3919FfYWALntGPcVOdQW3C3b5QXUW1Yx6tQShmq8TVN1yGT@vger.kernel.org X-Gm-Message-State: AFq9FYJ+vvsXkz15j3fPSS4jicn0y8iuIP7HQRTAUvacnNiiFmCKyO93 bEGo0oIBOutEQkdcWOydXZZvtFoEK3LPTWhzCWLPHtlB2s25vkT6EXFTtupckhR4wLI= X-Gm-Gg: AYBFou2d0pveW10N6qD6JoDmO/sJbvLIs5stfx2D38oSVykl3SwHOriWnjYcFXmajcb 3jntwrie+FYRbAdUC8CvmBcL7WaIkJSqXU1N9VnXwD5cgQ2C+FdJbRDUXx/Pq66HBxUCzUYBddT sdx1yyPwuuqO9WQ6WPQcC+Ut+VPvEVjGVdrxPhvzkzVGMYejx0CP7RfybHSnDkpFhl5tc4S2eS+ FRkOFMV+mhEHddEwXI+9aj2SoIc5hukcix5WTJDrnRqaqW2tBOnTy2E8TIPksxjIhXw7MUDY2ts Tvly0PZqmqLf8SaWQIBZrmIHWIfpRalnHGZaQH/BE2RouzxdIu1dqadBZBA2XoGgBTwZHLlmP33 3yx7HLoWerf6x9GZmOfAIdyAMYtyWwN2I7JdGv/PHLGtRt+SWinOW7GHCXVATPyvk31uQ0+QhkX Vta99HUHC782aNjw51QGTNKuXMx2upDl6niFr69jA7j6ms/3exqlMEBJY1Sb3E2byf5xtymQRhY xE8ef7Is0GEjlW4ULpquLulyXOjazzWemb/FFM+kG64H9mFdv4p7ICIdkV/5g== X-Received: by 2002:a05:600c:3b1a:b0:49c:fa20:cbfd with SMTP id 5b1f17b1804b1-4a18e4b91f8mr158595575e9.20.1791802656360; Mon, 12 Oct 2026 03:57:36 -0700 (PDT) Received: from localhost (p200300f65f19a904ade4f69ba751c34c.dip0.t-ipconnect.de. [2003:f6:5f19:a904:ade4:f69b:a751:c34c]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4a18bf2343asm525197235e9.9.2026.10.12.03.57.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2026 03:57:35 -0700 (PDT) Date: Mon, 12 Oct 2026 12:57:34 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Luna Hart Cc: Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Shuah Khan , Randy Dunlap , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Flaviu Nistor Subject: Re: [PATCH 2/2] hwmon: (tps38900x) Add driver for TI TPS389004/TPS389006/TPS389008 Message-ID: References: <20260929-lhart-dev-tps38900x-v1-0-7045c5894152@witekio.com> <20260929-lhart-dev-tps38900x-v1-2-7045c5894152@witekio.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jub6o62xngj3zzzr" Content-Disposition: inline In-Reply-To: <20260929-lhart-dev-tps38900x-v1-2-7045c5894152@witekio.com> --jub6o62xngj3zzzr Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH 2/2] hwmon: (tps38900x) Add driver for TI TPS389004/TPS389006/TPS389008 MIME-Version: 1.0 Hello, On Tue, Sep 29, 2026 at 04:04:05PM -0700, Luna Hart wrote: > +#include > +#include You can rely on to provide of_device_id and i2c_device_id and drop . The mod_devicetable.h header pulls in many unneeded dependencies and is bad for this reason. > [...] > +static const struct i2c_device_id tps38900x_id[] = { > + { .name = "tps389004", .driver_data = 4 }, > + { .name = "tps389006", .driver_data = 6 }, > + { .name = "tps389008", .driver_data = 8 }, > + {} > +}; > +MODULE_DEVICE_TABLE(i2c, tps38900x_id); > + > +static const struct of_device_id tps38900x_of_match[] = { > + { .compatible = "ti,tps389004", .data = (void *)4 }, > + { .compatible = "ti,tps389006", .data = (void *)6 }, > + { .compatible = "ti,tps389008", .data = (void *)8 }, > + {} Please use { } with a space in the list terminator. --jub6o62xngj3zzzr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmrMvRsACgkQj4D7WH0S /k5rDQf/ZR/aBJ51FBzSPY3CLIfaH0pvP1Gj2j3CUzW0Vom/XobHRZB1Ti3CNv7u FoToTijxGUAgNf01mcy4kAsKlH51piW9LmhgAhDt9yk8TrD8rDwuHcGKn2xThTdq SyUWpDvd1KLJt1BrIbb0XLxVKJQWrwi0T1KjX2cc/Kub2y8u0KMPQmSm1hJnYY83 Dzjl4aJmfNJ8lFZwpV8Dm5a/cJDaFS6fcjmbiqrskHLo3DAJQGTINdxMT1k/y6nM 5ApNcvwdC0zs0csER7LQtHsMvu5zTGaXJhDOnhVEQzof7auCFJyoC6WlaaAWpDsr sGnCLL/cr+GS8SOeZDlFvyWuLBjnTg== =0D0m -----END PGP SIGNATURE----- --jub6o62xngj3zzzr--