From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DE7F1DF261 for ; Mon, 12 Oct 2026 11:10:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791803406; cv=none; b=ETlyMUDvfaMjur2tVSdKUMlnPENhgSE/XW2C8NVF3OW6FWvreZp6Sqi+AeVo5hIuCzNlhuJ6QlHMhunhd6gU1PCWPG76iiX5+fgEa4JjEThrcbzEod+/UIEDdyG3YQIQ/bYzS4uX0MuJmimofbwt2TlRonWMuLwKvgQt7meNiTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791803406; c=relaxed/simple; bh=g71acWOwhbzJ290pVkw5jld4zbq8QvuQo9b7GDaGEC4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GcC5sltfSpla3W4FHoUPJ6ZPg5eDNqyRDK2UAv2w8b8wIVD7kSxZMMYJPdvbW0g6cUMVM3G6DbJfoiWQIKPZeeB+QXMsGO6wTHyyYl+plKvQJ6R/eC6O1/8cVNKCKxTg3Lobi2BIcyOkFG4Z3eUSljTQfOGMWRqD3+OZcnXgOV4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=DIa0nqN9; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="DIa0nqN9" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4a19cba5c14so10657505e9.3 for ; Mon, 12 Oct 2026 04:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1791803403; x=1792408203; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7k45PANz4WRUzNBot8+/uXuq6lmVd6FWyB01BZ/WnJA=; b=DIa0nqN9nf36m4RlBfpYZQPI+f77gxrbxyJZ5sFUjCiDMmdEV14tLg47Gg8uoPiSUz duuXgpN/x7YOic1NvA8op4VfHCz3uZ/YDnDyUk0hwG9HeL5W2wL8lBxcUri6+lXczb9r e1tSBWEunHButNmitmEhiwJYhuZTFaZknzw8GBt2qAWQdyUQE3v5u4Q9bDIp7D+RTEEr Dx0HVMQudXFU7nuRqtb1VIjSE3vnHsCC/71yOYfkBES52qUYCYqq2BgBfjzHV6xaf4uB iHYHILux3NIDZ0viCPAFwzbogmh8xECq/p4/OmuATwiEFpxVfRfiXtxnLu0Z//8m6KiF /T7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791803403; x=1792408203; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7k45PANz4WRUzNBot8+/uXuq6lmVd6FWyB01BZ/WnJA=; b=ULFXUptpA9x20QjdLklsSDERQhgXpQqyQ764UOwNkxrWyAmOzqsuUiwvullDcOAeum koaNtQF3nHgB4CZiSkMYB6HfTdlqmDf9su9ek59OlHXAAFAkuQaAxDSHOXsXl1G38knb TYviduxxoKwBM/vQvBK/43RSS+Opn3M6AzD/CL1Cy2GtawrsABFcH2O/TuRgfQOoe8CN lqfqbywg9y//+Ds6uP1TmlL0oj6vwx6FWh669Z1EKLp2Ot6BB3xB6VlYii4E6+cmw10r qdZVrtZ/9H+cUAcpPBwDeMmye+Wd/BWBdHXfFRnNk1CcH4W4SuzKY1mi/gxbZWFLIsZI DzRw== X-Forwarded-Encrypted: i=1; AKwUvBw8r2mT/Cz5gyv8jrkZwQrd4xG9/sxrxi/olE48nVUSU5WiRo5WwAK7cbck3f3ClAqSe0w95laEcySu@vger.kernel.org X-Gm-Message-State: AFq9FYJVuoxLlWmg/JZVV7hges9GoEC2oP+JCVD/nF44q+XZC+yYYSDw dTkA35/fqNIFbr27oPrjl/xFQKoYHv+FYQgEZ3+hXowEsgvOo/dLSU0cLUNqhQF8ypg= X-Gm-Gg: AYBFou1483j/8QqQvPo74uHe8CBSZh27Bt/6bSJeOqISQZcP+TaMKArjL/g7vtqMFV0 QJu0BpU3O9ac7fEVnV1DicY43p6UlAcN/WIELvu/ZbMARporpkL2HwgcHMso4YZD4ibJhegRqK2 h8aEPmL+O+ZEIZcZHpWQYsY0IMHQZux+fSk+eFPCcH3MuwQxoG75ZwJrEghBD6A8kuydYg4dEtS GUwyI0F/v84UQMn24R1VMFObNTkBNqTKdbjIrdbavtDYqf46fdDhGwbNZbfzflxgrZCsHv24nsP CjS7mYGsLpZSD3eLr9KniLBhXWAK5FB2+lPbrKByoGILh0ON8PumFoSPRNkq7J059T35EjiW4v8 XmTSZDCocletDVglj4pZ6n6n23BD/2lwT698cp2J47fQ4A+8PxpZZ5lmQF+1b8c17NdsWauD40W YIfNvxfNb0krKTsubbPYaM0z0thP4fajFCaI3HGyl7QSPyQ74ci21bwK9HRZzK03fiAI2OT+x3Q m3e0x1ZeY5v24cXygkM0JAgvk6i7ZAWSG+FtKVTEdG6WT6Gf9yVAoTb4PSGKdiu7G6JN+ZX X-Received: by 2002:a05:600c:4ecd:b0:4a1:96cd:2f60 with SMTP id 5b1f17b1804b1-4a19ecf4c20mr49066785e9.3.1791803402684; Mon, 12 Oct 2026 04:10:02 -0700 (PDT) Received: from localhost (p200300f65f19a904ade4f69ba751c34c.dip0.t-ipconnect.de. [2003:f6:5f19:a904:ade4:f69b:a751:c34c]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4a18be96549sm391352405e9.6.2026.10.12.04.10.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2026 04:10:01 -0700 (PDT) Date: Mon, 12 Oct 2026 13:10:00 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: armandas.kvietkus@proton.me Cc: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Griffin Kroah-Hartman , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] Input: aw8697 - Add Awinic AW8697 haptics driver Message-ID: References: <20260930-mainlining-v2-0-40bb1b3943db@proton.me> <20260930-mainlining-v2-2-40bb1b3943db@proton.me> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pmteufvncpnmcdgk" Content-Disposition: inline In-Reply-To: <20260930-mainlining-v2-2-40bb1b3943db@proton.me> --pmteufvncpnmcdgk Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v2 2/2] Input: aw8697 - Add Awinic AW8697 haptics driver MIME-Version: 1.0 On Wed, Sep 30, 2026 at 07:18:51PM +0200, Armandas Kvietkus via B4 Relay wrote: > +#include You can (and should) rely on to provide i2c_device_id and of_device_id. Please don't use which mostly only adds unneeded build dependencies. > +static const struct i2c_device_id aw8697_id[] = { > + { "aw8697" }, Please use a named initializer, i.e.: { .name = "aw8697" }, > + { } > +}; Best regards Uwe --pmteufvncpnmcdgk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmrMwAYACgkQj4D7WH0S /k4Tywf/fsRyjXKEjyrY/wgZZmTIpTg9zksElEO7EU+qTlrbPAraaPtoO7qA60bT SPtHBKx/ahmkQ0Zu99dq4o25nV72w1qkroIbtp3o8iAR+Y7gH2vg/agfPaJURTuI 19SncK1Yn1oLj/g9OJhGP/UWN2EthaJ/UPg+GO44EbIg2FjN3izEgioRiCTCGhKi E07DcJ7khc4dDEbZ/uGFhiUPCgRzUH3ZVOIOFwNlhyJCmd7xzdE7vq/ib1pq2UFb LGwY26i+PCc8mqIRerCHzRFvdEVuWvKuWSIRzKq0leaaw+hK4ZXAvLiHx1dVJn8K 4wNGyZXFuPwY58DwWlOml2H9vh+NOg== =yCu8 -----END PGP SIGNATURE----- --pmteufvncpnmcdgk--