From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7601941D231 for ; Mon, 12 Oct 2026 11:18:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791803908; cv=none; b=R28xf+6zxDCEo2kLstUhIzc71B0X+oJ57OScudG+mHplUb9l9jRHHZayAmWiZ0LqQ+p1F4KI+uZ0JF2Zh0Y0nar5FDqOwrLwUKbLc7vQcLb+s650ioYdIGO59ZZLyWuvosGMcsHd4ySPb8fm4pPUoSfPdtoL7KkaeUdIFaRRlPA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791803908; c=relaxed/simple; bh=20jkYx8ujzIk6V8EjzGICADAn/dtFkP5yiHUM8K7JU8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Syl3kBmibYyHpxEMAi6sFxGUykuk5irBrhy7D4vQH+jH4/Ck9jeZFzYCQMorv354YS1pHUtZWdZ3xTHSWtlknrqeRBUA3rj0l5+24llzy9ujrT5n4TFpO/BEoP5jMu9z5OlcSI6lYblctYezlT4zcesoQQ7DmNw0TDdy0+sSpo4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Bnf5mhq0; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Bnf5mhq0" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4a01933b584so15358085e9.0 for ; Mon, 12 Oct 2026 04:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1791803905; x=1792408705; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ojX3hkGfX4or6LXO9A1AxAUN8SUQm9XePAgC0Ad/Cog=; b=Bnf5mhq0tNnn4pixhxuNbrwY7dD+z5pbFI0pSD9ORZa0KAX56bMZTKzMLGJHKvAVSI dCdegE1rufjmxQnHpLM+FNp6LD6lr5jvhWtGLruHI/U2ErYJgdEEkB0r3h/73OzkNU+o 8fT/iJKth2sda1UiO+aBJesZDMyYYKRLhfH9HdJuCXRQWG/EqrhbNsd+P/OwDhXDvpI6 uRDK58jaYmzbsdHKeJHxESER7hVFpuRHFhsRjBivv0dybDCumoAa8Q4xtMApg89+2BW8 8nHduOJYcqDPr+My4ipcatjhFBr8DJhRer5gXh8FnRfGDrwB73R2XnWfqjH+ClAROMaY lmlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791803905; x=1792408705; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ojX3hkGfX4or6LXO9A1AxAUN8SUQm9XePAgC0Ad/Cog=; b=SJOU80nuwflwEzf4jYsTtfbBpk3d4t6D0nc0/+e3KMWjB2SIZEj5cBOXVK/APOZ7BZ VQNVV09q2abWAtdBUe6Mqkp8TLOH8bPCHfHYS/UTyUFl8HNruifVzT5TR23IqHHwn97K LEVpVhjZgc2Gy7Wy44KcS5uA0v2TQa2cxa/krGxb0xEOd/dexkdy7jy344GTEG2CVuZS MEn/KYHlvyrrRGBw+rULkHGeNrzcQIPtKxmkuGMHXeiIzG7OeSMwW038S7fUcRkD1OcX 8iv1g2KSWjHShCtspE8t0Osh6/Hs/Guodgj39zbwufGoFvmBwqBKzvZvlFXjTP9KkRY0 QuEQ== X-Forwarded-Encrypted: i=1; AKwUvByFqwEdLDH//JSfskzAUF3MlY//bGgcY+3BoOQMVvHaepKEGJKT7T51fMN68zpTObTiF+M5tSWw2X78@vger.kernel.org X-Gm-Message-State: AFq9FYI9UyaKhP1IFUjIXfXmltwaiUwR7pVw0ujvi/Hwe3ucTmx5zh7f +RRlau7RBsAU0ELHQ0uEw3yjcWqRhStoeWX5rL38ex5C+HD5OtJtc5x0/JumoVnUdcc= X-Gm-Gg: AYBFou2ororNmhFDRCQpHu1EBQiCSOkBOS0C70toy8ca5dQGr5MM4NKDihPtiW+V/Bf z3xilXAtts5bHbNA51/KlrZ2pXthh1wjicxf+5eShNRMVxmfTyuQPJ+IwEU56FuQlt7SYmQkDIC 8ooqbprYe0msb6nmYprgg4oyMPb5WyzlLZJXJ8KCZlUcz5L4YHpuhNym8nmP9S2FJ6zIpNnNDZj jZ4QV/yj40udS+MAw6SG2ZIknZ6E23W+bhzpNRdYaBKyNtlWOu/IUjSwdKVPctxA4gKRxUQFftK viGKxW9a0a7oPx7ChVTBiRE5YbnMq2w0NNOTl4zjmPib9ghB3E/xVo2WL+FD4H52x4XPofR/1MR 3jU+MXa8pFdo30zn2hVPBSVMMK3pQyH9maDRNvIfwDpRHV2oFsxqFBlir8WrRwJ0gLwhYsUIVGX TA1urftFacJ40aDvmovUiznz5erlMV2KQF3Pc2LDtrH/270lnh8au33MiQ1yQai3DTgJzwpLyJ9 1tpH//8V2cCcCrPvIOmomFJduqswQJuVbr6JxvUFRBpGVqlGcd5VRCDSxqzGQ== X-Received: by 2002:a05:600c:6384:b0:4a1:7741:ec43 with SMTP id 5b1f17b1804b1-4a18e4b8966mr159157835e9.26.1791803904585; Mon, 12 Oct 2026 04:18:24 -0700 (PDT) Received: from localhost (p200300f65f19a904ade4f69ba751c34c.dip0.t-ipconnect.de. [2003:f6:5f19:a904:ade4:f69b:a751:c34c]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4a18bb68abfsm311754435e9.0.2026.10.12.04.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2026 04:18:21 -0700 (PDT) Date: Mon, 12 Oct 2026 13:18:21 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Laurentiu Palcu Cc: Ying Liu , Frank Li , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-clk@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v10 5/9] drm/imx: Add support for i.MX94 DCIF Message-ID: References: <20261006-dcif-upstreaming-v10-0-bcfb28de0aae@oss.nxp.com> <20261006-dcif-upstreaming-v10-5-bcfb28de0aae@oss.nxp.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cdga4qrbhoxcfsbx" Content-Disposition: inline In-Reply-To: <20261006-dcif-upstreaming-v10-5-bcfb28de0aae@oss.nxp.com> --cdga4qrbhoxcfsbx Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v10 5/9] drm/imx: Add support for i.MX94 DCIF MIME-Version: 1.0 On Tue, Oct 06, 2026 at 12:22:00PM +0000, Laurentiu Palcu wrote: > +#include > +#include Please rely on linux/platform_device.h to provide of_device_id and drop linux/mod_devicetable.h. > +static const struct of_device_id dcif_dt_ids[] = { > + { .compatible = "nxp,imx94-dcif", }, No , before } please. > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, dcif_dt_ids); > + > +static struct platform_driver dcif_platform_driver = { > + .probe = dcif_probe, > + .remove = dcif_remove, > + .shutdown = dcif_shutdown, > + .driver = { > + .name = "imx-dcif-drm", > + .of_match_table = dcif_dt_ids, > + .pm = pm_ptr(&dcif_pm_ops), > + }, I generally don't like the effort to keep the = aligned in such structures and don't recommend to even try it. Still more if it's inconsitent from the start. Just use a single space before the =. Best regards Uwe --cdga4qrbhoxcfsbx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmrMwfoACgkQj4D7WH0S /k616wgAm56cItlrtTGYJGQMifXXyKIZEbNaNh8obfuoDdC9KTfL6OrQDbETA8n/ 83AtYbd6RkC4JP7NX3SK5DlSDS/oLGmxynxAfceKMBWsUcqR4oEpGee8ZRkIFMYn BL355LaaGTv56+1iWN/tYDLNYYgKV+jwUYXmDJferAy0J0I1aTlYgEYMNoCJGGxb ciaSMXRD1FzuAb3vpJpUvWltH2+boMSdeaKoj6ZblcP2sHWtw4UWN3b1YEcrSVcl zMXusjBfMNf3S6BQ3GHOW5axtmRXjnPsqxXPCouSaEqqAahemWk+g7rA/4XF+Xax 302ZWP3FujxCr3/FFyysMyUncNGZnw== =Kiiw -----END PGP SIGNATURE----- --cdga4qrbhoxcfsbx--