From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2 RESEND] ASoC: codecs: Add support for Fortemedia FM34NE DSP
Date: Thu, 15 Oct 2026 08:34:19 +0200 [thread overview]
Message-ID: <atBzoZhsanU90pxP@monoceros> (raw)
In-Reply-To: <20261013184755.530392-3-clamor95@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 330 bytes --]
Hello,
On Tue, Oct 13, 2026 at 09:47:53PM +0300, Svyatoslav Ryhel wrote:
> +#include <linux/i2c.h>
> +#include <linux/mod_devicetable.h>
i2c_device_id is already provided by <linux/i2c.h> and
<linux/mod_devicetable.h> depends on a lot of subsystems that are not
used in this driver. So please drop the latter.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-10-15 6:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 18:47 [PATCH v1 0/2 RESEND] ASoC: codecs: Add support for Fortemedia FM34NE DSP Svyatoslav Ryhel
2026-10-13 18:47 ` [PATCH v1 1/2 RESEND] ASoC: dt-bindings: Document " Svyatoslav Ryhel
2026-10-13 18:56 ` sashiko-bot
2026-10-13 18:47 ` [PATCH v1 2/2 RESEND] ASoC: codecs: Add support for Fortemedia " Svyatoslav Ryhel
2026-10-13 18:54 ` sashiko-bot
2026-10-15 6:34 ` Uwe Kleine-König [this message]
2026-10-15 7:45 ` Svyatoslav Ryhel
2026-10-13 18:49 ` [PATCH v1 0/2 " Mark Brown
2026-10-13 18:51 ` Svyatoslav Ryhel
2026-10-13 18:55 ` Mark Brown
2026-10-13 18:56 ` Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atBzoZhsanU90pxP@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=broonie@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox