devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Marc Zyngier <maz@kernel.org>, Thomas Gleixner <tglx@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Sascha Bischoff <sascha.bischoff@arm.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: interrupt-controller: gicv5: Relax IRS properties constraints
Date: Thu, 15 Oct 2026 12:50:38 +0200	[thread overview]
Message-ID: <atCv_t_KPJ23UAhJ@red-moon> (raw)
In-Reply-To: <20261015-gicv5-irs-no-cpus-v1-1-d4b337b7f000@kernel.org>

On Thu, Oct 15, 2026 at 10:20:25AM +0200, Lorenzo Pieralisi wrote:
> An IRS is architecturally allowed to be stand-alone (ie with no direct
> CPU connection).
> 
> Relax "cpus" and "arm,iaffids" properties constraints allowing a standalone
> IRS configuration.
> 
> Fixes: 7d7299bd07c6 ("dt-bindings: interrupt-controller: Add Arm GICv5")
> Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Marc Zyngier <maz@kernel.org>
> ---
> I have not marked the patch for stable though I think it should go
> to stable kernels to fix the original schema. I am a bit nervous about
> making cpus and arm,iaffids optional but I don't think there is a way
> to keep them required and force them to be empty for an IRS with
> no CPU connection.

Hi Thomas, all,

I have noticed this is now queued into -tip (thanks), I would still appreciate
DT maintainers feedback though on the above and I still think that this must
go to stable kernels (I have not tagged the patches CC: stable as mentioned in
the cover letter but I believe the Fixes: tag will do ? If not I can send
them myself anyway).

Thanks,
Lorenzo

> ---
>  .../devicetree/bindings/interrupt-controller/arm,gic-v5.yaml     | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v5.yaml b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v5.yaml
> index 86ca7f3ac281..b901e4288816 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v5.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v5.yaml
> @@ -120,13 +120,14 @@ patternProperties:
>  
>        cpus:
>          description:
> -          CPUs managed by the IRS.
> +          CPUs managed by the IRS. Omit it if the IRS has no associated CPUs.
>  
>        arm,iaffids:
>          $ref: /schemas/types.yaml#/definitions/uint16-array
>          description:
>            Interrupt AFFinity ID (IAFFID) associated with the CPU whose
>            CPU node phandle is at the same index in the cpus array.
> +          Omit it if the IRS has no associated CPUs.
>  
>      patternProperties:
>        "^its@[0-9a-f]+$":
> @@ -210,12 +211,14 @@ patternProperties:
>            - reg
>            - reg-names
>  
> +    dependencies:
> +      cpus: [ "arm,iaffids" ]
> +      arm,iaffids: [ cpus ]
> +
>      required:
>        - compatible
>        - reg
>        - reg-names
> -      - cpus
> -      - arm,iaffids
>  
>  additionalProperties: false
>  
> 
> -- 
> 2.53.0
> 

  reply	other threads:[~2026-10-15 10:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15  8:20 [PATCH 0/2] irqchip/gic-v5: Fix standalone IRSes OF driver probe and DT bindings Lorenzo Pieralisi
2026-10-15  8:20 ` [PATCH 1/2] dt-bindings: interrupt-controller: gicv5: Relax IRS properties constraints Lorenzo Pieralisi
2026-10-15 10:50   ` Lorenzo Pieralisi [this message]
2026-10-15  8:20 ` [PATCH 2/2] irqchip/gic-v5: Fix standalone IRSes OF probe Lorenzo Pieralisi
2026-10-15  9:40 ` [PATCH 0/2] irqchip/gic-v5: Fix standalone IRSes OF driver probe and DT bindings Sascha Bischoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atCv_t_KPJ23UAhJ@red-moon \
    --to=lpieralisi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=robh@kernel.org \
    --cc=sascha.bischoff@arm.com \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).