From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6399A3BF68F for ; Sat, 17 Oct 2026 16:42:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792255371; cv=none; b=qYrO/6b0baZ7ZC5YFAP57nnUkeLt/VGGbB4LCV5Ay6XIpexBZPJDvtYfPMRWpzQjOaVE68Snu+FMMLbk8D/KIYMJ4MZGm7SuNj3foRA3P7VgOHjB/hn54DDNeFRxD30auLFxVAixR3HKjbDJMvrPN4PocDge+v5z2XImcm4jLPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792255371; c=relaxed/simple; bh=oqtbq2GGeLimTwMiPXXLtV6CRd56cCRXZHus+yXgxlk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i2ehlq/zkOmOlIwt6pixstvzWx8NFIqMgXscUepm+CiAwrocprHEXVw3XL6Ac2XBlVody0U98TyqZn2u1k7ggv7xyZkCWHavP0ePUEEWHaPJiTS/S8dX0h4mbMk7XjTeHIgR/v9sBrV37wAcCLVCtlxFflQXddI4QYC50cY9Eow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lNhoZ5Km; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V0xBkvDV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lNhoZ5Km"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V0xBkvDV" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69HGA1Sk2598752 for ; Sat, 17 Oct 2026 16:42:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=A5QXkyLgqve2yg7aR0QbgBy6 tWTAd+S8xlmq02cu4VU=; b=lNhoZ5KmND8CPcI2ztJrmEz30rkXHlfA6ZXPZ/BF dIjaldaBjswQDQz152ahMBvv8elLhUYIikte8R33fvDM1XFYB4bJJwxbmkydvHs9 eShIPCBWf8E5pwxIyBHGeuDQy6qdqbdVggs0w6DviKRSBV4mr+P3cTJTp4wdY74Z 5KS3ymg6PgRQRKbX/+YVIu7Re+hZZAA+q5SytRzeNXF0f5SCG5w6ckx/tUicRxJW NwxJhIQeClRVZ0OtvWLuWHL0rqEzv6Gfy7aqB1TktkhdKtYwuruOrhAkDsgnYJJ5 WmRvDQrRAWN6umuhYE7m35Y2hOg40tfgMs8wZ1wwrVlYWw== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hbxqfsnpk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 16:42:49 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-35cbea41088so1356013eec.1 for ; Sat, 17 Oct 2026 09:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792255369; x=1792860169; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=A5QXkyLgqve2yg7aR0QbgBy6tWTAd+S8xlmq02cu4VU=; b=V0xBkvDVCCZqAGH5Cr5IQ5SYSrweZgJGMCJZvlp4QOyF6LOvZCLk0KmLNig/hEyhrw MTIFPCwh8UR2AfCntw/X1ueFjqSGe3JzV1mBX7Drs7x1RLU9J7Eqo0a9r+hXl+78JgjR 63IcXgV1rqh/OGfN5y6uFtzKgYGFWXEx6XR5zd4gibZ9VA1hvVbUbozZN8S1ArJGRzvD bPJVqnY2HjRZZgCJoXsaaTHK6XHahraEPJnupEddg6BMRzy0fRb45Xh7YNaXZS9LMc99 qprDVLlQK1FKDUplcMfYBVeuzut4iCupCPn53iHAKBW5mCWm31x1iSU3+gxH7j89ARph mFrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792255369; x=1792860169; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A5QXkyLgqve2yg7aR0QbgBy6tWTAd+S8xlmq02cu4VU=; b=Kh7JP6PUZAhWZV9aGOlZinZ/lS9rHz9ocEI4WpI6iNV125HrSOzPJpYyI0ndEWnwO+ Qbn/m5w88d90AJ21tIa3o9DneqnVwKMDmcqfeE5d5oP97ApKfbpRYgqqsmsNCg/GGLZN Rs2VVsAk68ECy/ikrr9l0PD/+gh5AJdke9Hv22y0yaRFlOpFbZMeJ6E8QdkK3a/MFzal mqHzfj9h7z65JfBO78C7fvwDCfP9CqEz+ZlBx4fLncRl3RxTYnioTkdvSMxm1opvXPgo 5CNDFQbCYSrpfdSjas6RAnojchKj+I8MXDyhzvB86CIwYzn93Tyc5hTtGmXFnN7LcH8U 3MBQ== X-Forwarded-Encrypted: i=1; AKwUvBzaONP0cVKhJBjmb0jXgwUaurmInyNkUj+lQYtWGwzZb5u+yRyiedP6njdphDKNeTAESze5fSqeIamz@vger.kernel.org X-Gm-Message-State: AFq9FYJU+ukskHpQX5oDQSsBR/9a0AiZDdYEoRQhEQgL37rI2I7QRNsZ P1Tv8YcV0npW4dY0kSGiiRWWm45t+eha0ywA8UMhJu5/AxzttewgUnDrpA6sphfyh8SX5rCQv6a Ztpjmw8uKrY8qkQEfmX+8rAmueLvjxDgmincM4TeH3I/HuVW3Gu4KQr2rE6NNq389 X-Gm-Gg: AYBFou2z7xTa9UttLtDfjSQtUzA8AOe/aBDwtroVh0ZoRTxLReD0QeMKngtOsUPCGTj 8h0aMFPAxTvvGVhGjy4AU4+4dTP+6+5lckl4O1gOYK7gDmdVLdV9K6LD12Eri0E2EOhVzil7r1Y rMj7jvgYahzgzpIXF6IUOxMnWLE2oGM+J99WgauNCFXh8rwOPb3BFTpCUZTzQPTh28cObsgwxTW JhHpyrtO7s3xaSLczhluVRI9L7RgCwKHAsqafW7Kg5+PQ9oJhOvqfEQkvPkw2aFgR29E1C/e5ov n0BgEHoYgvMt83j17h14s28dDUv9K8S/ejGHLcCKlITbdLyk3NuHcRMotnPofVDjG4EeP70LvXJ B7Hqd7m5sxKMRiQ== X-Received: by 2002:a05:7022:7e89:b0:14d:ef19:246f with SMTP id a92af1059eb24-18513e7b18emr4689755c88.45.1792255368770; Sat, 17 Oct 2026 09:42:48 -0700 (PDT) X-Received: by 2002:a05:7022:7e89:b0:14d:ef19:246f with SMTP id a92af1059eb24-18513e7b18emr4689692c88.45.1792255368055; Sat, 17 Oct 2026 09:42:48 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-183190aa7bbsm15041602c88.5.2026.10.17.09.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 09:42:47 -0700 (PDT) Date: Sat, 17 Oct 2026 22:12:32 +0530 From: Mohd Ayaan Anwar To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Eric Dumazet , Radu Rendec , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski Subject: Re: [PATCH net-next v16 5/7] net: stmmac: qcom-ethqos: reuse the address of ethqos_emac_driver_data Message-ID: References: <20261014-qcom-sa8255p-emac-v16-0-0266c2ead980@oss.qualcomm.com> <20261014-qcom-sa8255p-emac-v16-5-0266c2ead980@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261014-qcom-sa8255p-emac-v16-5-0266c2ead980@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfXz3GX46yDAt2S nXxMX0BT+wGSzop9bpyvmCi25QmrmlsfQQos0onucgqRh9quiXAWB+/x64NMVSucwYWJ9UfTUVs cUgJuGJZiO+kjv+EbjTgmbaKO5brm9k= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX7HsV4esDW/hH QOGe0DhWV3fduQlG/YLAXpgJuAdSRfSf89hJywogfYkEN2hnl697YEvZXCjL7KDFPn5JWcpncMa 9q8Fa0bovVWsAu5DSJsYMxxqZQZvHK9K33cvFxRl99Zbo/3kB4oxG3QNjvsV0eG9htdjDLOPmZm rtNenVXobul0VAjtKtFwrCLcCReNpcHyQFMKKD99JFBKY4cLPYUSVglgYdIg1WNJpFIRE/guab0 Odd3KfbDbR410QG04NnhfwM7DVqNbcDTzJPtIo9ITK6+z/Lnci1mL5O7mBhJZb12Tt8sJ3Xzzr1 tUQfvpm/jH1dT88bmGeNd61s6wvbm+4Qj9fu/xczL1fxcj1CUjRc16x1YA0EZ2+7DdDEFtgFfrw +LUYFgoBo4UQ+IVK28pk17sve3XYU+0b0+Kfld3yOmfeQecvlUO9ummmpgvQGLn/GKAgonJBxjl rRTHXpkjhv0mWe1db0A== X-Proofpoint-ORIG-GUID: EdKFurAXrlWxwa2va5rnzJQ13MvrlwDU X-Proofpoint-GUID: EdKFurAXrlWxwa2va5rnzJQ13MvrlwDU X-Authority-Analysis: v=2.4 cv=RYMFmFtv c=1 sm=1 tr=0 ts=6ad3a589 cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=XX1oeNa5M8xgm1Jp0F0A:9 a=CjuIK1q_8ugA:10 a=zZCYzV9kfG8A:10 a=bBxd6f-gb0O0v-kibOvt:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_05,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 bulkscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170066 On Wed, Oct 14, 2026 at 02:36:44PM +0200, Bartosz Golaszewski wrote: > Instead of needlessly copying the fields of ethqos_emac_driver_data into > struct qcom_ethqos, just use the address of the former as a reference. > It's .rodata after all. This is done in order to avoid having either two > calls to of_device_get_match_data() or having to extend the latter with > another field when adding support for SCMI. > > Signed-off-by: Bartosz Golaszewski > --- After testing it on a couple of legacy non-SCMI boards, I did not find any issues with this patch, so: Tested-by: Mohd Ayaan Anwar Reviewed-by: Mohd Ayaan Anwar Ayaan