From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A914A48381E for ; Mon, 19 Oct 2026 06:57:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792393078; cv=none; b=sbmb9lvXHI66fTITlscsr67ndpXLNTnk0mvmaSM0oPK6t+ZB/kDSVNK5XYulPEb9RZSRUnDhjADws1kC2fxpOiYuYFmBKfrolAPMY6BXrvKnNDWg2Leq1sfQyBttQmYF54b490E8XX4FiNd5z11Ki6neOtzDOdasfv2b45MS+NM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792393078; c=relaxed/simple; bh=iUN7PS0couYMcfpfwhade+kiv7G0xPySdLn5zBMJxjU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jgsmtwUa0m10FRw0jwW000IwH1Q6PAMle8WtuMhYQThfW3LEeRvOD+cHy0FC0QAgsSx0+QMF18BVE1KTNMlUdRiI8Z9BT2Ds7Q47/02V6GCWHCO+D0fwMPglbbJhA0zmUrxneu/gdxRXJMp+NgJzIPfgsEFhlZy2vySBcb5on78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Gla6Mmvp; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Gla6Mmvp" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4a140e7405dso14932725e9.3 for ; Sun, 18 Oct 2026 23:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1792393075; x=1792997875; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=JxfSK5IZ5O0IFCRPnkbx2AQWRlFboHtFQ8aMJNkMXv0=; b=Gla6MmvpNAXYtrsQEwNChSPo3bsSA508kW9imXv7qSbLZRJZPu5xYkYDl7509P5En1 j8yxDBnAjUKFcZstRhuTfOk16M36BDED2koQZROUGZmmrfaPDgnF7z3Mf9aAGP6tIOsO 6IT9RniByFkcDVBxj/wTT1HO9Jj42OPVk3dEg1w23ODLk6hmK2l9tEM8qB8Hj1Of0OXC j6dde1bfDSl6rsLmegP/extpE6NPBtJmrNy/qhKWSAe/0YNNjvu39eH6O1q45Zbc8L98 PvDUc/YR/8/KpE/xw2Qh4j0UPlKizof5dBNGb9dwEUNqXFmz8eXsY2p8h0VmCn4+sEPz KEbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792393075; x=1792997875; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JxfSK5IZ5O0IFCRPnkbx2AQWRlFboHtFQ8aMJNkMXv0=; b=IsJZoSPCEfad0jaK6ZJ/drUB3/MIbipIx9MHro4M9Y0gs7GODOZnX/aux+CoLoEe+a 6g37PQvCn84SL9ChCBH1yhR2wmcZy0Pt8XpR/pzdS1bw6bDylDUxJWAuWDgLNDfC1Got G4REVGzxbl1ebUkuXqKTV5YqVQRU1mGqeRZsog+Tjkj16v6vBymy81B0E6VWQ73+OAL3 KSz2iQeU27K4tQFkHrHsRBgal4Ks2scsvEfi9EzEzKwOhyymjFi1FLYFENPrSBzrKSE9 7eHYjznKsL+x3pVciPnKvBAn8DxaDTRZ3sESfF5Tz6S+jpAqizz8naBWCi0XSTWN4QjI r1lw== X-Forwarded-Encrypted: i=1; AKwUvByNjaRhbMZtMqzuBAQziw/7K5enR5yapIRZ4VAwGtYwhpdafJqqZJn1XmJbYvmZiub7BbAYJqEtx4I6@vger.kernel.org X-Gm-Message-State: AFq9FYJPQSwO5aypGJK6A4vQx43Y43npZI8nzYiem0kKeuSOLwoW/LL0 Q7SQVPw6Zlo8eNL1X6LHc4dp6alqa8C8XARq5PZVuyWjf1HZ7BJByDEHD/lGUIq+VSI= X-Gm-Gg: AYBFou2mOZFS6GugtzHcNUFQ2KLAPZwMB6G6YyQJwu2TwsUV/rpEdYM1tBIJh9r/G+2 PWsxe9Ykbd0vcN4JVokOUBBITqpbhxWJq+aWAEt7fr9rf3xCjcAKpFuaETwVQ6Cn6wpOz9e5hzx svxkqC1QKJg3pdWkCHHfjxHSV2Iet2P+rOKTOb1SI7Fxh0UFAmotAGNtdoA8Sxuo78UJ+HCYOXg ocbj9CLtj1OOjWab9CithcIkKIP+Yye7m1k3lkl5s5M6CdRyiMgHkQbnPqrtfOinljyS1Tut8f5 L07zDeSK4vUCR0WOo0R8bmogFjcPXkqezQz02zj+3vDLeqRl0W7ql74cxRz3Of2y1Vt//SAng+m Oy6mGGx4lozzin8zGSJcrdF1uavqIvPgy6zrXSJMF5HjQR0vaNPXBEDhW6kzMWYpQNp9L9zxsze v9vjyC+PYnsq3T618M1Xe4tsH5bFjKko1k4zmguohzBLAQs3LYRfv3jk6RPAEz1HY5Qw4K4ozxR SfOHsHFsX4yoAtxs9eeWbGArA5AD5YC8Adwniy9OHqcDAeAnPxCEbgxSLgRew== X-Received: by 2002:a05:600c:6992:b0:4a1:d7c3:d3d with SMTP id 5b1f17b1804b1-4a1d7c30dd2mr130711935e9.10.1792393074742; Sun, 18 Oct 2026 23:57:54 -0700 (PDT) Received: from localhost (p200300f65f19a9041674bacf58593a35.dip0.t-ipconnect.de. [2003:f6:5f19:a904:1674:bacf:5859:3a35]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4a1ce3302b5sm172374155e9.4.2026.10.18.23.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 23:57:53 -0700 (PDT) Date: Mon, 19 Oct 2026 08:57:52 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Luka Panio Cc: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Douglas Anderson , linux-input@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] Input: edt-ft5x06 - add SPI transport and FT8722 support Message-ID: References: <20261017140827.290666-1-lukapanio@gmail.com> <20261017140827.290666-7-lukapanio@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6wnpoaklsckkwk77" Content-Disposition: inline In-Reply-To: <20261017140827.290666-7-lukapanio@gmail.com> --6wnpoaklsckkwk77 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH 6/7] Input: edt-ft5x06 - add SPI transport and FT8722 support MIME-Version: 1.0 Hello, On Sat, Oct 17, 2026 at 04:07:54PM +0200, Luka Panio wrote: > +#include > [...] > +#include already provides both of_device_id and spi_device_id. So please drop which pulls in a lot of unneeded dependencies. > [...] > +static const struct spi_device_id edt_ft5x06_spi_ids[] = { > + { "ft8722-ts", (kernel_ulong_t)&edt_ft8722_data }, Please use a named initializer here. > + { } > +}; > +MODULE_DEVICE_TABLE(spi, edt_ft5x06_spi_ids); Best regards Uwe --6wnpoaklsckkwk77 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmrVv2wACgkQj4D7WH0S /k7AvAf7BT3eOJwLMHu3yGXN3CuhrApIng3UUqEXnJLyTpbAVT3F/gG90raumnhq UGl7PXQ3EXG3LCgRIkwqNQfJTBdwdqDdWo3Lv66bmIy10YRgTHNn3eSn7k/D7lXO xyJhy7u785DrUyBAk7c9VgnpQ6haEx90dQDrvf61edI7+BOKLs+oAkHXwEtgtmkd NV1e9kIbW6JTHGAlsYSW7YIQKDy38zhlkXyu/L/A+oBVUHzUss5JOvOuekGxzdQb R4iPyPcrOU1VRxmAckvzHVP8imXWy7kP1HTL+oPtjkyKR7w8eAY0Vow8hdLsbYvp TyIOSLT9Njcket/gjkcISbC+l1pDkQ== =k8s7 -----END PGP SIGNATURE----- --6wnpoaklsckkwk77--