Re: [PATCH v4 04/16] media: sony-starvis2: Parameterise the configuration to allow for other models

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Dave,

On Wed, Oct 21, 2026 at 02:59:16PM +0100, Dave Stevenson wrote:
> > >       starvis2->hblank = v4l2_ctrl_new_std(ctrl_hdlr, &starvis2_ctrl_ops,
> > >                                            V4L2_CID_HBLANK, hblank, max_hblank,
> > > -                                          IMX678_PIX_PER_CLK, hblank);
> > > +                                          starvis2->variant->pix_per_clk,
> 
> And that IMX678_PIX_PER_CLK (8) is changed to
> starvis2->variant->pix_per_clk, which matches the change above.
> 
> v4l2-ctl --list-ctrls-menu with imx585 is giving me
>             horizontal_blanking 0x009e0902 (int)    : min=544
> max=520424 step=8 default=544 value=544 flags=has-min-max
> and with imx662 gives me
>             horizontal_blanking 0x009e0902 (int)    : min=1034
> max=194669 step=3 default=1034 value=1034 flags=has-min-max
> 
> Are you seeing somewhere else where the step is set incorrectly?

I guess that must have been somewhere else indeed. You're right, there's no
bug here. But probably somewhere else there is one. There are too many
sensor drivers. :-(

-- 
Regards,

Sakari Ailus