From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux@analog.com
Subject: Re: [PATCH v4 3/3] iio: adc: add driver for the MAX34417 Four-Channel High Dynamic Range Power Accumulator
Date: Thu, 29 Oct 2026 14:58:57 +0200 [thread overview]
Message-ID: <auNDEQXkQ89RHjc4@ashevche-desk.local> (raw)
In-Reply-To: <d2e93ac7-1689-4e06-a694-d0a95d05a400@linaro.org>
On Wed, Oct 28, 2026 at 04:26:01PM +0100, Neil Armstrong wrote:
> On 10/28/26 16:06, Andy Shevchenko wrote:
> > On Wed, Oct 28, 2026 at 02:19:06PM +0100, Neil Armstrong wrote:
...
> > > +static bool max34417_volatile_reg(struct device *dev, unsigned int reg)
> > > +{
> > > + switch (reg) {
> > > + case MAX34417_DID_REG:
> > > + return false;
> > > + default:
> > > + /* MAX34417_CONTROL_REG field OVF is volatile */
> >
> > Why not add a case instead of a comment?
>
> The case is handled by the default, the comment is here to
> explain why MAX34417_CONTROL_REG is considered as volatile.
Still, having an explicit case is better, just add a comment about the field.
> > > + return true;
> > > + }
> > > +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-29 12:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 13:19 [PATCH v4 0/3] iio: adc: add support for the MAX34417 Four-Channel High Dynamic Range Power Accumulator Neil Armstrong
2026-10-28 13:19 ` [PATCH v4 1/3] dt-bindings: iio: add: document " Neil Armstrong
2026-10-28 17:50 ` Conor Dooley
2026-10-28 13:19 ` [PATCH v4 2/3] unaligned: introduce be56 unaligned accessors Neil Armstrong
2026-10-28 13:54 ` Andy Shevchenko
2026-10-28 13:19 ` [PATCH v4 3/3] iio: adc: add driver for the MAX34417 Four-Channel High Dynamic Range Power Accumulator Neil Armstrong
2026-10-28 13:33 ` sashiko-bot
2026-10-28 15:06 ` Andy Shevchenko
2026-10-28 15:26 ` Neil Armstrong
2026-10-29 12:58 ` Andy Shevchenko [this message]
2026-10-28 18:12 ` Victor Chernyakin
2026-10-29 13:04 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auNDEQXkQ89RHjc4@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox