Re: [PATCH v7 08/15] drm/imx: dc: Add DPR channel support

[Liu Ying <victor.liu@nxp.com>]

On Thu, Oct 29, 2026 at 11:31:45AM +0200, Laurentiu Palcu wrote:
> On Mon, Oct 26, 2026 at 06:05:13PM +0800, Liu Ying wrote:

[...]

> > diff --git a/drivers/gpu/drm/imx/dc/dc-dprc.c b/drivers/gpu/drm/imx/dc/dc-dprc.c
> > new file mode 100644
> > index 000000000000..a8ddcd117a52
> > --- /dev/null
> > +++ b/drivers/gpu/drm/imx/dc/dc-dprc.c
> > @@ -0,0 +1,522 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright 2025 NXP
> > + */
> > +
> > +#include <linux/bitfield.h>
> > +#include <linux/bits.h>
> > +#include <linux/cleanup.h>
> > +#include <linux/clk.h>
> > +#include <linux/delay.h>
> > +#include <linux/device.h>
> > +#include <linux/firmware/imx/svc/misc.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/list.h>
> > +#include <linux/module.h>
> 
> You can remove the include above. You're not using anything from module.h
> AFAIS.

Done.

> 
> [...]
> 
> > +
> > +bool dc_dprc_rtram_width_supported(struct dc_dprc *dprc, unsigned int width)
> 
> You could probably get rid of dprc as well. You're not using it.

dc_plane_check_dprc() in patch 15 uses it, so it cannot be removed.

[...]

> > +	ret = of_property_read_u32(np, "fsl,sc-resource", &dprc->sc_resource);
> > +	if (ret) {
> > +		dev_err(dev, "failed to get SC resource %d\n", ret);
> > +		return ret;
> 
> You could probably use 'return dev_err_probe()', to be consistent with the
> other places where you used the same.

Will do.  Also, will use dev_err_probe() in case devm_request_irq() fails.

-- 
Regards,
Liu Ying