Devicetree
 help / color / mirror / Atom feed
From: Jelly Jia <Jelly.Jia@cixtech.com>
To: Frank Li <Frank.li@oss.nxp.com>
Cc: sashiko-reviews@lists.linux.dev, devicetree@vger.kernel.org,
	dmaengine@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
	vkoul@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v5 2/5] dmaengine: arm-dma350: Add slave and cyclic transfer support
Date: Thu, 5 Nov 2026 16:42:57 +0800	[thread overview]
Message-ID: <auxBkRRHMaeN4wJq@ubuntu> (raw)
In-Reply-To: <auuJKyC91CrYUAY1@SMW015318>

Hi Frank,

> Please check both issues.

I've checked both and made the following changes locally:

1. Initialize dch->req to U32_MAX, and reset it and clear dch->sconfig
   when channel resources are freed. This lets the existing request
   range check reject slave/cyclic preparation without a request
   assignment. Valid request line 0 and memcpy/memset remain unaffected.
   Request/configuration state is retained across terminate_all().

2. Keep clearing dch->desc on error, since the descriptor is handed to
   virt-dma for completion or termination. Instead, prevent
   d350_start_next() from starting another transfer while the channel
   is in DMA_ERROR. This preserves the failed cookie's status and
   residue until termination. Also reset the channel status in
   terminate_all() even when dch->desc is NULL, so the channel can be
   used again after termination and synchronization.

I've tested the updated tree on Sky1 and will include both fixes
in the next revision.

Best regards,
Jelly

  reply	other threads:[~2026-11-05  8:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 12:44 [PATCH v5 0/5] dmaengine: arm-dma350: Add slave support and Sky1 integration Jelly Jia
2026-11-04 12:44 ` [PATCH v5 1/5] dmaengine: arm-dma350: Fix source trigger bit Jelly Jia
2026-11-04 12:44 ` [PATCH v5 2/5] dmaengine: arm-dma350: Add slave and cyclic transfer support Jelly Jia
2026-11-04 13:08   ` sashiko-bot
2026-11-04 19:36     ` Frank Li
2026-11-05  8:42       ` Jelly Jia [this message]
2026-11-04 12:44 ` [PATCH v5 3/5] dt-bindings: dma: arm,dma-350: Document optional clocks and resets Jelly Jia
2026-11-04 19:34   ` Frank Li
2026-11-05  8:42     ` Jelly Jia
2026-11-04 12:44 ` [PATCH v5 4/5] dmaengine: arm-dma350: Support integration " Jelly Jia
2026-11-04 19:37   ` Frank Li
2026-11-04 12:44 ` [PATCH v5 5/5] arm64: dts: cix: Describe the Sky1 FCH DMA-350 integration Jelly Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auxBkRRHMaeN4wJq@ubuntu \
    --to=jelly.jia@cixtech.com \
    --cc=Frank.Li@kernel.org \
    --cc=Frank.li@oss.nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox