Devicetree
 help / color / mirror / Atom feed
From: "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: "jk@codeconstruct.com.au" <jk@codeconstruct.com.au>,
	Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@codeconstruct.com.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v33 0/5] Add ASPEED AST2600 I2C controller driver
Date: Wed, 18 Nov 2026 10:48:12 +0200	[thread overview]
Message-ID: <av1mTEtWCf8zFbjp@ashevche-desk.local> (raw)
In-Reply-To: <TYZPR06MB79202A00572E81CBC29399F4F27A2@TYZPR06MB7920.apcprd06.prod.outlook.com>

On Wed, Nov 18, 2026 at 08:14:51AM +0000, Ryan Chen wrote:
> Hi Andy,
> 
> This patch series has been stable in our testing on AST2600 hardware,
> and we have also received positive feedback from customer testing.
> The issues identified by Sashiko have also been addressed.
> I plan to rebase the series onto the latest upstream kernel and submit v34.
> Before doing so, I would appreciate your feedback on whether there are any
> remaining concerns or blockers that we should address.
> 
> If there are no outstanding issues, I hope the series can be considered for
> merging after the next review.
> 
> Thanks for your time and support.

Are you asking me or Andi Shyti?
If it was to me, I have no time for this right now, sorry.

> > Subject: [PATCH v33 0/5] Add ASPEED AST2600 I2C controller driver
> > 
> > This series adds support for the AST2600 I2C controller “new register set”
> > implementation.
> > 
> > The AST2600 I2C controller introduces a revised register layout which
> > separates controller and target functionality into distinct register blocks, and
> > extends clock divider configuration and packet-based transfer support
> > compared to the legacy mixed register layout used on earlier ASPEED SoCs.
> > 
> > The current driver implementation for the AST2600 I2C peripheral is through
> > the hardware's "compatibility mode", which exposes a register set that
> > matches the previous generation hardware (AST2500 and earlier).
> > 
> > Instead, add a driver that works in new-register-set mode, to allow the new
> > features, and will provide support for future hardware that will not implement
> > compatibility mode.
> > 
> > In order to support the new mode, we need a DT binding change to reflect the
> > reference to the global register set. Since the binding still represents the same
> > (AST2600 SoC) physical hardware, we continue to use the existing compatible
> > string of "aspeed,ast2600-i2c-bus".
> > 
> > However: since we're changing semantics for an existing binding, we allow
> > backwards compatibility by selecting on presence/absence of the newly-added
> > properties, and fall back to the old driver (ie., in compatibility mode) when we
> > detect a DT using the old binding spec.
> > 
> > Specifically:
> > 
> > - ast2600-i2c-bus nodes that provide the `aspeed,global-regs` property
> >   (present in the new binding and absent in the legacy binding) will be
> >   successfully probed by the new driver
> > 
> > - ast2600-i2c-bus nodes without `aspeed,global-regs` continue to use the
> >   existing driver (in legacy register mode), ensuring that platforms
> >   with the current DTBs remain functional

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-18  8:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23  1:15 [PATCH v33 0/5] Add ASPEED AST2600 I2C controller driver Ryan Chen
2026-06-23  1:15 ` [PATCH v33 1/5] dt-bindings: i2c: Split AST2600 binding into a new YAML Ryan Chen
2026-06-23  1:15 ` [PATCH v33 2/5] i2c: aspeed: Read clock-frequency via i2c_parse_fw_timings() Ryan Chen
2026-06-23  1:25   ` sashiko-bot
2026-06-23  1:15 ` [PATCH v33 3/5] dt-bindings: i2c: ast2600-i2c.yaml: Add global-regs properties Ryan Chen
2026-06-23  1:15 ` [PATCH v33 4/5] i2c: ast2600: Add controller driver for AST2600 new register set Ryan Chen
2026-06-23  1:28   ` sashiko-bot
2026-06-23  3:01     ` Ryan Chen
2026-06-23  1:15 ` [PATCH v33 5/5] i2c: ast2600: Add target mode support Ryan Chen
2026-06-23  1:28   ` sashiko-bot
2026-06-23  2:55     ` Ryan Chen
2026-10-13  5:49 ` [PATCH v33 0/5] Add ASPEED AST2600 I2C controller driver Ryan Chen
2026-11-18  8:14 ` Ryan Chen
2026-11-18  8:48   ` andriy.shevchenko [this message]
2026-11-18  8:53     ` Ryan Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av1mTEtWCf8zFbjp@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=benh@kernel.crashing.org \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jk@codeconstruct.com.au \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=ryan_chen@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox