Devicetree
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: longzhao@ambarella.com
Cc: Bartosz Golaszewski <brgl@kernel.org>,
	linux-gpio@vger.kernel.org, Linus Walleij <linusw@kernel.org>,
	Michael Walle <mwalle@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Mika Westerberg <westeri@kernel.org>,
	devicetree@vger.kernel.org, Long Zhao <zl020895@163.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v15 03/14] gpio: regmap: remove gpiochip before tearing down irqchip
Date: Thu, 19 Nov 2026 09:40:14 +0200	[thread overview]
Message-ID: <av6n3oNVl2pyeLBK@ashevche-desk.local> (raw)
In-Reply-To: <20261118-cv75-gpio-v15-3-e3c563673fe1@ambarella.com>

On Wed, Nov 18, 2026 at 03:42:20PM +0800, Long Zhao via B4 Relay wrote:
> 
> gpiochip_remove() calls acpi_gpiochip_free_interrupts() and
> gpiod_free_irqs(). Both still need the irq domain.
> regmap_del_irq_chip() removes that domain, so remove the
> gpiochip first.

So, AFAIR Michael rose the question that this patch makes the unregister flow
not reverse symmetrical to the register one. I took a look at this and I can
say that this is a bit twisted. The pure creation part is independent, but
to function it requires GPIO chip to be instantiated. So, yeah, this patch
is a bit controversial. Let me see what we can do here.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-19  7:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  7:42 [PATCH v15 00/14] gpio: add Ambarella CV75 PL061 support Long Zhao via B4 Relay
2026-11-18  7:42 ` [PATCH v15 01/14] dt-bindings: gpio: pl061: add Ambarella CV75 variant Long Zhao via B4 Relay
2026-11-18  7:42 ` [PATCH v15 02/14] gpio: regmap: add GPIO_REGMAP_QUIRK_SET_AFTER_DIR Long Zhao via B4 Relay
2026-11-18  7:57   ` sashiko-bot
2026-11-18  7:42 ` [PATCH v15 03/14] gpio: regmap: remove gpiochip before tearing down irqchip Long Zhao via B4 Relay
2026-11-19  7:40   ` Andy Shevchenko [this message]
2026-11-18  7:42 ` [PATCH v15 04/14] gpio: pl061: drop redundant pending check in the IRQ handler Long Zhao via B4 Relay
2026-11-18  7:42 ` [PATCH v15 05/14] gpio: pl061: convert register access to regmap Long Zhao via B4 Relay
2026-11-18  7:42 ` [PATCH v15 06/14] gpio: pl061: use IRQ_TYPE_LEVEL_MASK and IRQ_TYPE_EDGE_BOTH Long Zhao via B4 Relay
2026-11-18  7:42 ` [PATCH v15 07/14] gpio: pl061: use cleanup helpers for locks Long Zhao via B4 Relay
2026-11-18  7:42 ` [PATCH v15 08/14] gpio: pl061: keep the parent device in a local Long Zhao via B4 Relay
2026-11-18  7:42 ` [PATCH v15 09/14] gpiolib: request ACPI GPIO events for external IRQ domains Long Zhao via B4 Relay
2026-11-19  7:41   ` Andy Shevchenko
2026-11-18  7:42 ` [PATCH v15 10/14] gpio: pl061: switch data path to gpio-regmap Long Zhao via B4 Relay
2026-11-18  8:35   ` sashiko-bot
2026-11-18  7:42 ` [PATCH v15 11/14] gpio: pl061: add Ambarella register-layout variant Long Zhao via B4 Relay
2026-11-18  7:42 ` [PATCH v15 12/14] gpio: pl061: tidy up IRQ trigger logging Long Zhao via B4 Relay
2026-11-18  7:42 ` [PATCH v15 13/14] lib/string_choices: add str_rising_falling() Long Zhao via B4 Relay
2026-11-18  7:42 ` [PATCH v15 14/14] gpio: pl061: use string_choices helpers for IRQ trigger logging Long Zhao via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av6n3oNVl2pyeLBK@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longzhao@ambarella.com \
    --cc=mwalle@kernel.org \
    --cc=robh@kernel.org \
    --cc=westeri@kernel.org \
    --cc=zl020895@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox