From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: longzhao@ambarella.com
Cc: Arnd Bergmann <arnd@arndb.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
soc@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>,
linux-clk@vger.kernel.org, Brian Masney <masneyb@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Conor Dooley <conor+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
devicetree@vger.kernel.org, Long Zhao <zl020895@163.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 4/6] clk: ambarella: add CV75 RCT clock controller
Date: Thu, 19 Nov 2026 12:22:29 +0200 [thread overview]
Message-ID: <av7N5VMXS6OiNYrh@ashevche-desk.local> (raw)
In-Reply-To: <20261119-cv75-soc-v12-4-e5a03cca8b05@ambarella.com>
On Thu, Nov 19, 2026 at 06:13:22PM +0800, Long Zhao via B4 Relay wrote:
>
> Add a table-driven CCF driver for the CV75 root clock tree. Register
> the core PLL, AHB/APB fixed factors and UART0 composite clock, with
> osc supplied via clk_parent_data.
...
> +config CLK_AMBARELLA_CV75
> + bool "Ambarella CV75 RCT clock controller"
> + depends on ARCH_AMBARELLA || COMPILE_TEST
> + default ARCH_AMBARELLA
> + help
> + Say Y here to enable the Ambarella CV75 RCT clock controller.
Tell a bit more when it's required. For example, if it's necessary to boot the
system or if it's just a bunch of some peripheral clocks that don't affect any
basic stuff. Note, checkpatch complains if the help text is less than 3 lines.
...
> +static const struct cv75_pll cv75_plls[] = {
> + CV75_PLL(CV75_GCLK_CORE, "core", 0x000, 0x004, 0x100,
> + 0, &cv75_ccu.core),
> + CV75_PLL(-1, "pll_enet", 0x520, 0x524, 0x528,
> + 0, &cv75_ccu.enet),
> + CV75_PLL(-1, "pll_sd", 0x4ac, 0x4b0, 0x4b4,
> + 0, &cv75_ccu.sd),
> +};
Now it can occupy less LoC.
static const struct cv75_pll cv75_plls[] = {
CV75_PLL(CV75_GCLK_CORE, "core", 0x000, 0x004, 0x100, 0, &cv75_ccu.core),
CV75_PLL(-1, "pll_enet", 0x520, 0x524, 0x528, 0, &cv75_ccu.enet),
CV75_PLL(-1, "pll_sd", 0x4ac, 0x4b0, 0x4b4, 0, &cv75_ccu.sd),
};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-11-19 10:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 10:13 [PATCH v12 0/6] arm64: add Ambarella CV75 SoC support Long Zhao via B4 Relay
2026-11-19 10:13 ` [PATCH v12 1/6] dt-bindings: arm: add Ambarella CV75 platforms Long Zhao via B4 Relay
2026-11-19 10:13 ` [PATCH v12 2/6] dt-bindings: clock: add Ambarella CV75 RCT Long Zhao via B4 Relay
2026-11-19 10:13 ` [PATCH v12 3/6] arm64: add ARCH_AMBARELLA Long Zhao via B4 Relay
2026-11-19 10:13 ` [PATCH v12 4/6] clk: ambarella: add CV75 RCT clock controller Long Zhao via B4 Relay
2026-11-19 10:22 ` Andy Shevchenko [this message]
2026-11-19 10:13 ` [PATCH v12 5/6] arm64: dts: ambarella: add CV75 SoC and EVK Long Zhao via B4 Relay
2026-11-19 10:13 ` [PATCH v12 6/6] MAINTAINERS: add ARM/AMBARELLA SoC support Long Zhao via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av7N5VMXS6OiNYrh@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longzhao@ambarella.com \
--cc=masneyb@kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=soc@lists.linux.dev \
--cc=will@kernel.org \
--cc=zl020895@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox