From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.182 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795107592; b=Dh45I1u56rY5JAtXXQ7YMh8nwMlhqOTnwEIwaEzGORC+y88gBc+mk+1fSKz3vvJ41CW0 CmkLdfZNXEw5xtnqMJeZBf3Km9nyA/PAd/5LFB8pDhk1DL3+8JpNSp9glm0z8bT6jZllp aYezOEJTrydGbcn9Py0C9mYWupKIqdaQ+aBn97oxA2Yr4eZuUEJ5/ghKQIcbCyB33t2gM TYAfYD9cBZpTBAMGmBjVaYv/kY4wpkOomqFAAzJkBh3lc7xnO5rA3QAxiuFHf+Lp8bkrJ ZyVIi+FcYJTv+Jflr1MwhVAG1ZFSkE22WhL5zudus8nDZtmfWf9hYJ8JhPbuXMg3sjw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795107592; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=RJzTbt4b5o1R8Zwzsovu5HVY5FLB11k288WW5ys9/qo=; b=CaZN1kdLlQB0B2s94Zda7wIc+URBg3tyW30GF9KolaPhi5gocyCoDL6BDoHIz13g5IYk IlVvZIG+DVxatDnGzgdF0GxbBoSVcvDzRPoD0Bs2X2Nixc0ilrEZ3V9e0gk2yQ3y0PRLX 9SvJz+2IPQPCiWwaoIFirwSc4dYhpwUXc2SqU+g008lir4iqP/jv8rZe7qe3KqrMMjdee y7YQf/nYP+lKwmdk5Bpz7AYFURdLHfxchr3fhKdLsW1yqO2CvbFOVeMqiKm27uTwIAJfr woAiGEEb0mxFjwzcpP/eVa24VFZE62qeLYAO9CYXdXO6Hl+GNeXE8eZQyYXjAKQNiuQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=St+5EPMT; arc=none smtp.remote-ip=209.85.214.182 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7611B606A330 for ; Thu, 19 Nov 2026 16:59:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 7611B606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=St+5EPMT Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2e95bd1c14cso21464985ad.2 for ; Thu, 19 Nov 2026 08:59:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1795107592; x=1795712392; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=RJzTbt4b5o1R8Zwzsovu5HVY5FLB11k288WW5ys9/qo=; b=St+5EPMTj9lz9zMplsRGje+/j0VqZ3/ZiCoiTrVyK6XHh5WKimiqwWqlf+RP+O7fmL LH6aTfNlbbrMjY3gh7FBxnjjbyBRjevL3S/30nY3TvlbNrAtDK8IM1jsc2lBl/1dlppN bIAHe9vQ+OEStwYXvf0t0JKGOysMV5R9ZPyYRG/c+yGhdMyoXyrcjQgrCg5QCt04/xx/ ABqOGswIM9PJLWO0XABTM5FeC0xUGt9Sg0LdmqWaoKVHay8LbTGrzzSYRimlaQKCcDOx TVHJGkm5+zarjtkWXB8aL+AyTFgI/WeZUasL6jMsuJ5uQZz9k6d4iD+bzOsvbhTwo58g fWvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795107592; x=1795712392; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RJzTbt4b5o1R8Zwzsovu5HVY5FLB11k288WW5ys9/qo=; b=VvC6qSnzy8BZVKTwul/T4JyeENVSgfwhy2tCKMYX6cW+wTYMA2PcrKGmxPQ1t492xQ leeZH9my8+Fo+i4tkYrdYagUt2rGWMsvZ0eiOVjNyCWRZbyblYA+ZnH0UCBPssgP9l1D uYfDsRcLPOLBUbzyEv4egbDJTRszifBdp8v2qxSFHY5agr+0zWalWuwHagt/2bii9PVs GZWfqsNNkzAYPTypYoKMn2w7OE55q1EQZd2atAQj44mUjb/ju8987XwxOCMg8FWhCIm5 bgrjBu+7HQ6RdjqOJIRyjfD5M7J933FdMcUzzNpy668MQAcBXOZMWIHPAkRkTFuSYleu GhNg== X-Forwarded-Encrypted: i=1; AL+hErEy5qpn1Sl5+09d+MhbLuj8jDyF5WRlm4mWfHLf+RTGPXG31LTF45ZdgLup83jaI41XbQ+ODrAI1JP0@vger.kernel.org X-Gm-Message-State: APuU4Z/bh/rvNm8OAZ+8hNmpABpvEQIZ6T4Q/Ec5gbYf8A741UJ2/ZWL yM1eQ2JJYHsy+XxyN49wWEXd3YS8FybQ6BaGU8hxBp1OlJ85jvDWc9weE4PJoGH9qj8= X-Gm-Gg: AZFdTZf4bLM7LCS1K5LedXLEkokua2i2fbNUogqqfLfyQYyihH/vat1+003G/OTXigh PK8uaMhfSp0n3Zw0Nl/7IoSdlJyR+WXy8gy5r3LmXi4OAWGyyK1FO6OW486OSYQiK6WEpFbHhmp ZpQmVBIwUUlQibtEvk+NlacQgKd9hP++yml1Y9pYJJqBLvD8DEEkt/NK3jZxeJNoDqW2XKegxEz Fr4/Of16M2UFrg8RS0Zo2QyVRmey1lWC0tCwXFeqUbMVdCKS879fV6w0W62YDtLJ9iIUpe1OmXp ka2Rps3+cqOYwUUX0qfE0cMhIJCiSahhS2Lpp3TbaPaE8NoJSDypVbOaceqZCQlx87xCNQOJY7x 86IwWP/sVJjtKm9KgYpHpB/T/W6a0FJOjjMfKociIGNbwkOnpZiJPy9DnmwxTBIrR7vBCIPn+g4 KgxvFoFgg43FfYuSiXDNSS/dFUiLf9lmbKQRjkfqGOOV5PnZPb5nXhKvXUjEh9zGHyIz6XzrYBd 4h6sbiJ10TOWXCT9Q6zMgXAqAtTlM+fkVIXzS53edWGrfAw9j1Qt1NLCOlm8/oTPg/yMxeHZbdJ 7p9q2kCLsyQLcdv43O4sWEprIbhj/J3C X-Received: by 2002:a17:903:4586:b0:2ed:fd82:e905 with SMTP id d9443c01a7336-2f03f207db7mr5065875ad.31.1795107591652; Thu, 19 Nov 2026 08:59:51 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:9bd7:226d:1022:f6ef]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2f03ed3b3c1sm3054985ad.0.2026.11.19.08.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2026 08:59:51 -0800 (PST) Date: Thu, 19 Nov 2026 10:59:48 -0600 From: Mathieu Poirier To: Ben Levinsky Cc: jassisinghbrar@gmail.com, andersson@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, michal.simek@amd.com, tanmay.shah@amd.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/6] dt-bindings: mailbox: Add AMD PL Mailbox IP Message-ID: References: <20261105051902.1646651-1-ben.levinsky@amd.com> <20261105051902.1646651-4-ben.levinsky@amd.com> X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261105051902.1646651-4-ben.levinsky@amd.com> On Wed, Nov 04, 2026 at 09:18:59PM -0800, Ben Levinsky wrote: > Document the AMD programmable-logic Mailbox IP used for bidirectional > FIFO communication between two processor-facing interfaces. > > The Mailbox is a soft IP core instantiated in programmable logic, and the > same SoC can carry different versions of it, so it is not a SoC block. > Like other PL soft IP bindings, use a single compatible that names the IP > core and its version, amd,pl-mailbox-2.1. "pl" distinguishes it from the > IPI hardware that can also act as a mailbox. > > Define the transmit and receive channel indices together with the register > aperture, interrupt, and interface clock. Describe the FIFO depth chosen > for each IP instance when the design is synthesized. It cannot be read > from the registers, and the driver needs it to size received messages. "register aperture"? What is that? > > Assisted-by: Claude:claude-opus-5.5 > Signed-off-by: Ben Levinsky > --- > .../bindings/mailbox/amd,pl-mailbox-2.1.yaml | 73 +++++++++++++++++++ > MAINTAINERS | 6 ++ > 2 files changed, 79 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/amd,pl-mailbox-2.1.yaml > > diff --git a/Documentation/devicetree/bindings/mailbox/amd,pl-mailbox-2.1.yaml b/Documentation/devicetree/bindings/mailbox/amd,pl-mailbox-2.1.yaml > new file mode 100644 > index 000000000000..dc16a2e1142b > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/amd,pl-mailbox-2.1.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mailbox/amd,pl-mailbox-2.1.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AMD Programmable Logic Mailbox IP > + > +maintainers: > + - Ben Levinsky > + > +description: | > + The AMD Programmable Logic Mailbox IP provides bidirectional message passing > + between two processor-facing interfaces. Each interface writes messages to > + a send FIFO and reads messages from a receive FIFO. The register aperture, > + interrupt, and clock described by a node belong to one processor-facing > + interface. Channel 0 represents transmit and channel 1 represents receive > + for that interface. > + > + The Mailbox is a soft IP core instantiated in programmable logic, not a > + SoC block, so the compatible names the IP core and its version (2.1). > + The "pl" part distinguishes it from the IPI hardware that can also be > + used as a mailbox. > + > +properties: > + compatible: > + const: amd,pl-mailbox-2.1 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + amd,pl-mailbox-depth: > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 16 > + maximum: 8192 > + default: 16 > + description: > + Depth of the send and receive FIFOs in 32-bit words. The depth is the > + C_MAILBOX_DEPTH parameter chosen for each IP instance when the design > + is synthesized, so instances in one design can differ, and it cannot > + be read from the registers. Must match the synthesized depth. > + > + '#mbox-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - '#mbox-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + mailbox@b2060000 { > + compatible = "amd,pl-mailbox-2.1"; > + reg = <0xb2060000 0x10000>; > + interrupts = ; > + clocks = <&pl_clk>; > + amd,pl-mailbox-depth = <16>; > + #mbox-cells = <1>; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 1e3f9f2751fe..3722a66b9960 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1306,6 +1306,12 @@ S: Supported > T: git https://gitlab.freedesktop.org/agd5f/linux.git > F: drivers/gpu/drm/amd/pm/ > > +AMD PROGRAMMABLE LOGIC MAILBOX DRIVER > +M: Ben Levinsky > +L: linux-kernel@vger.kernel.org > +S: Maintained > +F: Documentation/devicetree/bindings/mailbox/amd,pl-mailbox-2.1.yaml > + > AMD PSTATE DRIVER > M: Huang Rui > M: Mario Limonciello > -- > 2.34.1 >