Re: [PATCH v2 5/5] iio: light: gp2ap020a00f: Add GP2AP030A00F support

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Sun, Nov 08, 2026 at 10:44:03PM +0100, Linus Walleij wrote:
> The GP2AP030A00F has the same register addresses and interrupt modes
> as the GP2AP020A00F, but does not implement its automatic
> illuminance calculation or selectable ambient-light cancellation.

...

>  config GP2AP020A00F
> -	tristate "Sharp GP2AP020A00F Proximity/ALS sensor"
> +	tristate "Sharp GP2AP020A00F and similar Proximity/ALS sensors"

Also make sure the text in MODULE_DESCRIPTION() and perhaps top comment in the
code matches the above (ideally be the same).

>  	depends on I2C
>  	select REGMAP_I2C
>  	select IIO_BUFFER
>  	select IIO_TRIGGERED_BUFFER
>  	select IRQ_WORK
>  	help
> -	  Say Y here if you have a Sharp GP2AP020A00F proximity/ALS combo-chip
> -	  hooked to an I2C bus.
> +	  Say Y here to enable support for the Sharp GP2AP020A00F and similar
> +	  proximity/ALS combo-chips hooked to an I2C bus.

Here we actually want more precise list of supported part numbers.

...

/* ...a comment to explain the delay... */

> +	if (!data->chip_info->has_als_auto)
> +		fsleep(1000);

1 * USEC_PER_MSEC

...

> +	{ .name = "gp2ap030a00f",
> +	  .driver_data = (kernel_ulong_t)&gp2ap030a00f_chip_info },

Same comment about the chosen style.

-- 
With Best Regards,
Andy Shevchenko