From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794303610; b=FSnk6hW6H6Bkl9vJAHTm59jFNQr0YBzVTRC7L9S3SPTjvuRC17ulkU3WVJbg92/iS856 PxaSxqpIOUZPIR3EaQl/jQXSDSfiopiexlkxhk7GWCkiwR22zvFSJeG3cTGbzvydRNDTW M8VuwvbKv+jSoQ8Yt4rlIN3Ulf18CyawhIlIzvssDZOIXZgLWaxFzsjgQUEU5zwklG+/B lsKAlJbCqFo6jz7lMeNj9LIHs1cO4XUJe3PfkGXyACrRokS8AogkW3B+y/ZRlq8O9vw9h YeBxdob82U0uBtucITbhmbJf4Gen+fzXQSOSFf9xtRIgBsjJANnHoHE2TNDzYhWScew== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794303610; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=XQa27/t7HuzOBuNW1CeD2HKdjuOcRupBblm3fp1zI2g=; b=XIMmsw9/Rupawp2DcaRktwtH8qIclbn1w0rklZxRvD9+MTXxVdv0x0BvP0BIYnzETQfm SJX2z8+3xNxVIww9NIDZ07Nu4J6SPfcTFJoN7cPDKf7bXj5lKD+MApIple+QFr+GapUg4 j16XSAodimMOsXzvtHKmVPrRzzo/E56BL7a2tvPnf1jne63KcaGi/AIVuaY+buzh29dD3 a3GU7Qa9Tzrym7qOLRkal0BbOjrK76sSrv0yDLd+11HNyqxxljMJ+DH0SbyrcP47/xIuc scH+LLF27y0ydk26PBKARy2T1EwBwwLKCE9PoB8K7Xy+X78N96y40sAFOOsTaShvp9A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b="TF/xYG7t"; arc=none smtp.remote-ip=209.85.128.41 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E5216071E57 for ; Tue, 10 Nov 2026 09:40:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 7E5216071E57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=TF/xYG7t Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4b4571ff080so21288965e9.1 for ; Tue, 10 Nov 2026 01:40:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1794303608; x=1794908408; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=XQa27/t7HuzOBuNW1CeD2HKdjuOcRupBblm3fp1zI2g=; b=TF/xYG7t7x1jbQ2fkewApK9XPbzgcslO0bbHQVtZ5wAEbYigvOl3NpUKklUkDpBtpr 2DRSJ1ReEvAsRGPpys6MGzFXuDCRkWzzbdedmHZ19KvHYtblOIk1XnFmA7Wg1d9TmSGe ShnhjNlgjmAOhYxzi7mMtg0IW9yAaF8cFZeBoU1kxKP7SNTJ9ltKduxXeUZx4qzkME9H fwvBZZvDXV/Vv8OeYBUZBIlVhXwnwqleCIlKHNUQpKs1lAVi0ldCU0n4Yh+5HqT35etm QTh8y217ftPTp6spLfo4rfV9SHbIUgmQwkI+zz5fykOeFWCn3LqsFiuRnjs+qywhyfk7 Yxkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794303608; x=1794908408; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XQa27/t7HuzOBuNW1CeD2HKdjuOcRupBblm3fp1zI2g=; b=JOC1uQkXUtSqIvMewqDQRFhoDNhnEs9NpujrC0et+jKcvnAs1LU+huukrY51VW/I5g CG3t/7sw1SfSJLKHGCr9rJnOgqKaGiSTobQ6G+ratXvMbIUXDHYucjHCW/VU/CemCJSN L9aMPxLZcfScJolG8uFb7QdpfSLq2k4EqnO5Ol1vi2ancUEwrUHfGVdomZmv+oTWAI+v ajEylvhm9oUH6kT23cv/06yAvw23YjpU/cKh0yb9tR6wC9doq6vo2z/ZrtAuEE7l+LV4 ESHdb1YLGOiVi4+7Z3ADt8Dgs/i/ELDeBsyLghgSyS6Kv/G/MTufXL84I6KxZzKbbyyH M71Q== X-Forwarded-Encrypted: i=1; AL+hErF6g6FCwGUh9/18f54gHKsq1n9GpCsstMCJraHmcvutwZD5IO/5XynAY/grvXlwW39Be+XREzS9Ghas@vger.kernel.org X-Gm-Message-State: APuU4Z+DE1jRdpBbeU30nZRDKev3YItU6SHNYZg+Ld775rddpmpjj/Fh HhIilOz8hPUcQHJjWDN/+j31zvubDAm6xwkYqwEN7HWCKcEccQZv7NZ55GxptDyW/5c= X-Gm-Gg: AYBFou1zvWDPx39/7iPf0s/5jRqvKdLF4VmRZbZeTBEufOaZ1TQy22AVnrYR/P3/4Io F5ZE0DqmuSspfLmtGZBzS60Y+tUBgr4wUkBFeaiJZUsAAiQ74FVaN0j0C3Er7xzHIccxXR01bFU Pp71Rnv8lfmKONf+iLganI4788Ip/+jgTqRH2X3AlHwhRM6gVNj0YSPP3KRDbsdjLPw5s3Cgs1R MWcnNiUzZJ+NiqgAN+0GaB4AbXK+MlCtUhvqozvsx3mfTwNc28tPIsEWGRfUFI2cFjiv/URyGL7 FyNWT64VKZ+H7zCWhU2VtBYVfjMKsUy8G9GefkcD4F8rEfuduM9g2Mse4V43Zwl0CoHiTI3prgl 1nRlsp+Q5YZqiJF+zXi5BXCaRLB1l5SUHbkrs4u4/LRCtx6BsuVvF+OhCNJjAc7v2nhhPtczlqK gvVZjlBGUMSCBKhDznB6wrDKtWo6mW9UL42DRmUlRjs6fTnF2oXjCgmFrkhElnhqw0IeLHcy07N /ZPMdVtnU/CCSL9s06vCfiUaeXwz1PatQnAxxgDPiugFJzDARUvYqmojVZcmbq4e2qJHQTkFKy5 HMcOnn/4D4yWhcEEP6ERUkQC7D5f2Zerp8Q= X-Received: by 2002:a05:600c:6296:b0:4a1:fe26:24f0 with SMTP id 5b1f17b1804b1-4ba02348dd9mr31353275e9.20.1794303607698; Tue, 10 Nov 2026 01:40:07 -0800 (PST) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4ba022ff5c3sm23953585e9.0.2026.11.10.01.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 01:40:06 -0800 (PST) Date: Tue, 10 Nov 2026 10:40:05 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Andy Shevchenko Cc: Jonathan Cameron , Maxime Chevallier , David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matti Vaittinen , Rodolfo Giometti , Marcelo Schmitt , Antoniu Miclaus , Angelo Dureghello , Tobias Sperling , Eason Yang , Marilene Andrade Garcia , Cosmin Tanislav , duje@dujemihanovic.xyz, herve.codina@bootlin.com, thomas.petazzoni@bootlin.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] iio: adc: add driver for Texas Instruments TLA2528 adc Message-ID: References: <20261030164705.297354-1-maxime.chevallier@bootlin.com> <20261030164705.297354-3-maxime.chevallier@bootlin.com> <20261108013218.0fe627e7@jic23-hlaptop> X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xrvk6vw4g5gzbbvg" Content-Disposition: inline In-Reply-To: --xrvk6vw4g5gzbbvg Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 2/2] iio: adc: add driver for Texas Instruments TLA2528 adc MIME-Version: 1.0 Hello, On Mon, Nov 09, 2026 at 07:44:12PM +0200, Andy Shevchenko wrote: > On Sun, Nov 08, 2026 at 09:32:10AM +0100, Uwe Kleine-K=F6nig wrote: > > On Sun, Nov 08, 2026 at 01:32:18AM +0000, Jonathan Cameron wrote: > > > On Thu, 5 Nov 2026 16:42:42 +0100 > > > Uwe Kleine-K=F6nig wrote: > > >=20 > > > > On Fri, Oct 30, 2026 at 05:47:04PM +0100, Maxime Chevallier wrote: > > > > > +#include > > > > > +#include =20 > > > >=20 > > > > Please don't include . alrea= dy > > > > provides i2c_device_id and of_device_id. > > > > provides many more *_device_id and thus introduces a big list of > > > > unnecessary dependencies. > > > >=20 > > > > I recommend to just drop here. If you ins= ist > > > > on full iwyu, there is and > > > > . >=20 > It must also imply acpi.h. That's true, but irrelevant for the patch under discussion because it doesn't use acpi stuff. So at least here even with full iwyu you don't need to care about or . Best regards Uwe --xrvk6vw4g5gzbbvg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmry5nIACgkQj4D7WH0S /k5A0Qf/UlVG2sAQs+UgFERuB1rhQInSRoLdCeHto+8YE/qkryzNXfzSyOCOV13b /4pNCDCt0zmQeG7W6eHGlvBpZiSUL9nHf6qsm+/Sciw7X7qMOKZUJbE092MErD+I F9LUxplu7GHBBDeVVwgNSmiIQW1gRlMcNTWHJahPCplAj0sv1g8OEZXOl8FZk08C 6qjffOFMonsW4Q+oKUrQhW8lPsHU74Ah5LooLSWhdfEaWsgrgpXrRYRilKAmDGJw Q/32M3v6YNBZjZparnKx/Ycw0xsdBW4BrzeKro5GBXDJjyHyEMeipV3I4ecZBVDg /uBtYslaJ/7hIygWqlHNxNzvlVAWvg== =3Cj6 -----END PGP SIGNATURE----- --xrvk6vw4g5gzbbvg--