From: Zhengping Zhang <zhengping.zhang@airoha.com>
To: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
Cc: <linusw@kernel.org>, <lorenzo@kernel.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <brgl@kernel.org>,
<naseefkm@gmail.com>, <benjamin.larsson@genexis.eu>,
<linux-gpio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <lei.dong@airoha.com>,
<ansuelsmth@gmail.com>
Subject: Re: [PATCH 05/12] pinctrl: airoha: an7581: select force GPIO mode on GPIO requests
Date: Fri, 20 Nov 2026 15:19:27 +0800 [thread overview]
Message-ID: <av_0f3bRXyWTSUYy@mediatek.com> (raw)
In-Reply-To: <80e72b60-3128-4594-a4bf-bb184ffc754b@iopsys.eu>
Hi Mikhail,
Thanks for the suggestion. I agree that selecting GPIO mode by disabling
the relevant functions would be preferable to use the FORCE_GPIO
registers.
I plan to change the implementation as follows:
- Select GPIO mode by disabling the relevant alternate functions,
without setting FORCE_GPIO. Reject requests that conflict with
existing users.
- When selecting a peripheral function, clear FORCE_GPIO overrides
where needed so that the peripheral can control the pad.
Would this approach address your concern? If it looks reasonable, I will
adopt it in v2 and validate.
Best Regards,
Zhengping
On Sun, Nov 15, 2026 at 05:21:15PM +0300, Mikhail Kshevetskiy wrote:
> I think it's better does not play with force gpio registers and just
> disable (if no conflicts) functions that put selected pin to non-gpio mode.
next prev parent reply other threads:[~2026-11-20 7:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 9:43 [PATCH 00/12] pinctrl: airoha: configure GPIO muxes explicitly and fix pad mappings Zhengping Zhang
2026-11-10 9:43 ` [PATCH 01/12] pinctrl: airoha: fix setting of GPIO direction Zhengping Zhang
2026-11-10 9:53 ` sashiko-bot
2026-11-10 9:43 ` [PATCH 02/12] pinctrl: airoha: configure pin muxes on GPIO requests Zhengping Zhang
2026-11-10 10:14 ` sashiko-bot
2026-11-10 9:43 ` [PATCH 03/12] dt-bindings: pinctrl: airoha: describe all EN7581 GPIO mux groups Zhengping Zhang
2026-11-15 14:00 ` Mikhail Kshevetskiy
2026-11-10 9:43 ` [PATCH 04/12] pinctrl: airoha: an7581: fix PHY LED GPIO group assignments Zhengping Zhang
2026-11-15 14:02 ` Mikhail Kshevetskiy
2026-11-20 7:03 ` Zhengping Zhang
2026-11-10 9:43 ` [PATCH 05/12] pinctrl: airoha: an7581: select force GPIO mode on GPIO requests Zhengping Zhang
2026-11-10 10:00 ` sashiko-bot
2026-11-15 14:21 ` Mikhail Kshevetskiy
2026-11-20 7:19 ` Zhengping Zhang [this message]
2026-11-10 9:43 ` [PATCH 06/12] dt-bindings: pinctrl: airoha: describe all AN7583 GPIO mux groups Zhengping Zhang
2026-11-10 9:43 ` [PATCH 07/12] pinctrl: airoha: an7583: fix SPI pin mux config Zhengping Zhang
2026-11-10 9:43 ` [PATCH 08/12] pinctrl: airoha: an7583: fix eMMC " Zhengping Zhang
2026-11-10 9:43 ` [PATCH 09/12] pinctrl: airoha: an7583: use force GPIO mode for GPIO requests Zhengping Zhang
2026-11-10 9:56 ` sashiko-bot
2026-11-15 14:23 ` Mikhail Kshevetskiy
2026-11-10 9:43 ` [PATCH 10/12] dt-bindings: pinctrl: airoha: describe all EN7523 GPIO mux groups Zhengping Zhang
2026-11-10 9:43 ` [PATCH 11/12] pinctrl: airoha: en7523: use force GPIO mode for GPIO requests Zhengping Zhang
2026-11-15 14:24 ` Mikhail Kshevetskiy
2026-11-10 9:43 ` [PATCH 12/12] MAINTAINERS: add myself as Airoha pinctrl co-maintainer Zhengping Zhang
2026-11-15 14:09 ` [PATCH 00/12] pinctrl: airoha: configure GPIO muxes explicitly and fix pad mappings Mikhail Kshevetskiy
2026-11-18 21:15 ` Linus Walleij
2026-11-20 6:39 ` Zhengping Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av_0f3bRXyWTSUYy@mediatek.com \
--to=zhengping.zhang@airoha.com \
--cc=ansuelsmth@gmail.com \
--cc=benjamin.larsson@genexis.eu \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lei.dong@airoha.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=mikhail.kshevetskiy@iopsys.eu \
--cc=naseefkm@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox