From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=195.154.119.183 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794944712; b=Z9fILV1hN1E7Dwnod6kiGZSvWqJuiEwdI1T93N/a2zF4ZMFzhk7yBqlr4TFZHSvtdxTe snmR/BmigUBckhuNDscW/KJY3yLn0nS9xWiE15330XmvL+yciZ9wcZeDgUDvQpNtQIKe3 9sWYHn9dWOr9gM54gXdplkpFN1Q8YT97+ujU/UYj+pJxEqrVez5Ro6LOOTr13o1djC/+w GAu20QB+9G8BSAtCevZlEZkFt23TBgo2dmW27D+X4mCUg8TBSqv6KAszUQigqCAVdV9vE QiKJCbHMEq/q2D9sIa68M3l+781nDRUWZDo28TNwc24NrudDLb+WXA0qxvyNOMfDhxw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794944712; h=DMARC-Filter:DKIM-Signature:Received:Date:From:To:Cc:Subject: Message-ID:Mail-Followup-To:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:User-Agent; bh=VuZ/I+cuk23Nm53wl2KO38eekn+IzGCv1RFvj+K8iEo=; b=saJhprEMLz1OXOCgEuPXstFpAfJHQjmIrAgee7WIO2yWzUPzL0SsBPHqoV1e7GIBoDbj ykBpS0d6eCpVaEwp/XngALYmItcyqDKj0Ym6EnqXeyBVs8z3aShmjbl5mPU2/yS0NAKrw soTwbyd0kM0q3Re5IUE63nDYb0Edv8Qr1ay4+x9g+vEVXhu1G8K57WlE6zDsOCtWMeVrw 6N02wf0/jbC80+OfwtrwpGcGBU4YBqcFcVwXe6PL1HAHtN0TGSSUp1ojzApCk5tbJ2g2K NC03GEHZEWtrF3slA3fBLCubwA/9vN8VpgmlOWBpzesvpMGfoFNeH3TKk8AC5Ttc7lg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=aurel32.net; spf=pass smtp.mailfrom=aurel32.net; dkim=pass header.d=aurel32.net header.i=@aurel32.net header.a=rsa-sha256 header.s=202004.hall header.b=nEKbTYL1; arc=none smtp.remote-ip=195.154.119.183 Received: from hall.aurel32.net (hall.aurel32.net [195.154.119.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1536606A330; Tue, 17 Nov 2026 19:45:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D1536606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aurel32.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aurel32.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=aurel32.net header.i=@aurel32.net header.a=rsa-sha256 header.s=202004.hall header.b=nEKbTYL1 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=VuZ/I+cuk23Nm53wl2KO38eekn+IzGCv1RFvj+K8iEo=; b=nEKbTYL1GBCQS0OfY65OSFA62A RrbS3Ad1q7Z5BQztVMtcyQ48Wh485qdaV4ipBtnBOUCAOps65ygy0i49BmvRQ9ht3CEG9G0e/9MbE tD/VjiZxDdl8A1ttcx/7cct5FG3dmIh39Vsd8BVdKD4KV/xbN6ThAxzWKYuZPPsF5juD8aYZPWhiJ S6tOtNcWORqHu7FKi6y5yFM6eq8X5+kgLON5BUsdVS/PZxTuN3ynlvk0QenklV/NFu9Qx9hnihtRP phdK441mNvtRSyVI7lpe80SQ37We/Xwvn+BBFXsKytCXX8M85mAEB8v/JedswWMZoe8g4KKKrS39p hi4hf0oA==; Received: from authenticated user by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xTP6q-0000000GSWQ-20lh; Tue, 17 Nov 2026 20:44:52 +0100 Date: Tue, 17 Nov 2026 20:44:51 +0100 From: Aurelien Jarno To: E Shattow Cc: Yixun Lan , "James E.J. Bottomley" , "Martin K. Petersen" , Alim Akhtar , Avri Altman , Bart Van Assche , Bean Huo , Stanley Jhu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Anirudh Srinivasan , Jennifer Berringer , Trevor Gamblin , linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v8 0/2] Add UFS Host driver support for SpacemiT K3 SoC Message-ID: Mail-Followup-To: E Shattow , Yixun Lan , "James E.J. Bottomley" , "Martin K. Petersen" , Alim Akhtar , Avri Altman , Bart Van Assche , Bean Huo , Stanley Jhu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Anirudh Srinivasan , Jennifer Berringer , Trevor Gamblin , linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20261116-08-k3-ufs-support-v8-0-e3b256972dd4@kernel.org> <8462a0d9-e9b7-467d-b2e1-7870c78e2691@freeshell.de> X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8462a0d9-e9b7-467d-b2e1-7870c78e2691@freeshell.de> User-Agent: Mutt/2.4.1 (2026-07-04) Hi, On 2026-11-16 17:15, E Shattow wrote: > Hi Yixun, > > On 11/15/26 19:46, Yixun Lan wrote: > > This series try to add UFS support for SpacemiT K3 SoC, the controller > > components consists of System Bus Interface Unit, UFS Host Controller > > Interface, UFS Transport Protocol Layer, UFS Host Registers, Device > > Management Entity (DME), Transport Layer, Network Layer, Data Link > > Layer, PHY Adapter Layer, and M-PHY Interface. A more detail functional > > block diagram can be found in SpacemiT website, chapter 9.7.3 [1] > > > > The DTS patch has been dropped in this series [2], and will send > > in separate series once this patch accepted. For people who want to > > test UFS driver, please grab the DT patch from version v5 [3]. > > > > Enable UFSHCD_CAP_KEEP_AUTO_BKOPS_ENABLED_EXCEPT_SUSPEND, > > This allows the device auto-bkops to be always enabled except > > during suspend (both runtime and suspend), with this feature, > > the BKOPS interrupt (log below) isn't reported anymore. > > > > [ 806.710763] ufshcd-spacemit c0e00000.ufshc: ufshcd_bkops_exception_event_handler: device raised urgent BKOPS exception for bkops status 1 > > > > Link: https://spacemit.com/community/document/info?nodepath=hardware/key_stone/k3/k3_docs/k3_usermanual/09_memory_storage.md&lang=en [1] > > Link: https://lore.kernel.org/all/20260918-belligerent-succinct-kraken-7fa592@quoll/ [2] > > Link: https://lore.kernel.org/all/20260916-08-k3-ufs-support-v5-3-1f5d71f1027d@kernel.org/ [3] > > Signed-off-by: Yixun Lan > > --- > > Changes in v8: > > - enable UFSHCD_CAP_KEEP_AUTO_BKOPS_ENABLED_EXCEPT_SUSPEND > > - rename to "ref_clk", see explanation in patch > > - add delay between enable clk & deassert reset > > - respect bRefClkGatingWaitTime, add wait delay > > - drop comment of ufs_hba_spacemit_vops, which got CI complaint > > - rebase to v7.4-rc1 > > - Link to v7: https://patch.msgid.link/20261002-08-k3-ufs-support-v7-0-bb39007ff9ae@kernel.org > > > > Changes in v7: > > - check err return value of ufs_spacemit_quirk_host_pa_saveconfigtime() > > - Link to v6: https://patch.msgid.link/20260921-08-k3-ufs-support-v6-0-3479768a2299@kernel.org > > > > Changes in v6: > > - drop unused macro and dev_req_params > > - use global PX_xx macros > > - fix axi clock name > > - drop dts patch > > - collect tags > > - Link to v5: https://patch.msgid.link/20260916-08-k3-ufs-support-v5-0-1f5d71f1027d@kernel.org > > > > Changes in v5: > > - adjust clock names > > - add runtime power support > > - collect tags > > - Link to v4: https://patch.msgid.link/20260908-08-k3-ufs-support-v4-0-22aa2bd97d3b@kernel.org > > > > Changes in v4: > > - fix clock and reset settings > > - drop function which retrieve value of tx_lanes > > - propagate return error of ufs_spacemit_dme_set() > > - check return value ufs_spacemit_check_hibern8() > > - drop call to ufshcd_vops_phy_initialization() > > - handle compiling warning if CONFIG_OF not enabled > > add __maybe_unused to ufs_spacemit_of_match > > - Link to v3: https://patch.msgid.link/20260806-08-k3-ufs-support-v3-0-037fb322acdb@kernel.org > > > > Changes in v3: > > - collect tags > > - fix dt-binding warning reported-by sashiko > > - fix low freq in opp-2 table > > - fix err checking in check_hibern8() > > - propagate err code in link_startup_notify() > > - update documents for event_notify() > > - ufs clock driver is merged into v7.3-rc1, update cover letter > > - Link to v2: https://patch.msgid.link/20260725-08-k3-ufs-support-v2-0-45036a2a2418@kernel.org > > > > Changes in v2: > > - fix missing interrupts property > > - move ufs node to k3-com260.dtsi > > - convert freq-table-hz to operating-points-v2 > > - rework reset_control, fix header and drop global variable > > - drop dump_host_regs() debug interface > > - converge and refactor dme_set() operations > > - massive reduce of busy delay() loops > > - drop vendor specific hce_enable_notify(), fallback to default > > - drop unused member from struct ufs_spacemit_host > > - add COMPILE_TEST support to Kconfig > > - comment style fix > > - Link to v1: https://patch.msgid.link/20260702-08-k3-ufs-support-v1-0-1a64a3ab128f@kernel.org > > > > --- > > Yixun Lan (2): > > scsi: ufs: spacemit: dt-bindings: Add UFS controller for K3 SoC > > scsi: ufs: spacemit: k3: Add UFS Host Controller driver > > > > .../devicetree/bindings/ufs/spacemit,k3-ufshc.yaml | 56 ++ > > drivers/ufs/host/Kconfig | 12 + > > drivers/ufs/host/Makefile | 1 + > > drivers/ufs/host/ufs-spacemit.c | 655 +++++++++++++++++++++ > > drivers/ufs/host/ufs-spacemit.h | 77 +++ > > 5 files changed, 801 insertions(+) > > --- > > base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4 > > change-id: 20260605-08-k3-ufs-support-c8b308e415e2 > > > > Best regards, > > -- > > Yixun Lan > > > > > > _______________________________________________ > > linux-riscv mailing list > > linux-riscv@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-riscv > > Tested v7 and v8 successfully on Sipeed K3 Pico-ITX (32GiB DRAM / 128GiB > UFS model). Build and test methodology: > > ### build chimera debian-installer with patched mainline kernel > ### assume fresh Debian testing "forky" build environment > > apt update > apt install -y b4 bc bison ca-certificates cpio \ > crossbuild-essential-riscv64 curl debhelper fakeroot flex kmod \ > libdw-dev libssl-dev libssl-dev:riscv64 linux-config-7.2:riscv64 \ > python3 rsync > > curl -L \ > https://git.kernel.org/torvalds/t/linux-7.4-rc3.tar.gz \ > | tar xz > > pushd linux-7.4-rc3 > b4 am -v1 -o- \ > https://lore.kernel.org/all/20261115195112.32120-1-e@freeshell.de/ \ > | patch -p1 > b4 am -v5 -P3 -o- \ > https://lore.kernel.org/all/20260916-08-k3-ufs-support-v5-0-1f5d71f1027d@kernel.org/ \ > | patch -p1 After applying that patch, you also need to change: clock-names = "axi", "ref"; into clock-names = "axi", "ref_clk"; to match the change done in the code in v8. [...] > I do notice some UFS-related warnings and errors in dmesg: > > journalctl --dmesg | grep ufshcd > ufshcd-spacemit c0e00000.ufshc: freq-table-hz property not specified > ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find > vdd-hba-supply regulator, assuming enabled > ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find > vcc-supply regulator, assuming enabled > ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find > vccq-supply regulator, assuming enabled > ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find > vccq2-supply regulator, assuming enabled > scsi host0: ufshcd > ufshcd-spacemit c0e00000.ufshc: ufshcd_scsi_add_wlus: BOOT WLUN not found I do have all those messages, I think they are just harmless. > ufshcd-spacemit c0e00000.ufshc: DL error event, INT errors:0x4, > DL_ERR:0x80000020 This one looks more worrying. I do not have it when testing. Does it happens immediately or after a while? under load? Regards Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://aurel32.net