From: Francesco Valla <francesco@valla.it>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Peng Fan <peng.fan@nxp.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC v2 05/11] remoteproc: virtio: report VIRTIO_F_ACCESS_PLATFORM when required
Date: Tue, 17 Nov 2026 23:18:03 +0100 [thread overview]
Message-ID: <avzQI6R9LubGP7-d@bywater> (raw)
In-Reply-To: <avs6XQpoQmY_MNYx@p14s>
On Mon, Nov 16, 2026 at 11:16:13AM -0600, Mathieu Poirier wrote:
> On Mon, Nov 02, 2026 at 12:26:42AM +0100, Francesco Valla wrote:
> > Depending on the driver originating them, data buffers used for virtio
> > communication can either:
> >
> > - already be allocated from the coherent memory area that is
> > accessible by the remote processor; this is the case of
> > remoteproc-specific virtio devices, i.e., rpmsg and rproc-serial;
> > - be allocated from generic kmem, and thus not necessarily accessible
> > directly by the remote processor.
> >
> > In the second case, the DMA APIs can be exploited to obtain a
> > functional communication, since they will take care of cache maintenance
> > and - if required - bounce buffering. The VIRTIO_F_ACCESS_PLATFORM
> > feature flag can be used for this purpose: with it set, the virtio
> > framework will use the aforementioned DMA APIs to map and unmap buffers.
> >
> > Bounce buffering will be transparently used in two cases:
> >
> > - if the buffer address supplied by the virtio driver is not suitable
> > for DMA transfers, or
> > - if the reserved memory associated to the vdev is a
> > restricted-dma-pool; in this case, *all* buffers will be bounced to
> > and from this pool.
> >
> > With this support in place, any kind of virtio device can be supported
> > through the remoteproc-virtio transport, at least from a data exchange
> > standpoint.
> >
> > Note that remote processors behind an IOMMU need da == pa for the memory
> > region(s) the buffers are allocated from.
>
> I'm not sure to understand the da == pa requirement - can you expand more on
> that?
>
Yes! With a caveat: the IOMMU usage by the remoteproc framework and how
it can integrate with this work is the main reason this is an RFC, as
stated in the cover letter, because I'm not sure I understand all of it.
See for example the dma-to-da conversion in [1] or the comment in [2].
That said: all the IOMMU setup that is done today by the remoteproc core
is linked to the *remoteproc* device, not to the rproc_vdev (i.e., the
device backing the virtio device). For that reason, the DMA subsystem
should not be able to know that setup even exists, in particular while
performing swiotlb operations. Hence, the requirement to have a 1:1
mapping between da (i.e., the address the device uses) and pa (the
physical memory map).
> >
> > Existing use cases (e.g., rpmsg and virtio-console) are not impacted as
> > they are explicitly excluded.
> >
> > Signed-off-by: Francesco Valla <francesco@valla.it>
> > ---
> > drivers/remoteproc/remoteproc_virtio.c | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c
> > index f1b362158a9c..1496659ddff9 100644
> > --- a/drivers/remoteproc/remoteproc_virtio.c
> > +++ b/drivers/remoteproc/remoteproc_virtio.c
> > @@ -280,9 +280,14 @@ static u64 rproc_virtio_get_features(struct virtio_device *vdev)
> > * All non-remoteproc-specific virtio devices are assumed to be
> > * compliant with virtio specifications 1.x; there is no other method
> > * to transmit this capability from the remote processor to the host.
> > + *
> > + * Virtio devices that are specific for remoteproc usage take care on
> > + * their own to allocate memory from the device's coherent pool; use
> > + * the DMA APIs for the others through VIRTIO_F_ACCESS_PLATFORM.
> > */
> > if (!rproc_virtio_rsc_vdev_rproc_specific(rsc))
> > - features |= (1ULL << VIRTIO_F_VERSION_1);
> > + features |= ((1ULL << VIRTIO_F_VERSION_1) |
> > + (1ULL << VIRTIO_F_ACCESS_PLATFORM));
> >
> > return features;
> > }
> > @@ -312,7 +317,8 @@ static int rproc_virtio_finalize_features(struct virtio_device *vdev)
> > features = vdev->features;
> >
> > if (!rproc_virtio_rsc_vdev_rproc_specific(rsc))
> > - features &= ~(1ULL << VIRTIO_F_VERSION_1);
> > + features &= ~((1ULL << VIRTIO_F_VERSION_1) |
> > + (1ULL << VIRTIO_F_ACCESS_PLATFORM));
> >
> > if (WARN_ON((u32)vdev->features != features))
> > return -EINVAL;
> >
> > --
> > 2.56.0
> >
>
Thank you!
Reagrds,
Francesco
[1] https://elixir.bootlin.com/linux/v7.4-rc1/source/drivers/remoteproc/remoteproc_core.c#L716
[2] https://elixir.bootlin.com/linux/v7.4-rc1/source/drivers/remoteproc/remoteproc_core.c#L461
next prev parent reply other threads:[~2026-11-17 22:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 23:26 [PATCH RFC v2 00/11] remoteproc: add support for any virtio device Francesco Valla
2026-11-01 23:26 ` [PATCH RFC v2 01/11] remoteproc: virtio: cleanup rproc_add_virtio_dev error path Francesco Valla
2026-11-01 23:26 ` [PATCH RFC v2 02/11] remoteproc: virtio: replace commas with semicolons Francesco Valla
2026-11-01 23:26 ` [PATCH RFC v2 03/11] remoteproc: virtio: support dynamic number of vrings Francesco Valla
2026-11-01 23:26 ` [PATCH RFC v2 04/11] remoteproc: report VIRTIO_F_VERSION_1 for non-rproc-specific vdevs Francesco Valla
2026-11-10 15:46 ` Mathieu Poirier
2026-11-10 16:58 ` Francesco Valla
2026-11-01 23:26 ` [PATCH RFC v2 05/11] remoteproc: virtio: report VIRTIO_F_ACCESS_PLATFORM when required Francesco Valla
2026-11-16 17:16 ` Mathieu Poirier
2026-11-17 22:18 ` Francesco Valla [this message]
2026-11-01 23:26 ` [PATCH RFC v2 06/11] dt-bindings: remoteproc: add remoteproc-virtio Francesco Valla
2026-11-01 23:26 ` [PATCH RFC v2 07/11] remoteproc: assign fwnode during vdev registration Francesco Valla
2026-11-02 0:02 ` sashiko-bot
2026-11-17 16:28 ` Mathieu Poirier
2026-11-17 22:29 ` Francesco Valla
2026-11-01 23:26 ` [PATCH RFC v2 08/11] Documentation: remoteproc: expand virtio support section Francesco Valla
2026-11-17 17:31 ` Mathieu Poirier
2026-11-01 23:26 ` [PATCH RFC v2 09/11] remoteproc: imx_rproc: always use non-blocking mailboxes Francesco Valla
2026-11-02 0:03 ` sashiko-bot
2026-11-01 23:26 ` [PATCH RFC v2 10/11] dt-bindings: remoteproc: imx-rproc: support virtio Francesco Valla
2026-11-01 23:26 ` [PATCH RFC v2 11/11] PoC: arm64: dts: imx93-11x11-frdm: add multiple vdevs Francesco Valla
2026-11-02 0:16 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avzQI6R9LubGP7-d@bywater \
--to=francesco@valla.it \
--cc=Frank.Li@nxp.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gustavoars@kernel.org \
--cc=imx@lists.linux.dev \
--cc=kees@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=peng.fan@nxp.com \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=s.hauer@pengutronix.de \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox