Devicetree
 help / color / mirror / Atom feed
From: Drew Fustini <fustini@kernel.org>
To: Thomas Gerner <thomas.gerner@muenchen-mail.de>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	Guo Ren <guoren@kernel.org>, Fu Wei <wefu@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Bluetooth: btbcm: disable read tx power for BeagleV-Ahead
Date: Fri, 20 Nov 2026 15:53:30 -0800	[thread overview]
Message-ID: <awDdetFNaeuxKkbp@x1> (raw)
In-Reply-To: <20261020132604.90708-2-thomas.gerner@muenchen-mail.de>

On Tue, Oct 20, 2026 at 03:26:03PM +0200, Thomas Gerner wrote:
> The bluetooth module of the Ampak AP6203BM is identified by the btbcm
> driver as BCM4362A2.
> 
> The firmware of the bluetooth module on the BeagleV-Ahead reports a
> capability of reading LE tx power. However reading fails. To get
> bluetooth working it is necessary to disable reading of LE tx power on
> the BeagleV-Ahead board. The disable is implemented in a similar way as
> for several Apple boards but uses the board compatible identification
> from the DTB as there is no DMI.

Thanks for sending this patch. Do you know if this is a problem on any
other boards with the AP6203BM?

Also, is there an error message for the failed read?

> 
> Signed-off-by: Thomas Gerner <thomas.gerner@muenchen-mail.de>
> ---
> No changes in v2
> 
>  drivers/bluetooth/btbcm.c | 19 ++++++++++++++++---
>  1 file changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> index 463d59890bef..2d02cc1863d0 100644
> --- a/drivers/bluetooth/btbcm.c
> +++ b/drivers/bluetooth/btbcm.c
[..]
> -static const char *btbcm_get_board_name(struct device *dev)
> +static const char *btbcm_get_board_name(struct hci_dev *hdev)
>  {
>  #ifdef CONFIG_OF
>  	struct device_node *root __free(device_node) = of_find_node_by_path("/");
>  	char *board_type;
>  	const char *tmp;
> +	const char **s;
>  
>  	if (!root)
>  		return NULL;
> @@ -550,8 +556,15 @@ static const char *btbcm_get_board_name(struct device *dev)
>  	if (of_property_read_string_index(root, "compatible", 0, &tmp))
>  		return NULL;
>  
> +	/* disable broken Read LE Min/Max Tx Power on first board found in list */
> +	for (s = board_broken_read_transmit_power; *s; s++)
> +		if (!strcmp(tmp, *s)) {
> +			hci_set_quirk(hdev, HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER);
> +			break;
> +		}

It seems that btbcm_get_board_name() only looks up the board name for
the firmware file so I think it could be unexpected to set a quirk here.
Maybe this would work better?

  static const char * const board_broken_read_transmit_power[] = {
          "beagle,beaglev-ahead",
          NULL
  };
 
  [..]

  if (dmi_first_match(disable_broken_read_transmit_power))
          hci_set_quirk(hdev, HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER);

  if (of_machine_compatible_match(board_broken_read_transmit_power))
          hci_set_quirk(hdev, HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER);


However, I am not very familiar with Bluetooth drivers so I am hoping
Marcel or Luiz can comment too.

Thanks,
Drew

  reply	other threads:[~2026-11-20 23:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 13:26 [PATCH v2 0/2] Enable bluetooth on BeagleV-Ahead Thomas Gerner
2026-10-20 13:26 ` [PATCH v2 1/2] Bluetooth: btbcm: disable read tx power for BeagleV-Ahead Thomas Gerner
2026-11-20 23:53   ` Drew Fustini [this message]
2026-10-20 13:26 ` [PATCH v2 2/2] riscv: dts: thead: Enable bluetooth on BeagleV-Ahead Thomas Gerner
2026-11-20 23:34   ` Drew Fustini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awDdetFNaeuxKkbp@x1 \
    --to=fustini@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=guoren@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=thomas.gerner@muenchen-mail.de \
    --cc=wefu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox