From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Alex Elder <elder@linaro.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Andrew Halaney <ahalaney@redhat.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v2 4/8] arm64: dts: qcom: sa8775p-ride: move the reset-gpios property of the PHY
Date: Tue, 8 Aug 2023 23:09:38 +0200 [thread overview]
Message-ID: <b00740fc-a1bb-483e-86b6-0d2af1e88187@linaro.org> (raw)
In-Reply-To: <20230808190144.19999-5-brgl@bgdev.pl>
On 8.08.2023 21:01, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Device-tree bindings for MDIO define per-PHY reset-gpios as well as a
> global reset-gpios property at the MDIO node level which controls all
> devices on the bus. The latter is most likely a workaround for the
> chicken-and-egg problem where we cannot read the ID of the PHY before
> bringing it out of reset but we cannot bring it out of reset until we've
> read its ID.
>
> I have proposed a comprehensive solution for this problem in 2020 but it
> never got upstream. We do however have workaround in place which allows
> us to hard-code the PHY id in the compatible property, thus skipping the
> ID scanning.
>
> Let's make the device-tree for sa8775p-ride slightly more correct by
> moving the reset-gpios property to the PHY node with its ID put into the
> PHY node's compatible.
>
> Link: https://lore.kernel.org/all/20200622093744.13685-1-brgl@bgdev.pl/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
next prev parent reply other threads:[~2023-08-08 21:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 19:01 [PATCH v2 0/8] arm64: dts: qcom: enable EMAC1 on sa8775p Bartosz Golaszewski
2023-08-08 19:01 ` [PATCH v2 1/8] arm64: dts: qcom: sa8775p: add a node for the second serdes PHY Bartosz Golaszewski
2023-08-08 19:25 ` Konrad Dybcio
2023-08-08 19:01 ` [PATCH v2 2/8] arm64: dts: qcom: sa8775p: add a node for EMAC1 Bartosz Golaszewski
2023-08-08 21:11 ` Konrad Dybcio
2023-08-08 19:01 ` [PATCH v2 3/8] arm64: dts: qcom: sa8775p-ride: enable the second SerDes PHY Bartosz Golaszewski
2023-08-08 21:11 ` Konrad Dybcio
2023-08-08 19:01 ` [PATCH v2 4/8] arm64: dts: qcom: sa8775p-ride: move the reset-gpios property of the PHY Bartosz Golaszewski
2023-08-08 21:09 ` Konrad Dybcio [this message]
2023-08-08 19:01 ` [PATCH v2 5/8] arm64: dts: qcom: sa8775p-ride: index the first SGMII PHY Bartosz Golaszewski
2023-08-08 21:09 ` Konrad Dybcio
2023-08-08 19:01 ` [PATCH v2 6/8] arm64: dts: qcom: sa8775p-ride: add the second " Bartosz Golaszewski
2023-08-08 21:09 ` Konrad Dybcio
2023-08-08 19:01 ` [PATCH v2 7/8] arm64: dts: qcom: sa8775p-ride: add an alias for ethernet0 Bartosz Golaszewski
2023-08-08 21:10 ` Konrad Dybcio
2023-08-08 19:01 ` [PATCH v2 8/8] arm64: dts: qcom: sa8775p-ride: enable EMAC1 Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b00740fc-a1bb-483e-86b6-0d2af1e88187@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).